From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29612C11F67 for ; Tue, 29 Jun 2021 16:54:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE3B661988 for ; Tue, 29 Jun 2021 16:53:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE3B661988 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyGzm-0006kk-WA for qemu-devel@archiver.kernel.org; Tue, 29 Jun 2021 12:53:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyGrw-0007nr-30 for qemu-devel@nongnu.org; Tue, 29 Jun 2021 12:45:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyGrt-0007xG-VR for qemu-devel@nongnu.org; Tue, 29 Jun 2021 12:45:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624985147; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=OlrGwdI7goMVfwmMiRYGxdNAZCWFj35yJpOfoKKO4MU=; b=CkSsfa3/sE9n/Wz7o5OEAQuEeeFGjBzWxtEQiR0q6/eukg9CAWfjsZDVQToTjGkKPlX+0H 9AyhNd7RwDNHZSV1ciSPF1T/uQYduoZFNzCMuChFSCMxosfj/OUfBnACqP27LPqRJcMOlZ vFtRzZDJJH00OSzDM07dBIw8u/wZ7ug= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-268-a0u38Fr_OPWB2UJVLHDIxg-1; Tue, 29 Jun 2021 12:45:43 -0400 X-MC-Unique: a0u38Fr_OPWB2UJVLHDIxg-1 Received: by mail-pj1-f69.google.com with SMTP id o11-20020a17090a420bb029016eed2aa304so13594058pjg.2 for ; Tue, 29 Jun 2021 09:45:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language; bh=OlrGwdI7goMVfwmMiRYGxdNAZCWFj35yJpOfoKKO4MU=; b=cK8zSX01iwouvXMeE7YPBqKk2IQ2CyyFMuFc2jBprFAUR+SWla3auJnQYAnS5dkGbb dHbI4WlNuX0RES+UHbLG0s/mTFPJa5YTUru59f9AuwpnS+X2qIVQLBYDNhfCEu79V44D EJZjoLlVN/FTX55xDPkjNsc1DSYAGmhJKcmeeR/yrOJTCticQYyfJ3UwkSJtKDhS4mqm XfAEo5JmOiaP0WlZDnEih9Np60CZd2Dq533HW/ml+TzsLUAtEgZBYBri90Aciey1N0js 9nmJRMVCVW+Ayy+Wl/B1eWOVeanBfmNun+rFogF7c6fn6ynPqV7oAgccvYH3N8OJf3PV pxkA== X-Gm-Message-State: AOAM533ibxYyru7q+KvIiMcXL0A+JcoDXRD/vwBDVa1miACBgDLYePA2 ejMJZYPNtysM0I8799Qoswd6/JG5DXLIszJGHdQJdMxfr5cWOHJMojZnmg4hkQU4GKSVjzPxD8Z Jbwbnw+EHb1v26js= X-Received: by 2002:a17:90a:380b:: with SMTP id w11mr45170619pjb.19.1624985142640; Tue, 29 Jun 2021 09:45:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwa/pdDNMvHLq0lrMHn1DRlIVbN9W4bexeVThMQXOweZnNvuUUP6MxrSXmDs9+WJktogMqeA== X-Received: by 2002:a17:90a:380b:: with SMTP id w11mr45170604pjb.19.1624985142481; Tue, 29 Jun 2021 09:45:42 -0700 (PDT) Received: from wainer-laptop.localdomain ([179.105.223.44]) by smtp.gmail.com with ESMTPSA id f6sm12257225pfj.28.2021.06.29.09.45.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Jun 2021 09:45:41 -0700 (PDT) Subject: Re: [PATCH 07/11] python: update help text for check-tox To: John Snow References: <20210625154540.783306-1-jsnow@redhat.com> <20210625154540.783306-8-jsnow@redhat.com> <76b9d2ac-75f8-faa7-6198-16f5294004e9@redhat.com> From: Wainer dos Santos Moschetta Message-ID: Date: Tue, 29 Jun 2021 13:45:36 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------6C9E1F2FED73EA7731BF09F6" Content-Language: en-US Received-SPF: pass client-ip=170.10.133.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.435, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wainersm@redhat.com Cc: Thomas Huth , Eduardo Habkost , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Willian Rampazzo , Cleber Rosa , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is a multi-part message in MIME format. --------------6C9E1F2FED73EA7731BF09F6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 6/29/21 12:40 PM, John Snow wrote: > > > On Mon, Jun 28, 2021 at 5:16 PM Wainer dos Santos Moschetta > > wrote: > > Hi, > > On 6/25/21 12:45 PM, John Snow wrote: > > Move it up near the check-pipenv help text, and update it to > suggest parity. > > > > (At the time I first added it, I wasn't sure if I would be > keeping it, > > but I've come to appreciate it as it has actually helped uncover > bugs I > > would not have noticed without it. It should stay.) > > Signed-off-by: John Snow > > > --- > >   python/Makefile | 8 ++++++-- > >   1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/python/Makefile b/python/Makefile > > index 07ad73ccd0..5cb8378b81 100644 > > --- a/python/Makefile > > +++ b/python/Makefile > > @@ -9,13 +9,17 @@ help: > >       @echo "    Requires: Python 3.6 and pipenv." > >       @echo "    Hint (Fedora): 'sudo dnf install python3.6 pipenv'" > >       @echo "" > > +     @echo "make check-tox:" > > +     @echo "    Run tests against multiple python versions." > > +     @echo "    These tests use the newest dependencies." > > +     @echo "    Requires: Python 3.6-3.10 and tox." > > Nit: I'm not sure it is clear '3.6-3.10' is a range rather than a > specific version. > > > It was meant to be a range. Would you prefer "3.6 - 3.10" instead, then? I think it's better. - Wainer > > - Wainer > --------------6C9E1F2FED73EA7731BF09F6 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit


On 6/29/21 12:40 PM, John Snow wrote:


On Mon, Jun 28, 2021 at 5:16 PM Wainer dos Santos Moschetta <wainersm@redhat.com> wrote:
Hi,

On 6/25/21 12:45 PM, John Snow wrote:
> Move it up near the check-pipenv help text, and update it to suggest parity.
>
> (At the time I first added it, I wasn't sure if I would be keeping it,
> but I've come to appreciate it as it has actually helped uncover bugs I
> would not have noticed without it. It should stay.)
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   python/Makefile | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/python/Makefile b/python/Makefile
> index 07ad73ccd0..5cb8378b81 100644
> --- a/python/Makefile
> +++ b/python/Makefile
> @@ -9,13 +9,17 @@ help:
>       @echo "    Requires: Python 3.6 and pipenv."
>       @echo "    Hint (Fedora): 'sudo dnf install python3.6 pipenv'"
>       @echo ""
> +     @echo "make check-tox:"
> +     @echo "    Run tests against multiple python versions."
> +     @echo "    These tests use the newest dependencies."
> +     @echo "    Requires: Python 3.6-3.10 and tox."

Nit: I'm not sure it is clear '3.6-3.10' is a range rather than a
specific version.

It was meant to be a range. Would you prefer "3.6 - 3.10" instead, then?

I think it's better.

- Wainer

 
 
- Wainer
--------------6C9E1F2FED73EA7731BF09F6--