From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Bin Meng <bmeng.cn@gmail.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Palmer Dabbelt <palmer@sifive.com>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Subject: Re: [PATCH v2 2/2] riscv: sifive_u: Add ethernet0 to the aliases node
Date: Sat, 21 Sep 2019 10:51:50 +0200 [thread overview]
Message-ID: <e5bb38d0-42a3-f2f6-1b39-78cd79e64df8@redhat.com> (raw)
In-Reply-To: <1569044491-7875-2-git-send-email-bmeng.cn@gmail.com>
On 9/21/19 7:41 AM, Bin Meng wrote:
> U-Boot expects this alias to be in place in order to fix up the mac
> address of the ethernet node.
>
> This is to keep in sync with Linux kernel commit below:
> https://patchwork.kernel.org/patch/11133033/
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>
> Changes in v2: None
>
> hw/riscv/sifive_u.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c
> index 02dd761..1ac51e3 100644
> --- a/hw/riscv/sifive_u.c
> +++ b/hw/riscv/sifive_u.c
> @@ -270,6 +270,10 @@ static void create_fdt(SiFiveUState *s, const struct MemmapEntry *memmap,
> s->soc.gem.conf.macaddr.a, ETH_ALEN);
> qemu_fdt_setprop_cell(fdt, nodename, "#address-cells", 1);
> qemu_fdt_setprop_cell(fdt, nodename, "#size-cells", 0);
> +
> + qemu_fdt_add_subnode(fdt, "/aliases");
> + qemu_fdt_setprop_string(fdt, "/aliases", "ethernet0", nodename);
> +
> g_free(nodename);
>
> nodename = g_strdup_printf("/soc/ethernet@%lx/ethernet-phy@0",
> @@ -297,7 +301,6 @@ static void create_fdt(SiFiveUState *s, const struct MemmapEntry *memmap,
> qemu_fdt_setprop_string(fdt, "/chosen", "bootargs", cmdline);
> }
>
> - qemu_fdt_add_subnode(fdt, "/aliases");
> qemu_fdt_setprop_string(fdt, "/aliases", "serial0", nodename);
>
> g_free(nodename);
>
next prev parent reply other threads:[~2019-09-21 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 5:41 [PATCH v2 1/2] riscv: hw: Drop "clock-frequency" property of cpu nodes Bin Meng
2019-09-21 5:41 ` [PATCH v2 2/2] riscv: sifive_u: Add ethernet0 to the aliases node Bin Meng
2019-09-21 8:51 ` Philippe Mathieu-Daudé [this message]
2019-09-21 8:50 ` [PATCH v2 1/2] riscv: hw: Drop "clock-frequency" property of cpu nodes Philippe Mathieu-Daudé
2019-09-21 12:36 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bb38d0-42a3-f2f6-1b39-78cd79e64df8@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=bmeng.cn@gmail.com \
--cc=palmer@sifive.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).