From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A58A1C33CB1 for ; Fri, 17 Jan 2020 14:28:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70EC92072B for ; Fri, 17 Jan 2020 14:28:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U+9KhaMQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70EC92072B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isSbj-0005fA-Gg for qemu-devel@archiver.kernel.org; Fri, 17 Jan 2020 09:28:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56221) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isSaG-0004GX-Me for qemu-devel@nongnu.org; Fri, 17 Jan 2020 09:26:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isSaC-0005xU-US for qemu-devel@nongnu.org; Fri, 17 Jan 2020 09:26:48 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:51846 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1isSaC-0005ws-P7 for qemu-devel@nongnu.org; Fri, 17 Jan 2020 09:26:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579271204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qVsodtwfBrwij/miqS2ZlyIQ1UBHq7s6juid958JuAI=; b=U+9KhaMQsfH7IBfA0j7+ajqQQfG+BKiB5MAMJIGkr07o0R+oGzgRvEQetE01s4u8yOhOmp p1Voyr7ble3o0dGg8rlIXN9yY6VFdH9Bc5UCDMJ6gnHELpHArpFHrVsVk3RgDXLG7DgiYw ezKEu2PPUacBQQm+T/kvd4bythQqFU4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-364-P-DWsmVeMBiVTUn3Rg0y9Q-1; Fri, 17 Jan 2020 09:26:41 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 088581005514; Fri, 17 Jan 2020 14:26:40 +0000 (UTC) Received: from [10.3.117.16] (ovpn-117-16.phx2.redhat.com [10.3.117.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B8C395C1B2; Fri, 17 Jan 2020 14:26:37 +0000 (UTC) Subject: Re: [PATCH v6 04/11] hw/sd/ssi-sd: fix error handling in ssi_sd_realize To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org References: <20200110194158.14190-1-vsementsov@virtuozzo.com> <20200110194158.14190-5-vsementsov@virtuozzo.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Fri, 17 Jan 2020 08:26:36 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200110194158.14190-5-vsementsov@virtuozzo.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: P-DWsmVeMBiVTUn3Rg0y9Q-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/10/20 1:41 PM, Vladimir Sementsov-Ogievskiy wrote: > It's wrong to use same err object as errp parameter for several > function calls without intermediate checking for error: we'll crash if > try to set err object twice. > > Fix that, using new ERRP_AUTO_PROPAGATE macro. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > hw/sd/ssi-sd.c | 26 +++++++++++++++++++------- > 1 file changed, 19 insertions(+), 7 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org