From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1326CC3A59E for ; Wed, 21 Aug 2019 15:43:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC57422DA7 for ; Wed, 21 Aug 2019 15:43:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC57422DA7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0Sla-0000zJ-KR for qemu-devel@archiver.kernel.org; Wed, 21 Aug 2019 11:43:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50727) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0SkQ-0008Da-PF for qemu-devel@nongnu.org; Wed, 21 Aug 2019 11:42:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0SkP-000397-Og for qemu-devel@nongnu.org; Wed, 21 Aug 2019 11:42:06 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:55511) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0SkP-00038b-G8 for qemu-devel@nongnu.org; Wed, 21 Aug 2019 11:42:05 -0400 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MMGAg-1hiEq12CwQ-00JGyF; Wed, 21 Aug 2019 17:41:59 +0200 To: Sandra Loosemore , qemu-devel@nongnu.org References: <20190821142151.19995-1-sandra@codesourcery.com> <20190821142151.19995-3-sandra@codesourcery.com> From: Laurent Vivier Openpgp: preference=signencrypt Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: Date: Wed, 21 Aug 2019 17:41:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190821142151.19995-3-sandra@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:kzov8N/oMF4cjE4ZLn1oKyBy+mTYpx+bO1jP9F2QP+7PbBIZUW4 rjMFrXiu/E88G+YaPcZAZtjgZskyC9nLUla6cOGUwmGGZDANJPEh11SaB36OaobfI0uFFvF r7hoCqbmGXjGiSHf51XfRqn1Zo/ENFPxu1TVRo3NlvNSraYUqux1XDPVrr7e8Gdjx1F1BAe fa8MeR57iI0+ZwgVThLZA== X-UI-Out-Filterresults: notjunk:1;V03:K0:RPgUYfZTKug=:KgPcs6ntNxGhB4OI4JEIKp vUyutg+nsy4vPQ/FBDCiId76R21l7+RJTaSucsup3p8tMkbc5YdtWIDLSKomR2oSoz8ZR/bkt CDHaBZojqpxyjs+PadXQFiZIK1uK+rgK+gNNZQvFEqW8ydIDO2Pgw5IstK1K/FRISE4xPkgIg h13+TanUGRXY3xoPj1IYXB9M7qv8BGPIDGEC8goA2p5JYzMl0KwIDmQDWZ1QNbMeQKuL8RnOu 0kH/bi7p3SufQgk4fj9g5LKfK7rrefIoBMrhV1ADEU1rcPqkXtv8TeODLfMRI5h3YNhS4Y0s5 CiIwKahzGADm11WGqOcOmtE1ABldqpxYPAtgllzgJYIeVbys0o/+oEupTnQopgMl4rxyjAipA 8sPRcsfAbwNUZLndEkVyg+619nscBuLJuFgotkFAeFUDcbi1a0nDS4Jamh8J3mkPfApMEVL1e j/XCeHe6HgP2SpdIu107CF0UkksdmvZUMXOUI6G7uy2H1+Amidj2Yft8wtA9dLHmp2JeDecBt WWtzUqtf4iVCb35XHWBEi7ZJPNivaHugw1xMf5qsFyC1nWp00Vee0lqiuHPONJQOo3+yHr80V 0Dv5MvkRv6PIA/WsXbcGLQa2RHTVAmixayLly2WNSJrXqPnTr5hp9WBLzGJOuevgq1BORB8di dfhkgiUjgyMaMVaJyPbAWvTj6LH2G7Q3PKVdo1UENa5w0TbQ3qnRrCquWz1BKkhe1sY/Am1Ya wnX3h6bLOMofcW5vfLOAKck1CO4exZ3PS5hsLG2Ph2OGSZotwBrwVgEelU8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.134 Subject: Re: [Qemu-devel] [PATCH 2/2] target/m68k: Fix bug in semihosted exit handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Chris Wulff Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 21/08/2019 à 16:21, Sandra Loosemore a écrit : > This patch fixes a bug that caused semihosted exit to always return > status 0; it was incorrectly using the value of D0 (which > contains the HOSTED_EXIT request number) instead of D1. > > Signed-off-by: Sandra Loosemore > --- > target/m68k/m68k-semi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c > index 8e5fbfc..f189c92 100644 > --- a/target/m68k/m68k-semi.c > +++ b/target/m68k/m68k-semi.c > @@ -194,8 +194,8 @@ void do_m68k_semihosting(CPUM68KState *env, int nr) > args = env->dregs[1]; > switch (nr) { > case HOSTED_EXIT: > - gdb_exit(env, env->dregs[0]); > - exit(env->dregs[0]); > + gdb_exit(env, env->dregs[1]); > + exit(env->dregs[1]); > case HOSTED_OPEN: > GET_ARG(0); > GET_ARG(1); > Reviewed-by: Laurent Vivier