From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Luc Michel <luc@lmichel.fr>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Havard Skinnemoen <hskinnemoen@google.com>,
Andrew Baumann <Andrew.Baumann@microsoft.com>,
Paul Zimmerman <pauldzim@gmail.com>,
Niek Linnenbank <nieklinnenbank@gmail.com>,
qemu-arm@nongnu.org
Subject: Re: [PATCH v3 08/15] hw/misc/bcm2835_cprman: add a PLL channel skeleton implementation
Date: Sat, 10 Oct 2020 18:05:00 +0200 [thread overview]
Message-ID: <e6e2341a-6ccc-b1cc-6e25-b3d57e1cae6d@amsat.org> (raw)
In-Reply-To: <20201010135759.437903-9-luc@lmichel.fr>
On 10/10/20 3:57 PM, Luc Michel wrote:
> PLLs are composed of multiple channels. Each channel outputs one clock
> signal. They are modeled as one device taking the PLL generated clock as
> input, and outputting a new clock.
>
> A channel shares the CM register with its parent PLL, and has its own
> A2W_CTRL register. A write to the CM register will trigger an update of
> the PLL and all its channels, while a write to an A2W_CTRL channel
> register will update the required channel only.
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Luc Michel <luc@lmichel.fr>
> ---
> include/hw/misc/bcm2835_cprman.h | 44 ++++++
> include/hw/misc/bcm2835_cprman_internals.h | 146 +++++++++++++++++++
> hw/misc/bcm2835_cprman.c | 155 +++++++++++++++++++--
> 3 files changed, 337 insertions(+), 8 deletions(-)
[...]
> diff --git a/include/hw/misc/bcm2835_cprman_internals.h b/include/hw/misc/bcm2835_cprman_internals.h
> index 7aa46c6e18..7409ddb024 100644
> --- a/include/hw/misc/bcm2835_cprman_internals.h
> +++ b/include/hw/misc/bcm2835_cprman_internals.h
> @@ -11,13 +11,16 @@
>
> #include "hw/registerfields.h"
> #include "hw/misc/bcm2835_cprman.h"
>
> #define TYPE_CPRMAN_PLL "bcm2835-cprman-pll"
> +#define TYPE_CPRMAN_PLL_CHANNEL "bcm2835-cprman-pll-channel"
>
> DECLARE_INSTANCE_CHECKER(CprmanPllState, CPRMAN_PLL,
> TYPE_CPRMAN_PLL)
> +DECLARE_INSTANCE_CHECKER(CprmanPllChannelState, CPRMAN_PLL_CHANNEL,
> + TYPE_CPRMAN_PLL_CHANNEL)
>
> /* Register map */
>
> /* PLLs */
> REG32(CM_PLLA, 0x104)
> @@ -98,10 +101,35 @@ REG32(A2W_PLLA_FRAC, 0x1200)
> REG32(A2W_PLLC_FRAC, 0x1220)
> REG32(A2W_PLLD_FRAC, 0x1240)
> REG32(A2W_PLLH_FRAC, 0x1260)
> REG32(A2W_PLLB_FRAC, 0x12e0)
>
> +/* PLL channels */
> +REG32(A2W_PLLA_DSI0, 0x1300)
> + FIELD(A2W_PLLx_CHANNELy, DIV, 0, 8)
> + FIELD(A2W_PLLx_CHANNELy, DISABLE, 8, 1)
> +REG32(A2W_PLLA_CORE, 0x1400)
> +REG32(A2W_PLLA_PER, 0x1500)
> +REG32(A2W_PLLA_CCP2, 0x1600)
> +
> +REG32(A2W_PLLC_CORE2, 0x1320)
> +REG32(A2W_PLLC_CORE1, 0x1420)
> +REG32(A2W_PLLC_PER, 0x1520)
> +REG32(A2W_PLLC_CORE0, 0x1620)
> +
> +REG32(A2W_PLLD_DSI0, 0x1340)
> +REG32(A2W_PLLD_CORE, 0x1440)
> +REG32(A2W_PLLD_PER, 0x1540)
> +REG32(A2W_PLLD_DSI1, 0x1640)
> +
> +REG32(A2W_PLLH_AUX, 0x1360)
> +REG32(A2W_PLLH_RCAL, 0x1460)
> +REG32(A2W_PLLH_PIX, 0x1560)
> +REG32(A2W_PLLH_STS, 0x1660)
> +
> +REG32(A2W_PLLB_ARM, 0x13e0)
> +
> /* misc registers */
> REG32(CM_LOCK, 0x114)
> FIELD(CM_LOCK, FLOCKH, 12, 1)
> FIELD(CM_LOCK, FLOCKD, 11, 1)
> FIELD(CM_LOCK, FLOCKC, 10, 1)
> @@ -171,6 +199,124 @@ static inline void set_pll_init_info(BCM2835CprmanState *s,
> pll->reg_a2w_ana = &s->regs[PLL_INIT_INFO[id].a2w_ana_offset];
> pll->prediv_mask = PLL_INIT_INFO[id].prediv_mask;
> pll->reg_a2w_frac = &s->regs[PLL_INIT_INFO[id].a2w_frac_offset];
> }
>
> +
> +/* PLL channel init info */
> +typedef struct PLLChannelInitInfo {
> + const char *name;
> + CprmanPll parent;
> + size_t cm_offset;
> + uint32_t cm_hold_mask;
> + uint32_t cm_load_mask;
> + size_t a2w_ctrl_offset;
> + unsigned int fixed_divider;
> +} PLLChannelInitInfo;
> +
> +#define FILL_PLL_CHANNEL_INIT_INFO_common(pll_, channel_) \
> + .parent = CPRMAN_ ## pll_, \
> + .cm_offset = R_CM_ ## pll_, \
> + .cm_load_mask = R_CM_ ## pll_ ## _ ## LOAD ## channel_ ## _MASK, \
> + .a2w_ctrl_offset = R_A2W_ ## pll_ ## _ ## channel_
> +
> +#define FILL_PLL_CHANNEL_INIT_INFO(pll_, channel_) \
> + FILL_PLL_CHANNEL_INIT_INFO_common(pll_, channel_), \
> + .cm_hold_mask = R_CM_ ## pll_ ## _ ## HOLD ## channel_ ## _MASK, \
> + .fixed_divider = 1
> +
> +#define FILL_PLL_CHANNEL_INIT_INFO_nohold(pll_, channel_) \
> + FILL_PLL_CHANNEL_INIT_INFO_common(pll_, channel_), \
> + .cm_hold_mask = 0
> +
> +static PLLChannelInitInfo PLL_CHANNEL_INIT_INFO[] = {
Hmm I missed this static definition in an header.
As it is local and only include once, I'd prefer match the
rest of the source tree style and name it .c.inc:
-- >8 --
diff --git a/hw/misc/bcm2835_cprman.c b/hw/misc/bcm2835_cprman.c
index 7e415a017c9..9d4c0ee6c73 100644
--- a/hw/misc/bcm2835_cprman.c
+++ b/hw/misc/bcm2835_cprman.c
@@ -48,7 +48,7 @@
#include "migration/vmstate.h"
#include "hw/qdev-properties.h"
#include "hw/misc/bcm2835_cprman.h"
-#include "hw/misc/bcm2835_cprman_internals.h"
+#include "bcm2835_cprman_internals.c.inc"
#include "trace.h"
/* PLL */
diff --git a/include/hw/misc/bcm2835_cprman_internals.h
b/hw/misc/bcm2835_cprman_internals.c.inc
similarity index 100%
rename from include/hw/misc/bcm2835_cprman_internals.h
rename to hw/misc/bcm2835_cprman_internals.c.inc
---
> + [CPRMAN_PLLA_CHANNEL_DSI0] = {
> + .name = "plla-dsi0",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLA, DSI0),
> + },
> + [CPRMAN_PLLA_CHANNEL_CORE] = {
> + .name = "plla-core",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLA, CORE),
> + },
> + [CPRMAN_PLLA_CHANNEL_PER] = {
> + .name = "plla-per",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLA, PER),
> + },
> + [CPRMAN_PLLA_CHANNEL_CCP2] = {
> + .name = "plla-ccp2",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLA, CCP2),
> + },
> +
> + [CPRMAN_PLLC_CHANNEL_CORE2] = {
> + .name = "pllc-core2",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLC, CORE2),
> + },
> + [CPRMAN_PLLC_CHANNEL_CORE1] = {
> + .name = "pllc-core1",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLC, CORE1),
> + },
> + [CPRMAN_PLLC_CHANNEL_PER] = {
> + .name = "pllc-per",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLC, PER),
> + },
> + [CPRMAN_PLLC_CHANNEL_CORE0] = {
> + .name = "pllc-core0",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLC, CORE0),
> + },
> +
> + [CPRMAN_PLLD_CHANNEL_DSI0] = {
> + .name = "plld-dsi0",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLD, DSI0),
> + },
> + [CPRMAN_PLLD_CHANNEL_CORE] = {
> + .name = "plld-core",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLD, CORE),
> + },
> + [CPRMAN_PLLD_CHANNEL_PER] = {
> + .name = "plld-per",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLD, PER),
> + },
> + [CPRMAN_PLLD_CHANNEL_DSI1] = {
> + .name = "plld-dsi1",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLD, DSI1),
> + },
> +
> + [CPRMAN_PLLH_CHANNEL_AUX] = {
> + .name = "pllh-aux",
> + .fixed_divider = 1,
> + FILL_PLL_CHANNEL_INIT_INFO_nohold(PLLH, AUX),
> + },
> + [CPRMAN_PLLH_CHANNEL_RCAL] = {
> + .name = "pllh-rcal",
> + .fixed_divider = 10,
> + FILL_PLL_CHANNEL_INIT_INFO_nohold(PLLH, RCAL),
> + },
> + [CPRMAN_PLLH_CHANNEL_PIX] = {
> + .name = "pllh-pix",
> + .fixed_divider = 10,
> + FILL_PLL_CHANNEL_INIT_INFO_nohold(PLLH, PIX),
> + },
> +
> + [CPRMAN_PLLB_CHANNEL_ARM] = {
> + .name = "pllb-arm",
> + FILL_PLL_CHANNEL_INIT_INFO(PLLB, ARM),
> + },
> +};
> +
> +#undef FILL_PLL_CHANNEL_INIT_INFO_nohold
> +#undef FILL_PLL_CHANNEL_INIT_INFO
> +#undef FILL_PLL_CHANNEL_INIT_INFO_common
> +
> +static inline void set_pll_channel_init_info(BCM2835CprmanState *s,
> + CprmanPllChannelState *channel,
> + CprmanPllChannel id)
> +{
> + channel->id = id;
> + channel->parent = PLL_CHANNEL_INIT_INFO[id].parent;
> + channel->reg_cm = &s->regs[PLL_CHANNEL_INIT_INFO[id].cm_offset];
> + channel->hold_mask = PLL_CHANNEL_INIT_INFO[id].cm_hold_mask;
> + channel->load_mask = PLL_CHANNEL_INIT_INFO[id].cm_load_mask;
> + channel->reg_a2w_ctrl = &s->regs[PLL_CHANNEL_INIT_INFO[id].a2w_ctrl_offset];
> + channel->fixed_divider = PLL_CHANNEL_INIT_INFO[id].fixed_divider;
> +}
> +
> #endif
[...]
next prev parent reply other threads:[~2020-10-10 16:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 13:57 [PATCH v3 00/15] raspi: add the bcm2835 cprman clock manager Luc Michel
2020-10-10 13:57 ` [PATCH v3 01/15] hw/core/clock: provide the VMSTATE_ARRAY_CLOCK macro Luc Michel
2020-10-10 13:57 ` [PATCH v3 02/15] hw/core/clock: trace clock values in Hz instead of ns Luc Michel
2020-10-10 15:48 ` Philippe Mathieu-Daudé
2020-10-10 13:57 ` [PATCH v3 03/15] hw/core/clock: add the clock_new helper function Luc Michel
2020-10-10 15:17 ` Philippe Mathieu-Daudé
2020-10-10 15:44 ` Philippe Mathieu-Daudé
2020-10-10 13:57 ` [PATCH v3 04/15] hw/arm/raspi: fix CPRMAN base address Luc Michel
2020-10-10 13:57 ` [PATCH v3 05/15] hw/arm/raspi: add a skeleton implementation of the CPRMAN Luc Michel
2020-10-10 13:57 ` [PATCH v3 06/15] hw/misc/bcm2835_cprman: add a PLL skeleton implementation Luc Michel
2020-10-10 13:57 ` [PATCH v3 07/15] hw/misc/bcm2835_cprman: implement PLLs behaviour Luc Michel
2020-10-10 13:57 ` [PATCH v3 08/15] hw/misc/bcm2835_cprman: add a PLL channel skeleton implementation Luc Michel
2020-10-10 16:05 ` Philippe Mathieu-Daudé [this message]
2020-10-17 10:00 ` Philippe Mathieu-Daudé
2020-10-10 13:57 ` [PATCH v3 09/15] hw/misc/bcm2835_cprman: implement PLL channels behaviour Luc Michel
2020-10-10 13:57 ` [PATCH v3 10/15] hw/misc/bcm2835_cprman: add a clock mux skeleton implementation Luc Michel
2020-10-10 13:57 ` [PATCH v3 11/15] hw/misc/bcm2835_cprman: implement clock mux behaviour Luc Michel
2020-10-10 15:52 ` Philippe Mathieu-Daudé
2020-10-10 13:57 ` [PATCH v3 12/15] hw/misc/bcm2835_cprman: add the DSI0HSCK multiplexer Luc Michel
2020-10-10 13:57 ` [PATCH v3 13/15] hw/misc/bcm2835_cprman: add sane reset values to the registers Luc Michel
2020-10-10 16:18 ` Philippe Mathieu-Daudé
2020-10-11 18:26 ` Luc Michel
2020-10-16 17:10 ` Philippe Mathieu-Daudé
2020-10-19 15:44 ` Philippe Mathieu-Daudé
2020-10-10 13:57 ` [PATCH v3 14/15] hw/char/pl011: add a clock input Luc Michel
2020-10-10 13:57 ` [PATCH v3 15/15] hw/arm/bcm2835_peripherals: connect the UART clock Luc Michel
2020-10-16 17:11 ` [PATCH v3 00/15] raspi: add the bcm2835 cprman clock manager Philippe Mathieu-Daudé
2020-10-19 15:45 ` Peter Maydell
2020-10-19 19:31 ` Peter Maydell
2020-10-27 8:55 ` Philippe Mathieu-Daudé
2020-10-27 11:11 ` Peter Maydell
2020-10-22 22:06 ` Philippe Mathieu-Daudé
2020-10-22 22:48 ` Guenter Roeck
2020-10-23 3:55 ` Guenter Roeck
2020-10-23 11:13 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6e2341a-6ccc-b1cc-6e25-b3d57e1cae6d@amsat.org \
--to=f4bug@amsat.org \
--cc=Andrew.Baumann@microsoft.com \
--cc=hskinnemoen@google.com \
--cc=luc@lmichel.fr \
--cc=nieklinnenbank@gmail.com \
--cc=pauldzim@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).