From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7494CC48BE3 for ; Fri, 21 Jun 2019 13:59:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DA502083B for ; Fri, 21 Jun 2019 13:59:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DA502083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35242 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heK4x-0003eT-II for qemu-devel@archiver.kernel.org; Fri, 21 Jun 2019 09:59:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57730) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heJtJ-0000nc-JA for qemu-devel@nongnu.org; Fri, 21 Jun 2019 09:47:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1heJtI-0002n9-Hd for qemu-devel@nongnu.org; Fri, 21 Jun 2019 09:47:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46732) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1heJtI-0002kV-9q for qemu-devel@nongnu.org; Fri, 21 Jun 2019 09:47:44 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E87C330860BA for ; Fri, 21 Jun 2019 13:47:36 +0000 (UTC) Received: from [10.3.116.44] (ovpn-116-44.phx2.redhat.com [10.3.116.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78626608A7; Fri, 21 Jun 2019 13:47:36 +0000 (UTC) To: Paolo Bonzini , qemu-devel@nongnu.org References: <1561116534-21814-1-git-send-email-pbonzini@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: Date: Fri, 21 Jun 2019 08:47:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1561116534-21814-1-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LU06NHQfC4BTPVwcFFW6WE3Lp8nrsVQ4b" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 21 Jun 2019 13:47:36 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LU06NHQfC4BTPVwcFFW6WE3Lp8nrsVQ4b Content-Type: multipart/mixed; boundary="7LN33gjB5zh9ksjQyG3tVSn2ol4N1YVs7"; protected-headers="v1" From: Eric Blake To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com Message-ID: Subject: Re: [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value References: <1561116534-21814-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1561116534-21814-1-git-send-email-pbonzini@redhat.com> --7LN33gjB5zh9ksjQyG3tVSn2ol4N1YVs7 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/21/19 6:28 AM, Paolo Bonzini wrote: > While indeed we do not want to have >=20 > return (a); >=20 > it is less clear that this applies to >=20 > return (a && > b); >=20 > Some editors indent more nicely if you have parentheses, and some peopl= e's > eyes may appreciate that as well. >=20 > Signed-off-by: Paolo Bonzini > --- > scripts/checkpatch.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) I'm certainly in favor of this (as I've been known to use this style). >=20 > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index c2aaf42..2f81371 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2296,7 +2296,8 @@ sub process { > $value =3D~ s/\([^\(\)]*\)/1/) { > } > #print "value<$value>\n"; > - if ($value =3D~ /^\s*(?:$Ident|-?$Constant)\s*$/) { > + if ($value =3D~ /^\s*(?:$Ident|-?$Constant)\s*$/ && > + $line =3D~ /;$/) { So the diagnosis now checks for a trailing ';' as its witness of whether this is a one-liner return statement, leaving multi-liners undiagnosed. Easy enough to understand. Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --7LN33gjB5zh9ksjQyG3tVSn2ol4N1YVs7-- --LU06NHQfC4BTPVwcFFW6WE3Lp8nrsVQ4b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl0M3/cACgkQp6FrSiUn Q2paUQgAkE1fn+YcDjeSOiypgsUQYMC7goFc8k0XWGEwVY07JOAJkRgk/mtVRYn7 Q32UbO98DUTz6Uk4d8yrvyhvWPgMBsR+3iHGrm/FHlqqFg9uESFV0OSYhsQc0mNC QNeaMuLL0ObG3MMItU9PCcQ8jcGBGCHAN4Wf1t4jGk0N6VfW2sS97cXPJp6zb66+ bHded7bBa/HFmSA2GN/GefGNPp8HNPu1upgTrzithGL5Z43od1o9yT7pwYVvPYG2 Wvx/Cyq8Rl55EQnb0td7JCDe+kxbtjtTf2RhhDTiBwZIKszYXWwkTKnfZsb5DN2W PO1rlrMAEYCCDm0erHQzQfNYsKOaMg== =1vn2 -----END PGP SIGNATURE----- --LU06NHQfC4BTPVwcFFW6WE3Lp8nrsVQ4b--