From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E23FCC433FE for ; Sat, 23 Oct 2021 10:14:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CCFA60FC4 for ; Sat, 23 Oct 2021 10:14:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4CCFA60FC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:41138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1meE2m-0002Mx-F1 for qemu-devel@archiver.kernel.org; Sat, 23 Oct 2021 06:14:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1meE14-0000rU-DP; Sat, 23 Oct 2021 06:12:42 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:56959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1meE10-0000n3-U5; Sat, 23 Oct 2021 06:12:41 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 5B5E77475FA; Sat, 23 Oct 2021 12:12:34 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 1E9F1746333; Sat, 23 Oct 2021 12:12:34 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 19BD77462D3; Sat, 23 Oct 2021 12:12:34 +0200 (CEST) Date: Sat, 23 Oct 2021 12:12:34 +0200 (CEST) From: BALATON Zoltan To: Richard Henderson Subject: Re: [PATCH 15/33] target/ppc: Implement Vector Insert from GPR using GPR index insns In-Reply-To: <0581a10f-1411-a174-5869-4fe0999132f3@linaro.org> Message-ID: References: <20211021194547.672988-1-matheus.ferst@eldorado.org.br> <20211021194547.672988-16-matheus.ferst@eldorado.org.br> <0581a10f-1411-a174-5869-4fe0999132f3@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lucas.castro@eldorado.org.br, qemu-devel@nongnu.org, groug@kaod.org, luis.pires@eldorado.org.br, qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 22 Oct 2021, Richard Henderson wrote: > On 10/21/21 12:45 PM, matheus.ferst@eldorado.org.br wrote: >> +#if defined(TARGET_PPC64) >> + return do_vinsx(ctx, a->vrt, size, right, cpu_gpr[a->vra], >> cpu_gpr[a->vrb], >> + gen_helper); >> +#else >> + bool ok; >> + TCGv_i64 val; >> + >> + val = tcg_temp_new_i64(); >> + tcg_gen_extu_tl_i64(val, cpu_gpr[a->vrb]); >> + >> + ok = do_vinsx(ctx, a->vrt, size, right, cpu_gpr[a->vra], val, >> gen_helper); >> + >> + tcg_temp_free_i64(val); >> + return ok; >> +#endif > > Oh, and what's all this? > > Either this isn't defined for !PPC64 at all, or you should just use > target_ulong and not do any ifdeffing at all. You mentioning target_ulong reminded me a question I had. Currently we have qemu-system-ppc and qemu-system-ppc64 but the latter includes all machines of the former too so you could run for example sam460ex with qemu-system-ppc64 (except mac99 which behaves differently based on which executable it's part of but you could use mac99 -cpu G4 with qemu-system-ppc64 as well). But isn't target_ulong different in these executables and could that cause a problem with this? I've always used qemu-system-ppc for 32 bit machines but we could have one just executable for all machines if there's no need for both. Regards, BALATON Zoltan