qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: jasowang@redhat.com
Subject: Re: [PATCH] netdev: add more commands to preconfig mode
Date: Mon, 7 Jun 2021 16:15:56 +0200	[thread overview]
Message-ID: <e8631e93-920b-00f2-a5f5-6d4ce854474f@redhat.com> (raw)
In-Reply-To: <20210511153955.506577-1-pbonzini@redhat.com>

On 11/05/21 17:39, Paolo Bonzini wrote:
> Creating and destroying network backend does not require a fully
> constructed machine.  Allow the related monitor commands to run before
> machine initialization has concluded.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   hmp-commands.hx | 2 ++
>   qapi/net.json   | 6 ++++--
>   2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 901a50ebd1..1768bc5df0 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1276,6 +1276,7 @@ ERST
>           .help       = "add host network device",
>           .cmd        = hmp_netdev_add,
>           .command_completion = netdev_add_completion,
> +        .flags      = "p",
>       },
>   
>   SRST
> @@ -1290,6 +1291,7 @@ ERST
>           .help       = "remove host network device",
>           .cmd        = hmp_netdev_del,
>           .command_completion = netdev_del_completion,
> +        .flags      = "p",
>       },
>   
>   SRST
> diff --git a/qapi/net.json b/qapi/net.json
> index af3f5b0fda..7fab2e7cd8 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -55,7 +55,8 @@
>   # <- { "return": {} }
>   #
>   ##
> -{ 'command': 'netdev_add', 'data': 'Netdev', 'boxed': true }
> +{ 'command': 'netdev_add', 'data': 'Netdev', 'boxed': true,
> +  'allow-preconfig': true }
>   
>   ##
>   # @netdev_del:
> @@ -75,7 +76,8 @@
>   # <- { "return": {} }
>   #
>   ##
> -{ 'command': 'netdev_del', 'data': {'id': 'str'} }
> +{ 'command': 'netdev_del', 'data': {'id': 'str'},
> +  'allow-preconfig': true }
>   
>   ##
>   # @NetLegacyNicOptions:
> 

Ping.


  reply	other threads:[~2021-06-07 14:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 15:39 [PATCH] netdev: add more commands to preconfig mode Paolo Bonzini
2021-06-07 14:15 ` Paolo Bonzini [this message]
2021-06-07 14:22 ` Daniel P. Berrangé
2021-06-08  2:40   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8631e93-920b-00f2-a5f5-6d4ce854474f@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).