From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE418C433FF for ; Tue, 13 Aug 2019 15:25:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C158820663 for ; Tue, 13 Aug 2019 15:25:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C158820663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxYgJ-0004v1-1W for qemu-devel@archiver.kernel.org; Tue, 13 Aug 2019 11:25:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48718) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxYf2-0003X1-JV for qemu-devel@nongnu.org; Tue, 13 Aug 2019 11:24:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxYf1-0002l5-Ja for qemu-devel@nongnu.org; Tue, 13 Aug 2019 11:24:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55076) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxYez-0002ik-F7; Tue, 13 Aug 2019 11:24:29 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C6E173082124; Tue, 13 Aug 2019 15:24:28 +0000 (UTC) Received: from [10.3.117.22] (ovpn-117-22.phx2.redhat.com [10.3.117.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 00C3D60BE2; Tue, 13 Aug 2019 15:24:18 +0000 (UTC) To: Thomas Huth , qemu-devel@nongnu.org References: <20190813093047.27948-1-thuth@redhat.com> <20190813093047.27948-7-thuth@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: Date: Tue, 13 Aug 2019 10:24:18 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190813093047.27948-7-thuth@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="32vNRb46TPxswzgCpSOQ6UfgYVGf4YQel" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 13 Aug 2019 15:24:28 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 6/6] tests/libqtest: Make qmp_assert_success() independent from global_qtest X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Laurent Vivier , qemu-block@nongnu.org, Amit Shah , Jason Wang , "Dr. David Alan Gilbert" , Markus Armbruster , Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --32vNRb46TPxswzgCpSOQ6UfgYVGf4YQel Content-Type: multipart/mixed; boundary="m1g8zUhtyp8tpkdwKjizTAqKicNqKn0xB"; protected-headers="v1" From: Eric Blake To: Thomas Huth , qemu-devel@nongnu.org Cc: Paolo Bonzini , Fam Zheng , qemu-block@nongnu.org, "Dr. David Alan Gilbert" , Jason Wang , Laurent Vivier , John Snow , Markus Armbruster , Amit Shah , Stefan Hajnoczi , Gerd Hoffmann , Greg Kurz Message-ID: Subject: Re: [PATCH 6/6] tests/libqtest: Make qmp_assert_success() independent from global_qtest References: <20190813093047.27948-1-thuth@redhat.com> <20190813093047.27948-7-thuth@redhat.com> In-Reply-To: <20190813093047.27948-7-thuth@redhat.com> --m1g8zUhtyp8tpkdwKjizTAqKicNqKn0xB Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/13/19 4:30 AM, Thomas Huth wrote: > The normal libqtest library functions should never depend on global_qte= st. > Pass in the test state via parameter instead. And while we're at it, > also rename this function to qtest_qmp_assert_success() to make it clea= r > that it is part of libqtest. >=20 > Signed-off-by: Thomas Huth > --- > tests/libqtest.c | 4 ++-- > tests/libqtest.h | 6 ++++-- > tests/virtio-scsi-test.c | 3 ++- > 3 files changed, 8 insertions(+), 5 deletions(-) >=20 > +++ b/tests/virtio-scsi-test.c > @@ -225,7 +225,8 @@ static void test_iothread_attach_node(void *obj, vo= id *data, > mkqcow2(tmp_path, 64); > =20 > /* Attach the overlay to the null0 node */ > - qmp_assert_success("{'execute': 'blockdev-add', 'arguments': {" > + qtest_qmp_assert_success(scsi_pci->pci_vdev.pdev->bus->qts, > + "{'execute': 'blockdev-add', 'arguments': {" > " 'driver': 'qcow2', 'node-name': 'overlay',"= > " 'backing': 'null0', 'file': {" > " 'driver': 'file', 'filename': %s}}}", tmp= _path); >=20 Indentation is now off. Minor, so: Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --m1g8zUhtyp8tpkdwKjizTAqKicNqKn0xB-- --32vNRb46TPxswzgCpSOQ6UfgYVGf4YQel Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl1S1iIACgkQp6FrSiUn Q2pCzwf+Oy9x5EvBIyS36ml9PQ/EOFv4oE6UOc/9rkOOTK6DOEOHH+PVkr1dd+0r bVLP+u2QVPTFCxm2jB4Fjo/fm7cyVsRLfFx9WMRfHSTczcJDsjSpMq+JNJg/uucq zffDniWmZIDR+My6S28ry2cDKQ5wG7tUYg2wfb00Vj4pOb2OlfVX1WcMyyMaPegU aPRVEaNx0tv4qYYsoTClt8THt+Ys3wXb8sHg9I8OwjI3/mQbi0KENyx7EQg6p3Cx m/Elppk8vpRy0BgSMAtyV4Wb2AiBOG1NFmXqC05GzRD1XRR09KOlvQGtzmXSuOIj mi9FmM5ini+xqhBoGdoLiW6FpjcB/A== =otrr -----END PGP SIGNATURE----- --32vNRb46TPxswzgCpSOQ6UfgYVGf4YQel--