From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77154C433ED for ; Wed, 7 Apr 2021 16:51:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4A656103D for ; Wed, 7 Apr 2021 16:51:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4A656103D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUBPI-0001s4-UR for qemu-devel@archiver.kernel.org; Wed, 07 Apr 2021 12:51:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUBMo-0000ER-Fk for qemu-devel@nongnu.org; Wed, 07 Apr 2021 12:49:22 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:35599) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUBMl-0004vr-K5 for qemu-devel@nongnu.org; Wed, 07 Apr 2021 12:49:22 -0400 Received: from [192.168.100.1] ([82.142.14.126]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MlO9r-1lqqbm3XTx-00lnx9; Wed, 07 Apr 2021 18:49:15 +0200 Subject: Re: [PATCH] linux-user: Use signed lengths in uaccess.c To: Peter Maydell References: <20210315204004.2025219-1-richard.henderson@linaro.org> From: Laurent Vivier Message-ID: Date: Wed, 7 Apr 2021 18:49:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:vhNL0ZXc1fLWNInXyj8lbQJzQazf0o6UFxE/oQ5rVeKexfMjHbt jZRRsUJHH1S8Vs0gDiG4i7pHEPFjLYJaHvd70sZwEx0IRZFTIFoYAlPt0usxw0suwhHtgwI /hoMaZAYyAGtVgU8T7Il0Z2cjEuUneadqSdfo3V4V2w4xoEpm8LNy2QVCUNTU/7BqupcxI4 8fLg0SDhkDibo+pTQhNWA== X-UI-Out-Filterresults: notjunk:1;V03:K0:cXAgK+GtRtU=:rqz9irzORyTbvkUs1YILvS 6aAMQEzO4mxrwZ5Hpg+wlafLcLEenLYMcEaJ/arL06mXt0j/uOtkpCzJwyWq1bMpkcKajbXjS Gf72l/1fSFJ9mUhoCrBx1uxZJC+7naOZQ/Hs87HeYFKLYuQQ/YyVsAYJgrsMNfM/S3Ynbet9y cQXw7MSIY50P5e6j5erZxURGPKOQl4NiesqXrJh6XfiuQtvAUG0afekpD/oLpKSPnNHIgVq2J +DutETsoV4MUmF/xC766AzVYOacE1oyruussSI94z/AQvzXKA4aUm8gjfp6LD22rDVOlq/7j6 SqOzyMH7jnrCklXeqdFmmYM4he/Kgj7roEgFyclz9PN8aH2vgLgxdSpyB1XjbY67/luIEolkF bBcTAsfOKqwZCxKrbpmRDBDyrZBlXnB1yG945DgFILf4DImRBIwijNRMxy2KtvU8LN08xvkyP qJVrTQlODHiQaK+CuZfGmHEWPseKsVpeIA+WtK075UBme3ttrYcj Received-SPF: none client-ip=217.72.192.75; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 07/04/2021 à 17:16, Peter Maydell a écrit : > On Mon, 15 Mar 2021 at 21:07, Laurent Vivier wrote: >> >> Le 15/03/2021 à 21:40, Richard Henderson a écrit : >>> Partially revert 09f679b62dff, but only for the length arguments. >>> Instead of reverting to long, use ssize_t. Reinstate the > 0 check >>> in unlock_user. >>> >>> Fixes: 09f679b62dff >>> Reported-by: Coverity (CID 1446711) >>> Signed-off-by: Richard Henderson > >> Reviewed-by: Laurent Vivier > > Hi -- did this patch get lost? I think we should put it into 6.0. It seems so... thank you. I prepare a PR with it. Laurent