From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B5EEC433ED for ; Tue, 6 Apr 2021 19:37:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DFE6613CF for ; Tue, 6 Apr 2021 19:37:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DFE6613CF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTrVr-00010V-D7 for qemu-devel@archiver.kernel.org; Tue, 06 Apr 2021 15:37:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTrUv-0000SM-DW; Tue, 06 Apr 2021 15:36:25 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:36535) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTrUs-0003vF-JB; Tue, 06 Apr 2021 15:36:25 -0400 Received: from [192.168.100.1] ([82.142.14.126]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MGhds-1lPxjd1Wa2-00DqfF; Tue, 06 Apr 2021 21:36:19 +0200 Subject: Re: [PATCH v4 12/12] exec: Fix overlap of PAGE_ANON and PAGE_TARGET_1 To: Richard Henderson , qemu-devel@nongnu.org References: <20210406174031.64299-1-richard.henderson@linaro.org> <20210406174031.64299-13-richard.henderson@linaro.org> From: Laurent Vivier Message-ID: Date: Tue, 6 Apr 2021 21:36:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210406174031.64299-13-richard.henderson@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:kJQ0SBbJFlOqp3o7w8Fqf4Sql1sLEIMFyfNMyIuTUB0XevRzpDy BwJxLtkn6XfH3C3078OdSe6gzbt7B5cRy18Yd5z1jNh4sFtbzQDW3BlYdutSeuSdh+WwjJK rMjYP8rOjeDz59nrBNqrPGYbng54VNkW7bmQdxjRpphbws7hYOZpqhzGhFXG8QroIeEAIh9 eR4WDWzi9KxA1tLw2flUg== X-UI-Out-Filterresults: notjunk:1;V03:K0:JUygBdQN6J0=:dUfaEpqWnWAjY6lFdnzzJ1 V1GwwVyc0N6+fFCT+yFp3VeoI9reFbYJApFVR2Nh9wJiM+cDXjAZ89a5XsjlQzAJJVhqWuFjQ aOM9KcG6o2SXhTI9Tth9kvBr1f6slhpsrEU8kTuAo7LkOsERwZyATigoW4Hu9Ffg7mG8AQlc/ aoZOzEAzQB8MvyNgCaXqHDwtnATJrviFIoOSwt2z/ow0bNM5PSkF9GS/jUYUqkfZMkRyM8dXQ SSL6krBqL/6mVTCSOWWUTKa5vJGO2lokbepb6eRtPrrOiCwB3qCU72XwrGPeKI5t4RvpmlMAT or2JflC1eG1VuQg2nf/PY9CI/pBgos7GJKTrxDhHzAGiAC/h539P+8cJbZYWm4skfvyNf5z/3 adiTB6mvDJ05AmgmEujcib1ZOlgMsylNPHggxt8PXgH+ZWeT1X85maaATgusNqUMXWge6v879 NGUORIapuik6/OziZ5MTuME+gfsUni2NiQ2AC8LaZgDN05vy/mUZ Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 06/04/2021 à 19:40, Richard Henderson a écrit : > Unfortuately, the elements of PAGE_* were not in numerical > order and so PAGE_ANON was added to an "unused" bit. > As an arbitrary choice, move PAGE_TARGET_{1,2} together. > > Cc: Laurent Vivier > Fixes: 26bab757d41b ("linux-user: Introduce PAGE_ANON") > Buglink: https://bugs.launchpad.net/bugs/1922617 > Signed-off-by: Richard Henderson > --- > include/exec/cpu-all.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h > index d76b0b9e02..32cfb634c6 100644 > --- a/include/exec/cpu-all.h > +++ b/include/exec/cpu-all.h > @@ -268,8 +268,8 @@ extern intptr_t qemu_host_page_mask; > #define PAGE_RESERVED 0x0100 > #endif > /* Target-specific bits that will be used via page_get_flags(). */ > -#define PAGE_TARGET_1 0x0080 > -#define PAGE_TARGET_2 0x0200 > +#define PAGE_TARGET_1 0x0200 > +#define PAGE_TARGET_2 0x0400 > > #if defined(CONFIG_USER_ONLY) > void page_dump(FILE *f); > Tested-by: Laurent Vivier