From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CDCFC433ED for ; Tue, 11 May 2021 11:29:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B48AD6186A for ; Tue, 11 May 2021 11:29:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B48AD6186A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgQa4-00049P-JR for qemu-devel@archiver.kernel.org; Tue, 11 May 2021 07:29:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgQZ2-0003FZ-AF; Tue, 11 May 2021 07:28:36 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:59159) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgQYy-0004Hc-GU; Tue, 11 May 2021 07:28:35 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 7529D74570D; Tue, 11 May 2021 13:28:27 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 50186745709; Tue, 11 May 2021 13:28:27 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 4E7897456E3; Tue, 11 May 2021 13:28:27 +0200 (CEST) Date: Tue, 11 May 2021 13:28:27 +0200 (CEST) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [PATCH v2 0/6] hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE In-Reply-To: <20210511041848.2743312-1-f4bug@amsat.org> Message-ID: References: <20210511041848.2743312-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-51727942-1620732507=:99606" Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , qemu-block@nongnu.org, Huacai Chen , qemu-devel@nongnu.org, John Snow , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-51727942-1620732507=:99606 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: > The motivation behind this series is to remove the > isa_get_irq(NULL) call to simplify the ISA generic model. > > Since v1: > - rebased on top of remotes/dg-gitlab/tags/ppc-for-6.1-20210504 I'll try to have a look at these later but some notes: The pegasos2 changes are now in master so if this was before that maybe rebasing on master is now enough. However I wonder if any changes to pegasos2.c is needed due to changed init of the chip model or is that only affecting 82c686b? Please also note that pegasos2 is not enabled by default due to needing undistributable firmware ROM so to test it you need to enable it in default-configs/devices/ppc-softmmu.mak Regards, BALATON Zoltan > Philippe Mathieu-Daudé (6): > hw/isa/vt82c686: Name output IRQ as 'intr' > hw/isa/vt82c686: Simplify removing unuseful qemu_allocate_irqs() call > hw/isa/vt82c686: Let ISA function expose ISA IRQs > hw/ide/via: Replace magic 2 value by ARRAY_SIZE / MAX_IDE_DEVS > hw/ide/via: Connect IDE function output IRQs to the ISA function input > hw/southbridge/vt82c686: Introduce VT82C686B_SOUTHBRIDGE > > hw/ide/via.c | 31 ++++++++--- > hw/isa/vt82c686.c | 27 +++++----- > hw/mips/fuloong2e.c | 35 +++--------- > hw/southbridge/vt82c686.c | 107 +++++++++++++++++++++++++++++++++++++ > MAINTAINERS | 1 + > hw/Kconfig | 1 + > hw/isa/Kconfig | 9 ---- > hw/meson.build | 1 + > hw/southbridge/Kconfig | 8 +++ > hw/southbridge/meson.build | 1 + > 10 files changed, 164 insertions(+), 57 deletions(-) > create mode 100644 hw/southbridge/vt82c686.c > create mode 100644 hw/southbridge/Kconfig > create mode 100644 hw/southbridge/meson.build > > -- > 2.26.3 > > > --3866299591-51727942-1620732507=:99606--