From: "Cédric Le Goater" <clg@kaod.org>
To: Nicholas Piggin <npiggin@gmail.com>, qemu-ppc@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, Greg Kurz <groug@kaod.org>,
Ganesh Goudar <ganeshgr@linux.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 0/5] ppc: sreset and machine check injection
Date: Wed, 25 Mar 2020 17:42:33 +0100 [thread overview]
Message-ID: <eceb0a5e-6aba-2b39-898e-d55a2cc5914a@kaod.org> (raw)
In-Reply-To: <20200325144147.221875-1-npiggin@gmail.com>
On 3/25/20 3:41 PM, Nicholas Piggin wrote:
> This adds nmi injection for pnv, and similar mce injection for
> spapr and pnv. The mce injection has already uncovered quite a
> few bugs in Linux papr guest and one in pnv host code, so it
> has been already very useful.
Nice !
> The mambo simulator can do similar
> injection but it's a bit more clunky and needs to run KVM and
> QEMU in the sim to test papr guests, which is quite slow.
You can run a KVM guest under the QEMU powernv machine. You will
need a patch from Suraj adding radix support for guests, which is
still in my powernv-5.0 branch.
> HMIs like timebase corruption would be another good candidate
> for error injection.
XSCOM errors also.
Thanks,
C.
> Thanks,
> Nick
>
> Nicholas Piggin (5):
> ppc/spapr: tweak change system reset helper
> ppc/pnv: Add support for NMI interface
> nmi: add MCE class for implementing machine check injection commands
> ppc/spapr: Implement mce injection
> ppc/pnv: Implement mce injection
>
> hmp-commands.hx | 20 ++++++++-
> hw/core/nmi.c | 61 ++++++++++++++++++++++++++
> hw/ppc/pnv.c | 85 +++++++++++++++++++++++++++++++++++-
> hw/ppc/spapr.c | 63 ++++++++++++++++++++++++--
> include/hw/nmi.h | 20 +++++++++
> include/hw/ppc/spapr.h | 3 ++
> include/monitor/hmp-target.h | 1 -
> include/monitor/hmp.h | 1 +
> monitor/hmp-cmds.c | 1 +
> target/ppc/cpu.h | 3 +-
> target/ppc/excp_helper.c | 17 ++++++--
> target/ppc/monitor.c | 11 +++++
> 12 files changed, 275 insertions(+), 11 deletions(-)
>
prev parent reply other threads:[~2020-03-25 16:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 14:41 [PATCH 0/5] ppc: sreset and machine check injection Nicholas Piggin
2020-03-25 14:41 ` [PATCH 1/5] ppc/spapr: tweak change system reset helper Nicholas Piggin
2020-03-25 16:14 ` [EXTERNAL] " Cédric Le Goater
2020-03-26 0:04 ` David Gibson
2020-03-25 14:41 ` [PATCH 2/5] ppc/pnv: Add support for NMI interface Nicholas Piggin
2020-03-25 16:38 ` Cédric Le Goater
2020-04-03 7:57 ` Nicholas Piggin
2020-04-03 13:12 ` Nicholas Piggin
2020-04-03 15:47 ` Cédric Le Goater
2020-04-04 1:58 ` Nicholas Piggin
2020-03-26 0:15 ` David Gibson
2020-03-31 3:07 ` Alexey Kardashevskiy
2020-03-31 3:14 ` David Gibson
2020-03-25 14:41 ` [PATCH 3/5] nmi: add MCE class for implementing machine check injection commands Nicholas Piggin
2020-03-25 16:46 ` Cédric Le Goater
2020-03-31 0:22 ` David Gibson
2020-04-03 8:04 ` Nicholas Piggin
2020-04-06 6:45 ` David Gibson
2020-03-25 14:41 ` [PATCH 4/5] ppc/spapr: Implement mce injection Nicholas Piggin
2020-03-25 16:38 ` Cédric Le Goater
2020-03-25 14:41 ` [PATCH 5/5] ppc/pnv: " Nicholas Piggin
2020-03-25 16:39 ` [EXTERNAL] " Cédric Le Goater
2020-04-03 8:07 ` Nicholas Piggin
2020-03-25 16:42 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eceb0a5e-6aba-2b39-898e-d55a2cc5914a@kaod.org \
--to=clg@kaod.org \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=ganeshgr@linux.ibm.com \
--cc=groug@kaod.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).