qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Tarun Gupta (SW-GPU)" <targupta@nvidia.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: kevin.tian@intel.com, cjia@nvidia.com, quintela@redhat.com,
	alex.williamson@redhat.com, qemu-devel@nongnu.org,
	yan.y.zhao@intel.com, lushenming@huawei.com,
	kwankhede@nvidia.com, dnigam@nvidia.com, berrange@redhat.com,
	philmd@redhat.com, dgilbert@redhat.com
Subject: Re: [PATCH v3 1/1] docs/devel: Add VFIO device migration documentation
Date: Wed, 7 Apr 2021 17:03:00 +0530	[thread overview]
Message-ID: <eceb9c5b-20f5-2d54-20dd-ef32e95c420b@nvidia.com> (raw)
In-Reply-To: <20210407122348.134c7b69.cohuck@redhat.com>



On 4/7/2021 3:53 PM, Cornelia Huck wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Mon, 5 Apr 2021 22:32:47 +0530
> "Tarun Gupta (SW-GPU)" <targupta@nvidia.com> wrote:
> 
>> On 4/1/2021 4:35 PM, Cornelia Huck wrote:
>>>
>>> On Fri, 26 Mar 2021 18:48:50 +0530
>>> Tarun Gupta <targupta@nvidia.com> wrote:
> 
>>>> +
>>>> +Similarly, a migration state change notifier is registered to get a
>>>> +notification on migration state change. These states are translated to the
>>>> +corresponding VFIO device state and conveyed to the vendor driver.
>>>
>>> "Similarly, a migration state change handler is used to transition the
>>> VFIO device state back to _RUNNING in case a migration failed or was
>>> canceled."
>>
>> I wanted to keep the statement generic because the VFIO device state can
>> be _RUNNING, _SAVING, _RESUMING. I can use your statement as an example
>> as to how the migration state can be changed back to _RUNNING in case of
>> migration failure or cancel. Does that work?
> 
> So, maybe:
> 
> "Similarly, a migration state change handler is used to trigger a
> transition of the VFIO device state when certain changes of the
> migration state occur. For example, the VFIO device state is
> transitioned back to _RUNNING in case a migration failed or was
> canceled."
> 

Yes, this looks fine to me. I'll update this in v4.

Thanks,
Tarun


      reply	other threads:[~2021-04-07 11:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 13:18 Tarun Gupta
2021-03-27  6:04 ` Shenming Lu
2021-04-01  6:58   ` Tarun Gupta (SW-GPU)
2021-04-01 11:05 ` Cornelia Huck
2021-04-05 17:02   ` Tarun Gupta (SW-GPU)
2021-04-07 10:23     ` Cornelia Huck
2021-04-07 11:33       ` Tarun Gupta (SW-GPU) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eceb9c5b-20f5-2d54-20dd-ef32e95c420b@nvidia.com \
    --to=targupta@nvidia.com \
    --cc=alex.williamson@redhat.com \
    --cc=berrange@redhat.com \
    --cc=cjia@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=dnigam@nvidia.com \
    --cc=kevin.tian@intel.com \
    --cc=kwankhede@nvidia.com \
    --cc=lushenming@huawei.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=yan.y.zhao@intel.com \
    --subject='Re: [PATCH v3 1/1] docs/devel: Add VFIO device migration documentation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).