Re: [PATCH v3 1/1] docs/devel: Add VFIO device migration documentation

["Tarun Gupta (SW-GPU)" <targupta@nvidia.com>]

On 4/7/2021 3:53 PM, Cornelia Huck wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Mon, 5 Apr 2021 22:32:47 +0530
> "Tarun Gupta (SW-GPU)" <targupta@nvidia.com> wrote:
> 
>> On 4/1/2021 4:35 PM, Cornelia Huck wrote:
>>>
>>> On Fri, 26 Mar 2021 18:48:50 +0530
>>> Tarun Gupta <targupta@nvidia.com> wrote:
> 
>>>> +
>>>> +Similarly, a migration state change notifier is registered to get a
>>>> +notification on migration state change. These states are translated to the
>>>> +corresponding VFIO device state and conveyed to the vendor driver.
>>>
>>> "Similarly, a migration state change handler is used to transition the
>>> VFIO device state back to _RUNNING in case a migration failed or was
>>> canceled."
>>
>> I wanted to keep the statement generic because the VFIO device state can
>> be _RUNNING, _SAVING, _RESUMING. I can use your statement as an example
>> as to how the migration state can be changed back to _RUNNING in case of
>> migration failure or cancel. Does that work?
> 
> So, maybe:
> 
> "Similarly, a migration state change handler is used to trigger a
> transition of the VFIO device state when certain changes of the
> migration state occur. For example, the VFIO device state is
> transitioned back to _RUNNING in case a migration failed or was
> canceled."
> 

Yes, this looks fine to me. I'll update this in v4.

Thanks,
Tarun