From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D34FC32750 for ; Tue, 13 Aug 2019 17:40:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 045E720840 for ; Tue, 13 Aug 2019 17:40:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 045E720840 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxamU-0005Uv-C1 for qemu-devel@archiver.kernel.org; Tue, 13 Aug 2019 13:40:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37979) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxalK-000459-0m for qemu-devel@nongnu.org; Tue, 13 Aug 2019 13:39:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxalJ-0006Cf-5H for qemu-devel@nongnu.org; Tue, 13 Aug 2019 13:39:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55134) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxalH-0006B7-0C; Tue, 13 Aug 2019 13:39:07 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 407043002F44; Tue, 13 Aug 2019 17:39:06 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-63.ams2.redhat.com [10.36.116.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id EEC95277A8; Tue, 13 Aug 2019 17:38:55 +0000 (UTC) To: Eric Blake , qemu-devel@nongnu.org References: <20190813093047.27948-1-thuth@redhat.com> <20190813093047.27948-4-thuth@redhat.com> <5b373fbe-6dbc-7a2a-a981-091fa8648ac2@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; prefer-encrypt=mutual; keydata= mQINBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABtB5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT6JAjgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDuQIN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABiQIfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn Organization: Red Hat Message-ID: Date: Tue, 13 Aug 2019 19:38:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <5b373fbe-6dbc-7a2a-a981-091fa8648ac2@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZiWmcuq7UeuYCx8tZOKHCgeNzii0OJQc7" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 13 Aug 2019 17:39:06 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Laurent Vivier , qemu-block@nongnu.org, Amit Shah , Jason Wang , "Dr. David Alan Gilbert" , Markus Armbruster , Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ZiWmcuq7UeuYCx8tZOKHCgeNzii0OJQc7 Content-Type: multipart/mixed; boundary="IqRSwRncyodGHEnb4JwpWYiZ21bYnj7lb"; protected-headers="v1" From: Thomas Huth To: Eric Blake , qemu-devel@nongnu.org Cc: Fam Zheng , Laurent Vivier , qemu-block@nongnu.org, Amit Shah , Jason Wang , "Dr. David Alan Gilbert" , Markus Armbruster , Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini , John Snow Message-ID: Subject: Re: [PATCH 3/6] tests/libqtest: Remove unused function hmp() References: <20190813093047.27948-1-thuth@redhat.com> <20190813093047.27948-4-thuth@redhat.com> <5b373fbe-6dbc-7a2a-a981-091fa8648ac2@redhat.com> In-Reply-To: <5b373fbe-6dbc-7a2a-a981-091fa8648ac2@redhat.com> --IqRSwRncyodGHEnb4JwpWYiZ21bYnj7lb Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/13/19 5:20 PM, Eric Blake wrote: > On 8/13/19 4:30 AM, Thomas Huth wrote: >> No test is using hmp() anymore, and since this function uses the disli= ked >> global_qtest variable, we should also make sure that nobody adds new c= ode >> with this function again. qtest_hmp() should be used instead. >> >> Signed-off-by: Thomas Huth >> --- >> tests/libqtest.c | 11 ----------- >> tests/libqtest.h | 10 ---------- >> 2 files changed, 21 deletions(-) >=20 > Yay. >=20 > We could, at a later time, introduce a patch to do s/qtest_hmp/hmp/ if > it was deemed worthwhile, but I'm not sure it's worth the churn. Actually, I like the qtest_* prefix for the libqtest functions - so it is clear at the first sight that a function is part of libqtest or rather the test itself. > Reviewed-by: Eric Blake Thanks a lot! Thomas --IqRSwRncyodGHEnb4JwpWYiZ21bYnj7lb-- --ZiWmcuq7UeuYCx8tZOKHCgeNzii0OJQc7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJ7iIR+7gJQEY8+q5LtnXdP5wLbUFAl1S9a4ACgkQLtnXdP5w LbXPfhAAkN497KyzGylnE2eveqGea5Y5arI424qfPtCiMUFPik5Isig12ZwxODwV HCMSHKoth0IIKcnPUmm+nxjciy9V//ZTD7DiaxnT2jXJ2dB1eBOn5aK/LsqEw7tW yiAJyLd3l/xHU6SvjqEltK/E/N6j0dkTHxtOSsbBg5N5/2VN9BAad+wmMRfK8edZ yf/ibhVK+VlNbGtPIBwgVRQ9AEoB6MlCuIt/4AAlptQjx8uLOuko9FdOlh9kZ00r cUrztDEgpV6FEukeo27LpjZ1ChKpKhg+l0oh34efQ8gr1h/iO+h+/fbfZgnPYnr/ 3zdael6nHQVHEbaZkvEunfoF3pRFlp6s6U2eNwoLMJtUPe681lVNnGLvv/3ZRIqP bei8Uh6KWTUxTwsUGiODDvRvRxoSzZ1jFEeYTn6TjpQX/owLGof2Nl0CaBN3PNyH IU9ICOvUxQruEjvb/rb9UW9YzdWEjMsNzVtmPHBFZI/VsZTM6U2+EAxKgDVfh22a GeSl+NgafHuZIl0HDLPQ8Th6LlpRTqmLwZTmL1aLGp7laumwMvpEMTVG2RTwST7c jsLsVXu7Y2Gn3Mi2baN4zQ/hS1FuYSu2Rs/7zO5SPrIp6JnIPaMRaIhgGgKkFJ7H Up4SVe4lxGnyxFrD4xXFLf8hhfYnzczyEOSIKDTMjyBj3RZmHf0= =Z6dr -----END PGP SIGNATURE----- --ZiWmcuq7UeuYCx8tZOKHCgeNzii0OJQc7--