From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, thuth@redhat.com, richard.henderson@linaro.org
Subject: Re: [PATCH 0/2] More qemu_strtosz fixes
Date: Wed, 17 Mar 2021 10:28:27 -0500 [thread overview]
Message-ID: <ed8fbb82-09f5-bdcf-9a69-6b3351b9cc25@redhat.com> (raw)
In-Reply-To: <161599414593.29996.8944585512631660040@c9d4d6fbb2f1>
On 3/17/21 10:15 AM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20210317143325.2165821-1-eblake@redhat.com/
>
> === OUTPUT BEGIN ===
> 1/2 Checking commit 81af63e53841 (utils: Tighter tests for qemu_strtosz)
> 2/2 Checking commit 36c9a8f42010 (utils: Work around mingw strto*l bug with 0x)
> ERROR: consider using qemu_strtol in preference to strtol
> #141: FILE: util/cutils.c:409:
> + if (strtol(nptr, &tmp, 10) == 0 && errno == 0 &&
>
> total: 1 errors, 0 warnings, 169 lines checked
>
Intentional. This code is part of the implementation of qemu_strtol, and
we don't want infinite recursion ;)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-03-17 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 14:33 [PATCH 0/2] More qemu_strtosz fixes Eric Blake
2021-03-17 14:33 ` [PATCH 1/2] utils: Tighter tests for qemu_strtosz Eric Blake
2021-03-17 14:59 ` Thomas Huth
2021-03-17 14:33 ` [PATCH 2/2] utils: Work around mingw strto*l bug with 0x Eric Blake
2021-03-18 5:07 ` Thomas Huth
2021-03-17 15:15 ` [PATCH 0/2] More qemu_strtosz fixes no-reply
2021-03-17 15:28 ` Eric Blake [this message]
2021-03-19 17:58 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed8fbb82-09f5-bdcf-9a69-6b3351b9cc25@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).