From: Keqian Zhu <zhukeqian1@huawei.com>
To: Peter Xu <peterx@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
jiangkunkun@huawei.com, qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
qemu-arm@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Zenghui Yu <yuzenghui@huawei.com>,
wanghaibin.wang@huawei.com
Subject: Re: [PATCH 1/2] accel: kvm: Fix memory waste under mismatch page size
Date: Thu, 17 Dec 2020 09:03:24 +0800 [thread overview]
Message-ID: <efdcf433-47b8-9059-e1ee-6306a98bc33f@huawei.com> (raw)
In-Reply-To: <20201216204818.GA39844@xz-x1>
On 2020/12/17 4:48, Peter Xu wrote:
> On Wed, Dec 16, 2020 at 04:21:17PM +0800, Keqian Zhu wrote:
>> One more thing, we should consider whether @start and @size is psize aligned (my second
>> patch). Do you agree to add assert on them directly?
>
> Yes I think the 2nd patch is okay, but please address Drew's comments.
>
> Returning -EINVAL is the same as abort() currently - it'll just abort() at
> kvm_log_clear() instead.
OK, I will send v2 soon.
Thanks,
Keqian
>
> Thanks,
>
next prev parent reply other threads:[~2020-12-17 1:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 7:19 [PATCH 0/2] accel: kvm: Some bugfixes for kvm dirty log Keqian Zhu
2020-12-15 7:19 ` [PATCH 1/2] accel: kvm: Fix memory waste under mismatch page size Keqian Zhu
2020-12-15 11:20 ` Andrew Jones
2020-12-16 8:08 ` Keqian Zhu
2020-12-15 17:57 ` Peter Xu
2020-12-16 8:21 ` Keqian Zhu
2020-12-16 20:48 ` Peter Xu
2020-12-17 1:03 ` Keqian Zhu [this message]
2020-12-15 7:19 ` [PATCH 2/2] accel: kvm: Add aligment check for kvm_log_clear_one_slot Keqian Zhu
2020-12-15 11:55 ` Andrew Jones
2020-12-16 7:23 ` Andrew Jones
2020-12-16 8:17 ` Keqian Zhu
2020-12-16 8:11 ` Keqian Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efdcf433-47b8-9059-e1ee-6306a98bc33f@huawei.com \
--to=zhukeqian1@huawei.com \
--cc=dgilbert@redhat.com \
--cc=jiangkunkun@huawei.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).