qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: BALATON Zoltan <balaton@eik.bme.hu>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	David Gibson <david@gibson.dropbear.id.au>,
	f4bug@amsat.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v6 6/8] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM
Date: Mon, 12 Apr 2021 11:31:44 -0700	[thread overview]
Message-ID: <f0175f73-264d-df1c-8c15-ae3d0ce31915@twiddle.net> (raw)
In-Reply-To: <325bb227cea9aba1d3e6c859be830e39d08320bb.1615321729.git.balaton@eik.bme.hu>

On 3/9/21 12:28 PM, BALATON Zoltan wrote:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
> requires APM to be selected.
> 
> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

> ---
>   hw/isa/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index c7f07854f7..9c026d0c51 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -47,6 +47,7 @@ config VT82C686
>       select ACPI_SMBUS
>       select SERIAL_ISA
>       select FDC
> +    select APM
>   
>   config SMC37C669
>       bool
> 



  reply	other threads:[~2021-04-12 18:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 20:28 [PATCH v6 0/8] Pegasos2 emulation BALATON Zoltan
2021-03-02  8:05 ` [PATCH v6 6/8] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM BALATON Zoltan
2021-04-12 18:31   ` Richard Henderson [this message]
2021-03-09 20:28 ` [PATCH v6 1/8] vt82c686: Implement control of serial port io ranges via config regs BALATON Zoltan
2021-03-09 20:28 ` [PATCH v6 5/8] vt82c686: Add emulation of VT8231 south bridge BALATON Zoltan
2021-03-09 20:28 ` [PATCH v6 3/8] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO BALATON Zoltan
2021-03-09 20:28 ` [PATCH v6 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it BALATON Zoltan
2021-03-10  0:02   ` Philippe Mathieu-Daudé
2021-03-10  2:36     ` BALATON Zoltan
2021-03-09 20:28 ` [PATCH v6 2/8] vt82c686: QOM-ify superio related functionality BALATON Zoltan
2021-03-09 23:58   ` Philippe Mathieu-Daudé
2021-03-09 20:28 ` [PATCH v6 7/8] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller BALATON Zoltan
2021-03-09 20:28 ` [PATCH v6 8/8] hw/ppc: Add emulation of Genesi/bPlan Pegasos II BALATON Zoltan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0175f73-264d-df1c-8c15-ae3d0ce31915@twiddle.net \
    --to=rth@twiddle.net \
    --cc=balaton@eik.bme.hu \
    --cc=david@gibson.dropbear.id.au \
    --cc=f4bug@amsat.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).