From: Thomas Huth <thuth@redhat.com>
To: Rafael Kitover <rkitover@gmail.com>, qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] configure: Require pixman for vhost-user-gpu.
Date: Mon, 3 Aug 2020 08:09:08 +0200 [thread overview]
Message-ID: <f09f5172-a22c-d51a-7db7-a6fd880d386c@redhat.com> (raw)
In-Reply-To: <20200801224406.315875-1-rkitover@gmail.com>
On 02/08/2020 00.44, Rafael Kitover wrote:
> Use the test from Makefile to check if vhost-user-gpu is being built,
> and if so require pixman.
Fixes: 9b52b17ba5 ("configure: Allow to build tools without pixman")
... sorry, I missed that there is indeed a tool that requires pixman.
> Signed-off-by: Rafael Kitover <rkitover@gmail.com>
> ---
> configure | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/configure b/configure
> index 2acc4d1465..181b465861 100755
> --- a/configure
> +++ b/configure
> @@ -4062,20 +4062,6 @@ if test "$modules" = yes; then
> fi
> fi
>
> -##########################################
> -# pixman support probe
> -
> -if test "$softmmu" = "no"; then
> - pixman_cflags=
> - pixman_libs=
> -elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
> - pixman_cflags=$($pkg_config --cflags pixman-1)
> - pixman_libs=$($pkg_config --libs pixman-1)
> -else
> - error_exit "pixman >= 0.21.8 not present." \
> - "Please install the pixman devel package."
> -fi
> -
> ##########################################
> # libmpathpersist probe
>
> @@ -4491,6 +4477,20 @@ if test "$opengl" = "yes" && test "$have_x11" = "yes"; then
> done
> fi
>
> +##########################################
> +# pixman support probe
> +
> +if test "$softmmu" = "no" && ! ( test "${linux} ${virglrenderer} ${gbm} ${want_tools}" = "yes yes yes yes" ); then
Do you need the round brackets here?
> + pixman_cflags=
> + pixman_libs=
> +elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
> + pixman_cflags=$($pkg_config --cflags pixman-1)
> + pixman_libs=$($pkg_config --libs pixman-1)
> +else
> + error_exit "pixman >= 0.21.8 not present." \
> + "Please install the pixman devel package."
> +fi
> +
> ##########################################
> # libxml2 probe
> if test "$libxml2" != "no" ; then
>
With the round brackets removed:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-08-03 6:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 22:44 [PATCH] configure: Require pixman for vhost-user-gpu Rafael Kitover
2020-08-03 6:09 ` Thomas Huth [this message]
2020-08-14 7:46 ` Philippe Mathieu-Daudé
2020-08-22 20:29 ` Philippe Mathieu-Daudé
2020-08-25 15:32 ` Thomas Huth
2020-08-25 16:01 ` 罗勇刚(Yonggang Luo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f09f5172-a22c-d51a-7db7-a6fd880d386c@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkitover@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).