* [PATCH] configure: Require pixman for vhost-user-gpu.
@ 2020-08-01 22:44 Rafael Kitover
2020-08-03 6:09 ` Thomas Huth
0 siblings, 1 reply; 6+ messages in thread
From: Rafael Kitover @ 2020-08-01 22:44 UTC (permalink / raw)
To: qemu-devel; +Cc: Rafael Kitover
Use the test from Makefile to check if vhost-user-gpu is being built,
and if so require pixman.
Signed-off-by: Rafael Kitover <rkitover@gmail.com>
---
configure | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/configure b/configure
index 2acc4d1465..181b465861 100755
--- a/configure
+++ b/configure
@@ -4062,20 +4062,6 @@ if test "$modules" = yes; then
fi
fi
-##########################################
-# pixman support probe
-
-if test "$softmmu" = "no"; then
- pixman_cflags=
- pixman_libs=
-elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
- pixman_cflags=$($pkg_config --cflags pixman-1)
- pixman_libs=$($pkg_config --libs pixman-1)
-else
- error_exit "pixman >= 0.21.8 not present." \
- "Please install the pixman devel package."
-fi
-
##########################################
# libmpathpersist probe
@@ -4491,6 +4477,20 @@ if test "$opengl" = "yes" && test "$have_x11" = "yes"; then
done
fi
+##########################################
+# pixman support probe
+
+if test "$softmmu" = "no" && ! ( test "${linux} ${virglrenderer} ${gbm} ${want_tools}" = "yes yes yes yes" ); then
+ pixman_cflags=
+ pixman_libs=
+elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
+ pixman_cflags=$($pkg_config --cflags pixman-1)
+ pixman_libs=$($pkg_config --libs pixman-1)
+else
+ error_exit "pixman >= 0.21.8 not present." \
+ "Please install the pixman devel package."
+fi
+
##########################################
# libxml2 probe
if test "$libxml2" != "no" ; then
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] configure: Require pixman for vhost-user-gpu.
2020-08-01 22:44 [PATCH] configure: Require pixman for vhost-user-gpu Rafael Kitover
@ 2020-08-03 6:09 ` Thomas Huth
2020-08-14 7:46 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2020-08-03 6:09 UTC (permalink / raw)
To: Rafael Kitover, qemu-devel; +Cc: Gerd Hoffmann
On 02/08/2020 00.44, Rafael Kitover wrote:
> Use the test from Makefile to check if vhost-user-gpu is being built,
> and if so require pixman.
Fixes: 9b52b17ba5 ("configure: Allow to build tools without pixman")
... sorry, I missed that there is indeed a tool that requires pixman.
> Signed-off-by: Rafael Kitover <rkitover@gmail.com>
> ---
> configure | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/configure b/configure
> index 2acc4d1465..181b465861 100755
> --- a/configure
> +++ b/configure
> @@ -4062,20 +4062,6 @@ if test "$modules" = yes; then
> fi
> fi
>
> -##########################################
> -# pixman support probe
> -
> -if test "$softmmu" = "no"; then
> - pixman_cflags=
> - pixman_libs=
> -elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
> - pixman_cflags=$($pkg_config --cflags pixman-1)
> - pixman_libs=$($pkg_config --libs pixman-1)
> -else
> - error_exit "pixman >= 0.21.8 not present." \
> - "Please install the pixman devel package."
> -fi
> -
> ##########################################
> # libmpathpersist probe
>
> @@ -4491,6 +4477,20 @@ if test "$opengl" = "yes" && test "$have_x11" = "yes"; then
> done
> fi
>
> +##########################################
> +# pixman support probe
> +
> +if test "$softmmu" = "no" && ! ( test "${linux} ${virglrenderer} ${gbm} ${want_tools}" = "yes yes yes yes" ); then
Do you need the round brackets here?
> + pixman_cflags=
> + pixman_libs=
> +elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
> + pixman_cflags=$($pkg_config --cflags pixman-1)
> + pixman_libs=$($pkg_config --libs pixman-1)
> +else
> + error_exit "pixman >= 0.21.8 not present." \
> + "Please install the pixman devel package."
> +fi
> +
> ##########################################
> # libxml2 probe
> if test "$libxml2" != "no" ; then
>
With the round brackets removed:
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] configure: Require pixman for vhost-user-gpu.
2020-08-03 6:09 ` Thomas Huth
@ 2020-08-14 7:46 ` Philippe Mathieu-Daudé
2020-08-22 20:29 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-08-14 7:46 UTC (permalink / raw)
To: Thomas Huth, Rafael Kitover, qemu-devel; +Cc: Gerd Hoffmann
On 8/3/20 8:09 AM, Thomas Huth wrote:
> On 02/08/2020 00.44, Rafael Kitover wrote:
>> Use the test from Makefile to check if vhost-user-gpu is being built,
>> and if so require pixman.
>
> Fixes: 9b52b17ba5 ("configure: Allow to build tools without pixman")
>
> ... sorry, I missed that there is indeed a tool that requires pixman.
>
>> Signed-off-by: Rafael Kitover <rkitover@gmail.com>
>> ---
>> configure | 28 ++++++++++++++--------------
>> 1 file changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 2acc4d1465..181b465861 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4062,20 +4062,6 @@ if test "$modules" = yes; then
>> fi
>> fi
>>
>> -##########################################
>> -# pixman support probe
>> -
>> -if test "$softmmu" = "no"; then
>> - pixman_cflags=
>> - pixman_libs=
>> -elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
>> - pixman_cflags=$($pkg_config --cflags pixman-1)
>> - pixman_libs=$($pkg_config --libs pixman-1)
>> -else
>> - error_exit "pixman >= 0.21.8 not present." \
>> - "Please install the pixman devel package."
>> -fi
>> -
>> ##########################################
>> # libmpathpersist probe
>>
>> @@ -4491,6 +4477,20 @@ if test "$opengl" = "yes" && test "$have_x11" = "yes"; then
>> done
>> fi
>>
>> +##########################################
>> +# pixman support probe
>> +
>> +if test "$softmmu" = "no" && ! ( test "${linux} ${virglrenderer} ${gbm} ${want_tools}" = "yes yes yes yes" ); then
>
> Do you need the round brackets here?
>
>> + pixman_cflags=
>> + pixman_libs=
>> +elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
>> + pixman_cflags=$($pkg_config --cflags pixman-1)
>> + pixman_libs=$($pkg_config --libs pixman-1)
>> +else
>> + error_exit "pixman >= 0.21.8 not present." \
>> + "Please install the pixman devel package."
>> +fi
>> +
>> ##########################################
>> # libxml2 probe
>> if test "$libxml2" != "no" ; then
>>
>
> With the round brackets removed:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
>
Hmm this doesn't work for me:
$ ../configure --disable-system --disable-user --enable-tools
QEMU_CFLAGS -Werror -pthread -I/usr/include/glib-2.0
-I/usr/lib64/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes
-Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes
-fno-strict-aliasing -fno-common -fwrapv -std=gnu99
-Wold-style-declaration -Wold-style-definition -Wtype-limits
-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers
-Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined
-Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi
-fstack-protector-strong -I/usr/include/p11-kit-1
-DSTRUCT_IOVEC_DEFINED -I/usr/include/libpng16 -I/usr/include/libdrm
-I/usr/include/spice-1 -I/usr/include/spice-server -I/usr/include/cacard
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
-I/usr/include/nss3 -I/usr/include/nspr4 -pthread
-I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid
-I/usr/include/pixman-1 -I/usr/include/capstone
QEMU_LDFLAGS -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64
-fstack-protector-strong
target list
static build no
virgl support yes (0.7.0)
TCG support no
build guest agent yes
$ make vhost-user-gpu
...
LINK vhost-user-gpu
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.o: in function
`vg_resource_create_2d':
contrib/vhost-user-gpu/vhost-user-gpu.c:322: undefined reference to
`pixman_image_create_bits'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.o: in function
`vg_resource_destroy':
contrib/vhost-user-gpu/vhost-user-gpu.c:381: undefined reference to
`pixman_image_unref'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.o: in function
`vg_transfer_to_host_2d':
contrib/vhost-user-gpu/vhost-user-gpu.c:538: undefined reference to
`pixman_image_get_format'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:540: undefined
reference to `pixman_image_get_stride'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:543: undefined
reference to `pixman_image_get_width'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:544: undefined
reference to `pixman_image_get_data'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:556: undefined
reference to `pixman_image_get_stride'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:557: undefined
reference to `pixman_image_get_height'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:555: undefined
reference to `pixman_image_get_data'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.o: in function
`vg_resource_flush':
contrib/vhost-user-gpu/vhost-user-gpu.c:693: undefined reference to
`pixman_region_init_rect'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:705: undefined
reference to `pixman_region_init'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:706: undefined
reference to `pixman_region_init_rect'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:709: undefined
reference to `pixman_region_intersect'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:711: undefined
reference to `pixman_region_extents'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:731: undefined
reference to `pixman_image_get_format'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:731: undefined
reference to `pixman_image_get_format'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:747: undefined
reference to `pixman_image_get_format'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:747: undefined
reference to `pixman_image_create_bits'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:753: undefined
reference to `pixman_image_composite'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:758: undefined
reference to `pixman_image_unref'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:762: undefined
reference to `pixman_region_fini'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:763: undefined
reference to `pixman_region_fini'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:765: undefined
reference to `pixman_region_fini'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.o: in function
`update_cursor_data_simple':
contrib/vhost-user-gpu/vhost-user-gpu.c:863: undefined reference to
`pixman_image_get_width'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:864: undefined
reference to `pixman_image_get_height'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:865: undefined
reference to `pixman_image_get_format'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:865: undefined
reference to `pixman_image_get_format'
/usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:868: undefined
reference to `pixman_image_get_data'
collect2: error: ld returned 1 exit status
make: *** [Makefile:730: vhost-user-gpu] Error 1
$ lsb_release -d
Description: Fedora release 30 (Thirty)
$ pkg-config --atleast-version=0.21.8 pixman-1; echo $?
0
$ pkg-config --cflags pixman-1
-I/usr/include/pixman-1
# found in QEMU_CFLAGS
$ pkg-config --libs pixman-1
-lpixman-1
# NOT found in QEMU_LDFLAGS
Thanks,
Phil.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] configure: Require pixman for vhost-user-gpu.
2020-08-14 7:46 ` Philippe Mathieu-Daudé
@ 2020-08-22 20:29 ` Philippe Mathieu-Daudé
2020-08-25 15:32 ` Thomas Huth
0 siblings, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-08-22 20:29 UTC (permalink / raw)
To: Thomas Huth, Rafael Kitover, qemu-devel; +Cc: Gerd Hoffmann
Hi Rafael,
On 8/14/20 9:46 AM, Philippe Mathieu-Daudé wrote:
> On 8/3/20 8:09 AM, Thomas Huth wrote:
>> On 02/08/2020 00.44, Rafael Kitover wrote:
>>> Use the test from Makefile to check if vhost-user-gpu is being built,
>>> and if so require pixman.
>>
>> Fixes: 9b52b17ba5 ("configure: Allow to build tools without pixman")
>>
>> ... sorry, I missed that there is indeed a tool that requires pixman.
>>
>>> Signed-off-by: Rafael Kitover <rkitover@gmail.com>
>>> ---
>>> configure | 28 ++++++++++++++--------------
>>> 1 file changed, 14 insertions(+), 14 deletions(-)
>>>
>>> diff --git a/configure b/configure
>>> index 2acc4d1465..181b465861 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -4062,20 +4062,6 @@ if test "$modules" = yes; then
>>> fi
>>> fi
>>>
>>> -##########################################
>>> -# pixman support probe
>>> -
>>> -if test "$softmmu" = "no"; then
>>> - pixman_cflags=
>>> - pixman_libs=
>>> -elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
>>> - pixman_cflags=$($pkg_config --cflags pixman-1)
>>> - pixman_libs=$($pkg_config --libs pixman-1)
>>> -else
>>> - error_exit "pixman >= 0.21.8 not present." \
>>> - "Please install the pixman devel package."
>>> -fi
>>> -
>>> ##########################################
>>> # libmpathpersist probe
>>>
>>> @@ -4491,6 +4477,20 @@ if test "$opengl" = "yes" && test "$have_x11" = "yes"; then
>>> done
>>> fi
>>>
>>> +##########################################
>>> +# pixman support probe
>>> +
>>> +if test "$softmmu" = "no" && ! ( test "${linux} ${virglrenderer} ${gbm} ${want_tools}" = "yes yes yes yes" ); then
>>
>> Do you need the round brackets here?
>>
>>> + pixman_cflags=
>>> + pixman_libs=
>>> +elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
>>> + pixman_cflags=$($pkg_config --cflags pixman-1)
>>> + pixman_libs=$($pkg_config --libs pixman-1)
>>> +else
>>> + error_exit "pixman >= 0.21.8 not present." \
>>> + "Please install the pixman devel package."
>>> +fi
>>> +
>>> ##########################################
>>> # libxml2 probe
>>> if test "$libxml2" != "no" ; then
>>>
>>
>> With the round brackets removed:
>>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>
>>
>
> Hmm this doesn't work for me:
>
> $ ../configure --disable-system --disable-user --enable-tools
> QEMU_CFLAGS -Werror -pthread -I/usr/include/glib-2.0
> -I/usr/lib64/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes
> -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes
> -fno-strict-aliasing -fno-common -fwrapv -std=gnu99
> -Wold-style-declaration -Wold-style-definition -Wtype-limits
> -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers
> -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined
> -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi
> -fstack-protector-strong -I/usr/include/p11-kit-1
> -DSTRUCT_IOVEC_DEFINED -I/usr/include/libpng16 -I/usr/include/libdrm
> -I/usr/include/spice-1 -I/usr/include/spice-server -I/usr/include/cacard
> -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
> -I/usr/include/nss3 -I/usr/include/nspr4 -pthread
> -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid
> -I/usr/include/pixman-1 -I/usr/include/capstone
> QEMU_LDFLAGS -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64
> -fstack-protector-strong
> target list
> static build no
> virgl support yes (0.7.0)
> TCG support no
> build guest agent yes
>
> $ make vhost-user-gpu
> ...
> LINK vhost-user-gpu
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.o: in function
> `vg_resource_create_2d':
> contrib/vhost-user-gpu/vhost-user-gpu.c:322: undefined reference to
> `pixman_image_create_bits'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.o: in function
> `vg_resource_destroy':
> contrib/vhost-user-gpu/vhost-user-gpu.c:381: undefined reference to
> `pixman_image_unref'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.o: in function
> `vg_transfer_to_host_2d':
> contrib/vhost-user-gpu/vhost-user-gpu.c:538: undefined reference to
> `pixman_image_get_format'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:540: undefined
> reference to `pixman_image_get_stride'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:543: undefined
> reference to `pixman_image_get_width'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:544: undefined
> reference to `pixman_image_get_data'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:556: undefined
> reference to `pixman_image_get_stride'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:557: undefined
> reference to `pixman_image_get_height'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:555: undefined
> reference to `pixman_image_get_data'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.o: in function
> `vg_resource_flush':
> contrib/vhost-user-gpu/vhost-user-gpu.c:693: undefined reference to
> `pixman_region_init_rect'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:705: undefined
> reference to `pixman_region_init'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:706: undefined
> reference to `pixman_region_init_rect'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:709: undefined
> reference to `pixman_region_intersect'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:711: undefined
> reference to `pixman_region_extents'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:731: undefined
> reference to `pixman_image_get_format'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:731: undefined
> reference to `pixman_image_get_format'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:747: undefined
> reference to `pixman_image_get_format'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:747: undefined
> reference to `pixman_image_create_bits'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:753: undefined
> reference to `pixman_image_composite'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:758: undefined
> reference to `pixman_image_unref'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:762: undefined
> reference to `pixman_region_fini'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:763: undefined
> reference to `pixman_region_fini'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:765: undefined
> reference to `pixman_region_fini'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.o: in function
> `update_cursor_data_simple':
> contrib/vhost-user-gpu/vhost-user-gpu.c:863: undefined reference to
> `pixman_image_get_width'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:864: undefined
> reference to `pixman_image_get_height'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:865: undefined
> reference to `pixman_image_get_format'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:865: undefined
> reference to `pixman_image_get_format'
> /usr/bin/ld: contrib/vhost-user-gpu/vhost-user-gpu.c:868: undefined
> reference to `pixman_image_get_data'
> collect2: error: ld returned 1 exit status
> make: *** [Makefile:730: vhost-user-gpu] Error 1
Any updates?
Thanks,
Phil.
>
> $ lsb_release -d
> Description: Fedora release 30 (Thirty)
>
> $ pkg-config --atleast-version=0.21.8 pixman-1; echo $?
> 0
>
> $ pkg-config --cflags pixman-1
> -I/usr/include/pixman-1
> # found in QEMU_CFLAGS
>
> $ pkg-config --libs pixman-1
> -lpixman-1
> # NOT found in QEMU_LDFLAGS
>
> Thanks,
>
> Phil.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] configure: Require pixman for vhost-user-gpu.
2020-08-22 20:29 ` Philippe Mathieu-Daudé
@ 2020-08-25 15:32 ` Thomas Huth
2020-08-25 16:01 ` 罗勇刚(Yonggang Luo)
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2020-08-25 15:32 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Rafael Kitover, qemu-devel; +Cc: Gerd Hoffmann
On 22/08/2020 22.29, Philippe Mathieu-Daudé wrote:
> Hi Rafael,
>
> On 8/14/20 9:46 AM, Philippe Mathieu-Daudé wrote:
>> On 8/3/20 8:09 AM, Thomas Huth wrote:
>>> On 02/08/2020 00.44, Rafael Kitover wrote:
>>>> Use the test from Makefile to check if vhost-user-gpu is being built,
>>>> and if so require pixman.
>>>
>>> Fixes: 9b52b17ba5 ("configure: Allow to build tools without pixman")
>>>
>>> ... sorry, I missed that there is indeed a tool that requires pixman.
>>>
>>>> Signed-off-by: Rafael Kitover <rkitover@gmail.com>
>>>> ---
>>>> configure | 28 ++++++++++++++--------------
>>>> 1 file changed, 14 insertions(+), 14 deletions(-)
>>>>
>>>> diff --git a/configure b/configure
>>>> index 2acc4d1465..181b465861 100755
>>>> --- a/configure
>>>> +++ b/configure
>>>> @@ -4062,20 +4062,6 @@ if test "$modules" = yes; then
>>>> fi
>>>> fi
>>>>
>>>> -##########################################
>>>> -# pixman support probe
>>>> -
>>>> -if test "$softmmu" = "no"; then
>>>> - pixman_cflags=
>>>> - pixman_libs=
>>>> -elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
>>>> - pixman_cflags=$($pkg_config --cflags pixman-1)
>>>> - pixman_libs=$($pkg_config --libs pixman-1)
>>>> -else
>>>> - error_exit "pixman >= 0.21.8 not present." \
>>>> - "Please install the pixman devel package."
>>>> -fi
>>>> -
>>>> ##########################################
>>>> # libmpathpersist probe
>>>>
>>>> @@ -4491,6 +4477,20 @@ if test "$opengl" = "yes" && test "$have_x11" = "yes"; then
>>>> done
>>>> fi
>>>>
>>>> +##########################################
>>>> +# pixman support probe
>>>> +
>>>> +if test "$softmmu" = "no" && ! ( test "${linux} ${virglrenderer} ${gbm} ${want_tools}" = "yes yes yes yes" ); then
>>>
>>> Do you need the round brackets here?
>>>
>>>> + pixman_cflags=
>>>> + pixman_libs=
>>>> +elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
>>>> + pixman_cflags=$($pkg_config --cflags pixman-1)
>>>> + pixman_libs=$($pkg_config --libs pixman-1)
>>>> +else
>>>> + error_exit "pixman >= 0.21.8 not present." \
>>>> + "Please install the pixman devel package."
>>>> +fi
>>>> +
>>>> ##########################################
>>>> # libxml2 probe
>>>> if test "$libxml2" != "no" ; then
>>>>
>>>
>>> With the round brackets removed:
>>>
>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>
>> Hmm this doesn't work for me:
[...]
> Any updates?
I think the problem is that ${virglrenderer} might only be set later in
the configure script...
But since other tools might later depend on pixman, too, it's likely
cleaner to introduce a CONFIG_PIXMAN switch and skip
building of the corresponding tools in that case. I'll try to come up
with a patch...
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] configure: Require pixman for vhost-user-gpu.
2020-08-25 15:32 ` Thomas Huth
@ 2020-08-25 16:01 ` 罗勇刚(Yonggang Luo)
0 siblings, 0 replies; 6+ messages in thread
From: 罗勇刚(Yonggang Luo) @ 2020-08-25 16:01 UTC (permalink / raw)
To: Thomas Huth
Cc: Gerd Hoffmann, Philippe Mathieu-Daudé, Rafael Kitover, qemu-level
[-- Attachment #1: Type: text/plain, Size: 282 bytes --]
On Tue, Aug 25, 2020 at 11:33 PM Thomas Huth <thuth@redhat.com> wrote:
> On 22/08/2020 22.29, Philippe Mathieu-Daudé wrote:
> > Hi Rafael,
> >
Would these improvement can be implemented in python?
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 663 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-25 16:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-01 22:44 [PATCH] configure: Require pixman for vhost-user-gpu Rafael Kitover
2020-08-03 6:09 ` Thomas Huth
2020-08-14 7:46 ` Philippe Mathieu-Daudé
2020-08-22 20:29 ` Philippe Mathieu-Daudé
2020-08-25 15:32 ` Thomas Huth
2020-08-25 16:01 ` 罗勇刚(Yonggang Luo)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).