From: David Hildenbrand <david@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com
Subject: Re: [PATCH v2 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it
Date: Mon, 12 Apr 2021 18:53:58 +0200 [thread overview]
Message-ID: <f0ea67d8-9641-104d-f8ec-5fc343256cc9@redhat.com> (raw)
In-Reply-To: <20210312173547.1283477-3-pbonzini@redhat.com>
On 12.03.21 18:35, Paolo Bonzini wrote:
> Emulators are currently using OptsVisitor (via user_creatable_add_opts)
> to parse the -object command line option. This has one extra feature,
> compared to keyval, which is automatic conversion of integers to lists
> as well as support for lists as repeated options:
>
> -object memory-backend-ram,id=pc.ram,size=1048576000,host-nodes=0,policy=bind
>
> So we cannot replace OptsVisitor with keyval right now. Still, this
> patch moves the user_creatable_add_opts logic to vl.c since it is
> not needed anywhere else, and makes it go through user_creatable_add_qapi.
>
> In order to minimize code changes, the predicate still takes a string.
> This can be changed later to use the ObjectType QAPI enum directly.
>
Rebasing my "noreserve"[1] series on this, I get weird errors from QEMU
when specifying the new "reserve=off" option for a memory-backend-ram:
"Invalid parameter 'reserve'"
And it looks like this is the case for any new properties. Poking
around, I fail to find what's causing this -- or how to unlock new
properties. What is the magic toggle to make it work?
Thanks!
[1] https://lkml.kernel.org/r/20210319101230.21531-1-david@redhat.com
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-04-12 16:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 17:35 [PATCH v2 0/3] vl: QAPIfy -object Paolo Bonzini
2021-03-12 17:35 ` [PATCH v2 1/3] tests: convert check-qom-proplist to keyval Paolo Bonzini
2021-03-12 17:35 ` [PATCH v2 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it Paolo Bonzini
2021-03-17 11:48 ` Kevin Wolf
2021-04-12 16:53 ` David Hildenbrand [this message]
2021-04-13 4:41 ` Markus Armbruster
2021-04-13 8:13 ` David Hildenbrand
2021-04-13 8:33 ` David Hildenbrand
2021-04-13 9:38 ` Kevin Wolf
2021-04-13 9:48 ` Markus Armbruster
2021-04-16 14:56 ` Paolo Bonzini
2021-03-12 17:35 ` [PATCH v2 3/3] vl: allow passing JSON to -object Paolo Bonzini
2021-03-16 17:31 ` [PATCH v2 0/3] vl: QAPIfy -object Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0ea67d8-9641-104d-f8ec-5fc343256cc9@redhat.com \
--to=david@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).