From: Max Reitz <mreitz@redhat.com>
To: Lukas Straub <lukasstraub2@web.de>, qemu-devel <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block <qemu-block@nongnu.org>,
Wen Congyang <wency@cn.fujitsu.com>,
Wen Congyang <wencongyang2@huawei.com>,
Jason Wang <jasowang@redhat.com>,
Zhang Chen <chen.zhang@intel.com>,
Xie Changlong <xiechanglong.d@gmail.com>
Subject: Re: [PATCH v7 1/4] block/replication.c: Ignore requests after failover
Date: Tue, 29 Oct 2019 14:04:27 +0100 [thread overview]
Message-ID: <f11c009c-76d3-561d-bda6-e263d2c6138b@redhat.com> (raw)
In-Reply-To: <039d59f89205824273eef070cdfa7d5e94f95697.1571925699.git.lukasstraub2@web.de>
[-- Attachment #1.1: Type: text/plain, Size: 728 bytes --]
On 24.10.19 16:25, Lukas Straub wrote:
> After failover the Secondary side of replication shouldn't change state, because
> it now functions as our primary disk.
>
> In replication_start, replication_do_checkpoint, replication_stop, ignore
> the request if current state is BLOCK_REPLICATION_DONE (sucessful failover) or
> BLOCK_REPLICATION_FAILOVER (failover in progres i.e. currently merging active
> and hidden images into the base image).
>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
> Reviewed-by: Zhang Chen <chen.zhang@intel.com>
> ---
> block/replication.c | 35 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)
Acked-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-29 13:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 17:06 [PATCH v7 0/4] colo: Add support for continuous replication Lukas Straub
2019-10-24 14:25 ` [PATCH v7 1/4] block/replication.c: Ignore requests after failover Lukas Straub
2019-10-29 13:04 ` Max Reitz [this message]
2019-10-24 14:25 ` [PATCH v7 2/4] tests/test-replication.c: Add test for for secondary node continuing replication Lukas Straub
2019-10-24 14:25 ` [PATCH v7 3/4] net/filter.c: Add Options to insert filters anywhere in the filter list Lukas Straub
2019-10-24 14:25 ` [PATCH v7 4/4] colo: Update Documentation for continuous replication Lukas Straub
2019-10-30 8:58 ` Zhang, Chen
2019-11-13 16:35 ` [PATCH v7 0/4] colo: Add support " Lukas Straub
2019-11-19 12:28 ` Zhang, Chen
2019-11-19 15:03 ` Jason Wang
2019-11-20 1:31 ` Zhang, Chen
2020-02-20 1:38 ` Zhang, Chen
2020-02-20 6:52 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f11c009c-76d3-561d-bda6-e263d2c6138b@redhat.com \
--to=mreitz@redhat.com \
--cc=chen.zhang@intel.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=lukasstraub2@web.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wencongyang2@huawei.com \
--cc=wency@cn.fujitsu.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).