From: Paolo Bonzini <pbonzini@redhat.com>
To: Jessica Clarke <jrtc27@jrtc27.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH] meson: Propagate gnutls dependency to migration
Date: Sat, 20 Mar 2021 18:07:30 +0100 [thread overview]
Message-ID: <f13f65ab-b921-112a-a4b8-9b14d1fa2b2e@redhat.com> (raw)
In-Reply-To: <87f34651-8726-398e-31bb-3df7e8fac0dd@redhat.com>
On 20/03/21 18:06, Paolo Bonzini wrote:
> On 20/03/21 17:47, Jessica Clarke wrote:
>> Commit 3eacf70bb5a83e4775ad8003cbca63a40f70c8c2 neglected to fix this
>> for softmmu configs, which pull in migration's use of gnutls.
>>
>> Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
>> ---
>> migration/meson.build | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/migration/meson.build b/migration/meson.build
>> index 9645f44005..6fa2f8745d 100644
>> --- a/migration/meson.build
>> +++ b/migration/meson.build
>> @@ -24,7 +24,7 @@ softmmu_ss.add(files(
>> 'savevm.c',
>> 'socket.c',
>> 'tls.c',
>> -))
>> +), gnutls)
>> softmmu_ss.add(when: ['CONFIG_RDMA', rdma], if_true: files('rdma.c'))
>> softmmu_ss.add(when: 'CONFIG_LIVE_BLOCK_MIGRATION', if_true:
>> files('block.c'))
>>
>
> Hi, can you explain in the commit message the compilation failure that
> is being fixed here?
I suppose it's migration/tls.c?
Paolo
next prev parent reply other threads:[~2021-03-20 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 16:47 [PATCH] meson: Propagate gnutls dependency to migration Jessica Clarke
2021-03-20 17:06 ` Paolo Bonzini
2021-03-20 17:07 ` Paolo Bonzini [this message]
2021-03-20 17:12 ` [PATCH v2] " Jessica Clarke
2021-03-23 15:04 ` Juan Quintela
2021-03-23 15:13 ` Daniel P. Berrangé
2021-03-24 13:45 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f13f65ab-b921-112a-a4b8-9b14d1fa2b2e@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jrtc27@jrtc27.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).