From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF50FC433B4 for ; Mon, 19 Apr 2021 19:19:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 551236135F for ; Mon, 19 Apr 2021 19:19:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 551236135F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYZQz-00074F-59 for qemu-devel@archiver.kernel.org; Mon, 19 Apr 2021 15:19:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYYv4-0007qA-MB for qemu-devel@nongnu.org; Mon, 19 Apr 2021 14:46:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYYv3-0004qH-8D for qemu-devel@nongnu.org; Mon, 19 Apr 2021 14:46:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618858006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ypgkd6gTr1/2w3XXK+WylJg10TbzAEf4Uii63ZLuQAM=; b=ggzhU0p8C6HgdLjiwtuWMWb32jhb1w6JxbwskHKN2rt3BroQ10AxGOm5pIWPu81E0MlBRK mqIj6oKoTBR2aihjMkB48Hyz89Ip6qRK/jqPqGIYdNKtjx9DrbyjJEXepKbXUS+mxqoT7n sr068AjzmYSY/mJ/MDPVc/OdPS2GCxo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-fEC4_G_bOiegm0jYEwYDww-1; Mon, 19 Apr 2021 14:46:43 -0400 X-MC-Unique: fEC4_G_bOiegm0jYEwYDww-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8569A801814; Mon, 19 Apr 2021 18:46:42 +0000 (UTC) Received: from wainer-laptop.localdomain (ovpn-116-102.gru2.redhat.com [10.97.116.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id C179019809; Mon, 19 Apr 2021 18:46:24 +0000 (UTC) Subject: Re: [PATCH 4/8] tests/acceptance/migration.py: cancel test if migration is not supported To: Cleber Rosa , qemu-devel@nongnu.org References: <20210415215141.1865467-1-crosa@redhat.com> <20210415215141.1865467-5-crosa@redhat.com> From: Wainer dos Santos Moschetta Message-ID: Date: Mon, 19 Apr 2021 15:46:22 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210415215141.1865467-5-crosa@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=170.10.133.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Beraldo Leal , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Cornelia Huck , Aleksandar Rikalo , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Willian Rampazzo , Auger Eric , qemu-s390x@nongnu.org, Willian Rampazzo , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Aurelien Jarno , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, On 4/15/21 6:51 PM, Cleber Rosa wrote: > FIXME: check if there's a way to query migration support before > actually requesting migration. > > Some targets/machines contain devices that do not support migration. > Let's acknowledge that and cancel the test as early as possible. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/migration.py | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py > index 792639cb69..25ee55f36a 100644 > --- a/tests/acceptance/migration.py > +++ b/tests/acceptance/migration.py > @@ -53,7 +53,11 @@ def do_migrate(self, dest_uri, src_uri=None): > source_vm = self.get_vm() > source_vm.add_args('-nodefaults') > source_vm.launch() > - source_vm.qmp('migrate', uri=src_uri) > + response = source_vm.qmp('migrate', uri=src_uri) > + if 'error' in response: > + if 'desc' in response['error']: > + msg = response['error']['desc'] > + self.cancel('Migration does not seem to be supported: %s' % msg) My concern is about that cancellation actually covering up a real bug. Cleber, have you seen the test failing on CI? - Wainer > self.assert_migration(source_vm, dest_vm) > > def _get_free_port(self):