From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Cleber Rosa <crosa@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH v5 00/16] qemu_iotests: improve debugging options
Date: Mon, 14 Jun 2021 10:48:56 +0200 [thread overview]
Message-ID: <f24a705f-25bc-e5e7-97d7-b01e4e9e89df@redhat.com> (raw)
In-Reply-To: <20210604091723.13419-1-eesposit@redhat.com>
On 04/06/2021 11:17, Emanuele Giuseppe Esposito wrote:
> This series adds the option to attach gdbserver and valgrind
> to the QEMU binary running in qemu_iotests.
> It also allows to redirect QEMU binaries output of the python tests
> to the stdout, instead of a log file.
>
> Patches 1-9 introduce the -gdb option to both python and bash tests,
> 10-14 extend the already existing -valgrind flag to work also on
> python tests, and patch 15-16 introduces -p to enable logging to stdout.
>
> In particular, patches 1,6,11 focus on extending the QMP socket timers
> when using gdb/valgrind, otherwise the python tests will fail due to
> delays in the QMP responses.
>
> This series is tested on the previous serie
> "qemu-iotests: quality of life improvements"
> but independent from it, so it can be applied separately.
>
> It is also based on "iotests/check: move general long options to double dash"
> by Vladimir Sementsov-Ogievskiy.
Apologies to all the people following this series,
I realized that there is a discussion[*] on whether to use the
"--option" notation vs "-option".
Therefore I am going to re-send this series without Vladimir's based-on
(also because I got all necessary reviews, so it should be ready to be
merged).
Thank you,
Emanuele
[*] =
https://patchew.org/QEMU/20210526181659.365531-1-vsementsov@virtuozzo.com/#955ce8e3-eafe-79ab-ad4e-f81ecf08d20f@virtuozzo.com
>
> Based-on: <20210526181659.365531-1-vsementsov@virtuozzo.com>
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> v5:
> * base this serie on the double dash options, so define --gdb instead of -gdb
> * return error if -gdb and -valgrind are used together [Vladimir]
> * style changes (do not use subprocess_check_valgrind() but do the operation
> inside the caller) [Vladimir]
> * minor fixes in commit messages [Vladimir]
> * create a common public function in patch 15 instead of using
> _private fields [Vladimir]
> * use @contextmanager in patch 6 to skip gdb timeouts involving the
> Timeout class [Vladimir]
> * apply John Snow patch to silence pylint warning in the CI tests
>
> Emanuele Giuseppe Esposito (15):
> python: qemu: add timer parameter for qmp.accept socket
> python: qemu: pass the wrapper field from QEMUQtestmachine to
> QEMUMachine
> docs/devel/testing: add debug section to the QEMU iotests chapter
> qemu-iotests: add option to attach gdbserver
> qemu-iotests: delay QMP socket timers
> qemu_iotests: insert gdbserver command line as wrapper for qemu binary
> qemu-iotests: add gdbserver option to script tests too
> docs/devel/testing: add --gdb option to the debugging section of QEMU
> iotests
> qemu-iotests: extend the check script to prepare supporting valgrind
> for python tests
> qemu-iotests: extend QMP socket timeout when using valgrind
> qemu-iotests: allow valgrind to read/delete the generated log file
> qemu-iotests: insert valgrind command line as wrapper for qemu binary
> docs/devel/testing: add --valgrind option to the debug section of QEMU
> iotests
> qemu-iotests: add option to show qemu binary logs on stdout
> docs/devel/testing: add -p option to the debug section of QEMU iotests
>
> John Snow (1):
> python: Reduce strictness of pylint's duplicate-code check
>
> docs/devel/testing.rst | 30 ++++++++++++++++++++
> python/qemu/machine/machine.py | 16 +++++++----
> python/qemu/machine/qtest.py | 9 ++++--
> python/setup.cfg | 5 ++++
> tests/qemu-iotests/check | 15 +++++++---
> tests/qemu-iotests/common.rc | 8 +++++-
> tests/qemu-iotests/iotests.py | 52 ++++++++++++++++++++++++++++++++--
> tests/qemu-iotests/testenv.py | 23 +++++++++++++--
> 8 files changed, 141 insertions(+), 17 deletions(-)
>
prev parent reply other threads:[~2021-06-14 9:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 9:17 [PATCH v5 00/16] qemu_iotests: improve debugging options Emanuele Giuseppe Esposito
2021-06-04 9:17 ` [PATCH v5 01/16] python: qemu: add timer parameter for qmp.accept socket Emanuele Giuseppe Esposito
2021-06-04 9:17 ` [PATCH v5 02/16] python: Reduce strictness of pylint's duplicate-code check Emanuele Giuseppe Esposito
2021-06-05 13:30 ` Vladimir Sementsov-Ogievskiy
2021-06-04 9:17 ` [PATCH v5 03/16] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine Emanuele Giuseppe Esposito
2021-06-04 9:17 ` [PATCH v5 04/16] docs/devel/testing: add debug section to the QEMU iotests chapter Emanuele Giuseppe Esposito
2021-06-04 9:17 ` [PATCH v5 05/16] qemu-iotests: add option to attach gdbserver Emanuele Giuseppe Esposito
2021-06-04 9:17 ` [PATCH v5 06/16] qemu-iotests: delay QMP socket timers Emanuele Giuseppe Esposito
2021-06-14 10:36 ` Emanuele Giuseppe Esposito
2021-06-15 7:57 ` Vladimir Sementsov-Ogievskiy
2021-06-16 7:09 ` Emanuele Giuseppe Esposito
2021-06-16 9:39 ` Vladimir Sementsov-Ogievskiy
2021-06-04 9:17 ` [PATCH v5 07/16] qemu_iotests: insert gdbserver command line as wrapper for qemu binary Emanuele Giuseppe Esposito
2021-06-04 9:17 ` [PATCH v5 08/16] qemu-iotests: add gdbserver option to script tests too Emanuele Giuseppe Esposito
2021-06-04 9:17 ` [PATCH v5 09/16] docs/devel/testing: add --gdb option to the debugging section of QEMU iotests Emanuele Giuseppe Esposito
2021-06-05 13:22 ` Vladimir Sementsov-Ogievskiy
2021-06-04 9:17 ` [PATCH v5 10/16] qemu-iotests: extend the check script to prepare supporting valgrind for python tests Emanuele Giuseppe Esposito
2021-06-05 13:28 ` Vladimir Sementsov-Ogievskiy
2021-06-05 17:38 ` Emanuele Giuseppe Esposito
2021-06-05 19:19 ` Vladimir Sementsov-Ogievskiy
2021-06-04 9:17 ` [PATCH v5 11/16] qemu-iotests: extend QMP socket timeout when using valgrind Emanuele Giuseppe Esposito
2021-06-04 9:17 ` [PATCH v5 12/16] qemu-iotests: allow valgrind to read/delete the generated log file Emanuele Giuseppe Esposito
2021-06-04 9:17 ` [PATCH v5 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary Emanuele Giuseppe Esposito
2021-06-04 9:17 ` [PATCH v5 14/16] docs/devel/testing: add --valgrind option to the debug section of QEMU iotests Emanuele Giuseppe Esposito
2021-06-04 9:17 ` [PATCH v5 15/16] qemu-iotests: add option to show qemu binary logs on stdout Emanuele Giuseppe Esposito
2021-06-04 9:17 ` [PATCH v5 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests Emanuele Giuseppe Esposito
2021-06-14 8:48 ` Emanuele Giuseppe Esposito [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f24a705f-25bc-e5e7-97d7-b01e4e9e89df@redhat.com \
--to=eesposit@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).