From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH-for-6.0] target/mips: Correct the license text
Date: Mon, 19 Apr 2021 19:16:08 +0200 [thread overview]
Message-ID: <f2dbabbe-2c9c-f3a6-cde3-8c3ffa7ee237@amsat.org> (raw)
In-Reply-To: <CAFEAcA-5yjOFpn15-OiBuF4DxyOde=rmZ=ZzypgNtHF1DgeXRw@mail.gmail.com>
On 4/19/21 6:53 PM, Peter Maydell wrote:
> On Sun, 18 Apr 2021 at 09:03, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> The license is the 'GNU General Public License v2.0 or later',
>> not 'and':
>>
>> This program is free software; you can redistribute it and/ori
>> modify it under the terms of the GNU General Public License as
>> published by the Free Software Foundation; either version 2 of
>> the License, or (at your option) any later version.
>>
>> Fix the license comment.
>>
>> Fixes: 3f7a927847a ("target/mips: LSA/DLSA R6 decodetree helpers")
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> Commit introduced after 5.2 release, during the 6.0 cycle.
>> Harmless and useful for 6.0-rc4 IMHO.
>> ---
>> target/mips/rel6_translate.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/mips/rel6_translate.c b/target/mips/rel6_translate.c
>> index 139a7524eea..c5843cbc5e2 100644
>> --- a/target/mips/rel6_translate.c
>> +++ b/target/mips/rel6_translate.c
>> @@ -6,7 +6,7 @@
>> * Copyright (c) 2006 Thiemo Seufer (MIPS32R2 support)
>> * Copyright (c) 2020 Philippe Mathieu-Daudé
>> *
>> - * This code is licensed under the GNU GPLv2 and later.
>> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
>> */
>>
>> #include "qemu/osdep.h"
>
> I find this file's copyright/license comment a little confusing.
> Looking at the actual commits, it seems to be entirely your work,
> in which case you can put any (compatible) license you like on it.
> But the comment header suggests it includes some code copied from
> other files in target/mips and thus copyright by Thiemo and others:
> if that's so then it would seem more logical that this file be
> under the LGPL as older files like translate.c are.
I guess used a template with Thiemo and others by mistake, this file
is new and I wrote all the code content. I have no problem to change
it to LGPL.
Thanks,
Phil.
prev parent reply other threads:[~2021-04-19 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 8:03 [PATCH-for-6.0] target/mips: Correct the license text Philippe Mathieu-Daudé
2021-04-19 16:53 ` Peter Maydell
2021-04-19 17:16 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2dbabbe-2c9c-f3a6-cde3-8c3ffa7ee237@amsat.org \
--to=f4bug@amsat.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).