From: Jie Deng <jie.deng@intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>, qemu-devel@nongnu.org
Cc: "Vincent Guittot" <vincent.guittot@linaro.org>,
"Bill Mills" <bill.mills@linaro.org>,
"Arnd Bergmann" <arnd.bergmann@linaro.com>,
"Mike Holmes" <mike.holmes@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
stratos-dev@op-lists.linaro.org
Subject: Re: [PATCH 3/5] tools/vhost-user-i2c: Add backend driver
Date: Thu, 25 Mar 2021 14:17:13 +0800 [thread overview]
Message-ID: <f2f80985-b452-23e0-1892-2c8eaba4e691@intel.com> (raw)
In-Reply-To: <c269da55e0b3ff984bf538e3001efc4732c6dea7.1616570702.git.viresh.kumar@linaro.org>
On 2021/3/24 15:33, Viresh Kumar wrote:
> +static int vi2c_parse(VuI2c *i2c)
> +{
> + uint16_t client_addr[MAX_I2C_VDEV];
> + int32_t n_adapter = 0, n_client;
> + int64_t addr, bus;
> + const char *cp, *t;
> +
> + while (device_list) {
> + /* Read <bus>:<client_addr>[:<client_addr>] entries one by one */
> + cp = strsep(&device_list, ",");
> +
> + if (!cp || *cp =='\0') {
> + break;
> + }
> +
> + if (n_adapter == MAX_I2C_ADAPTER) {
> + g_printerr("too many adapter (%d), only support %d \n", n_adapter,
> + MAX_I2C_ADAPTER);
> + goto out;
> + }
> +
> + if (qemu_strtol(cp, &t, 10, &bus) || bus < 0) {
> + g_printerr("Invalid bus number %s\n", cp);
> + goto out;
> + }
> +
> + cp = t;
> + n_client = 0;
> +
> + /* Parse clients <client_addr>[:<client_addr>] entries one by one */
> + while (cp != NULL && *cp !='\0') {
> + if (*cp == ':')
> + cp++;
> +
> + if (n_client == MAX_I2C_VDEV) {
> + g_printerr("too many devices (%d), only support %d \n",
> + n_client, MAX_I2C_VDEV);
> + goto out;
> + }
> +
> + if (qemu_strtol(cp, &t, 16, &addr) || addr < 0 || addr > MAX_I2C_VDEV) {
> + g_printerr("Invalid address %s : %lx\n", cp, addr);
> + goto out;
> + }
> +
> + client_addr[n_client++] = addr;
> + cp = t;
> + if (verbose) {
> + g_print("i2c adapter %ld:0x%lx\n", bus, addr);
> + }
> + }
> +
> + i2c->adapter[n_adapter] = vi2c_create_adapter(bus, client_addr, n_client);
> + if (!i2c->adapter[n_adapter])
> + goto out;
> + n_adapter++;
> + }
> +
> + if (!n_adapter) {
> + g_printerr("Failed to add any adapters\n");
> + return -1;
> + }
> +
> + i2c->adapter_num = n_adapter;
i2c->adapter_num is set here, but used in vi2c_remove_adapters.
when you goto out from while {...}, i2c->adapter_num is always 0,
May be a bug ?
> +
> + if (!vi2c_map_adapters(i2c)) {
> + return 0;
> + }
> +
> +out:
> + vi2c_remove_adapters(i2c);
> + return -1;
> +}
> +
>
next prev parent reply other threads:[~2021-03-25 6:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 7:33 [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend Viresh Kumar
2021-03-24 7:33 ` [PATCH 1/5] hw/virtio: add boilerplate for vhost-user-i2c device Viresh Kumar
2021-03-29 15:13 ` Alex Bennée
2021-03-24 7:33 ` [PATCH 2/5] hw/virtio: add vhost-user-i2c-pci boilerplate Viresh Kumar
2021-03-29 15:19 ` Alex Bennée
2021-03-24 7:33 ` [PATCH 3/5] tools/vhost-user-i2c: Add backend driver Viresh Kumar
2021-03-25 5:09 ` Jie Deng
2021-03-25 5:22 ` Viresh Kumar
2021-03-25 12:22 ` Alex Bennée
2021-03-30 12:49 ` Alex Bennée
2021-03-25 6:17 ` Jie Deng [this message]
2021-03-25 6:36 ` Viresh Kumar
2021-03-25 16:16 ` Arnd Bergmann
2021-03-26 6:01 ` Viresh Kumar
2021-03-26 8:33 ` Arnd Bergmann
2021-03-26 7:14 ` Viresh Kumar
2021-03-26 8:24 ` Arnd Bergmann
2021-03-24 7:33 ` [PATCH 4/5] docs: add a man page for vhost-user-i2c Viresh Kumar
2021-03-24 7:33 ` [PATCH 5/5] MAINTAINERS: Add entry for virtio-i2c Viresh Kumar
2021-03-24 7:42 ` [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend no-reply
2021-03-24 11:05 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2f80985-b452-23e0-1892-2c8eaba4e691@intel.com \
--to=jie.deng@intel.com \
--cc=alex.bennee@linaro.org \
--cc=arnd.bergmann@linaro.com \
--cc=bill.mills@linaro.org \
--cc=mike.holmes@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stratos-dev@op-lists.linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).