From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59BF9C433DB for ; Mon, 8 Mar 2021 14:58:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E32E65208 for ; Mon, 8 Mar 2021 14:58:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E32E65208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJHKj-00079k-ES for qemu-devel@archiver.kernel.org; Mon, 08 Mar 2021 09:58:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJHKA-0006fo-Ok for qemu-devel@nongnu.org; Mon, 08 Mar 2021 09:57:34 -0500 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]:42246) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJHK8-0005Pp-U2 for qemu-devel@nongnu.org; Mon, 08 Mar 2021 09:57:34 -0500 Received: by mail-ej1-x630.google.com with SMTP id c10so20909966ejx.9 for ; Mon, 08 Mar 2021 06:57:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=E1SrcyMgQtiEyIP4agR0phsflV3b7ndmC/5mDSIjP+Q=; b=cdfIACrM7wd49V680aFll+18GzF2ZfBnyDB+F3i+IFaI1Ls44fJFZtng+B/2XpWDcF aEEmbm1D2HlMR7xm+HA+3x814SJFVXaoTU/HebPeh02riUsvkWRg7WLoKLNVlhRdEf4A k6X5f1zvAZD66XwcU4aNWuhnD78i+R+2D1larvZmy7n5g8by/O5hUWXD8X+CHjIQmUYc QyJ4Y3BXMFQeveIjgyLBSkCLBdiwcbR23NW6cSVE5KVngsDHw19SbmGsMS2pxBQKcmyL rlM8UYq8WIE0X+xLu8i3HWsJJtChFhgjqdQe3vr2pX1WAk6Mrzf7YNDI3/D27nvV/qKX NncQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E1SrcyMgQtiEyIP4agR0phsflV3b7ndmC/5mDSIjP+Q=; b=lWVNIoQ7cAzvTsgQS6iNaBxIjBQge80jMDm4bGP21CUbMnjWZK8BUZj5eBRx4a8X5Y 6r4sVCyRakwPojejnqPSzRifmIXEDRRVrPnBlVuTeKu7Or+ANs9ZzL1TgdbQJs9etKAq KM6np2Prs8wREEm9P4Nl7i+8aRWyiM2cZEq97uzC3G6v+Hws3tbrSKvANgQSQwYDjPKd Sr9ID5K/n1I1FYO/fkPRy3KfNFj7nYz6YeLm6lxT1wZg8kRNCrNl4s2aHQZgoK0aZrcE cexDegZAe5bWJP4x+uejcPebki7J35cWuBM6ef+em99BP5pHv69tO5y7fpYGIOP9nqpR qWww== X-Gm-Message-State: AOAM532ieabli60qdj+V6Hi88DSrxgLOalui2KvT7DyGyq6Ks/f+g0Jd v/XsN9wVlg+duEcwAG44JJf7UgwEDqw= X-Google-Smtp-Source: ABdhPJwkWvrbTXKjL3x61SxKe3vsteG7Lmpwuvp+CIwMs22aOmCothl+fzW8jw6sWqtNvFPQhZupQw== X-Received: by 2002:a17:906:ad96:: with SMTP id la22mr15962190ejb.237.1615215451395; Mon, 08 Mar 2021 06:57:31 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id d1sm6893703eje.26.2021.03.08.06.57.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Mar 2021 06:57:30 -0800 (PST) Subject: Re: [PATCH v26 00/20] i386 cleanup PART 2 To: Claudio Fontana , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= , "Daniel P . Berrange" References: <20210301085450.1732-1-cfontana@suse.de> <6230ef40-c0ec-875e-dbd3-46fb5925322e@amsat.org> <81208ea0-f389-14d0-c366-0579dee3376d@suse.de> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Mon, 8 Mar 2021 15:57:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <81208ea0-f389-14d0-c366-0579dee3376d@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-x630.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Roman Bolshakov , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/8/21 2:52 PM, Claudio Fontana wrote: > On 3/8/21 2:27 PM, Philippe Mathieu-Daudé wrote: >> Hi Claudio, >> >> On 3/8/21 1:57 PM, Claudio Fontana wrote: >>> Hi, >>> >>> anything else for me to do here? >>> >>> The latest rebased state of this series should be always available here: >>> >>> https://gitlab.com/hw-claudio/qemu/-/tree/i386_cleanup_8 >>> >>> When it comes to the ARM cleanup series, >>> I would like to have the tests pass for ARM, before doing even more changes, could you help me there Philippe? >>> >>> Maybe applying some of your changes on top would fix the failures? I tried, for example with the arm-cpu-features ones, but it didn't work for me.. >> >> TBH I wrote these patches during my personal spare time and this >> became a real Pandora box that drained too much energy. I prefer >> to step back and focus on finishing smaller tasks before burning >> out. That said I appreciate your effort and am interested in >> following / reviewing your work. >> >> Regards, >> >> Phil. >> > > Thanks Philippe for sharing this, and I agree completely, it is very draining. > > The effort of making tests happy that run in artificial environments in particular often feels to me > as too disconnected from actually ensuring that there is no real run time regression. > > qtest_enabled() (implicitly, or explicitly via open-ended else statements) is another painful variable to keep in mind in cpu and machine code, so it is not helpful in my view. > > I'll try to push more to get the tests running again, if you have any comment or idea, feel free to just point me in the right direction, > that is very valuable to me, even without working code. Basically I gave up after realizing from Daniel reviews that we need QMP commands to query QEMU at runtime its built-in features, so we have build-agnostic tests easier to maintain. I agree this is the best way to resolve this particular case, but also scale for various other cases.