From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D5DC433B4 for ; Tue, 6 Apr 2021 20:57:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED539611CC for ; Tue, 6 Apr 2021 20:57:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED539611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTslG-0001no-5j for qemu-devel@archiver.kernel.org; Tue, 06 Apr 2021 16:57:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTsfV-0005WE-A8 for qemu-devel@nongnu.org; Tue, 06 Apr 2021 16:51:25 -0400 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]:34414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTsfT-0003a6-PO for qemu-devel@nongnu.org; Tue, 06 Apr 2021 16:51:25 -0400 Received: by mail-pg1-x534.google.com with SMTP id z16so3887680pga.1 for ; Tue, 06 Apr 2021 13:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9hRqDXoky3u+J1wx3M5/uyV5ckAEl7c4cJ/TG9asXbU=; b=AkQQ1NZ7iVcSA4zlLuRa+kd0biBQ1zTyx6lnhl3eQz/EwXW+Xz+pECwXbgOQ987taP JtWsN2wfbxtDRwWyGQjznqqPi8jkuJocOhdIaWGlU+II2JtJfwuB8cLnhXKJfSZJzRyK H8N0DrLnCy1dZJaVmwYtf+UhmzXVKPSYHYvVA7q9ccy6c2MLqY0KErqpJ2MwoY0w8KJj 5QW8mjxtTiiaVtLb7hPK/e9fCpRDoQZgqTChum4xXslh+BYwnyzEQ3YVurXkexy7GqOz Hl2qSo2qC18b6afaoAyVYPO0mbo0TZVX8S6GwKqlO39J9YC08FTBCZpZ0LuKwzQwsI4Y xwwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9hRqDXoky3u+J1wx3M5/uyV5ckAEl7c4cJ/TG9asXbU=; b=VzAp41JfcX2qs1yScjIvsrFI88CiGWx5Ml1dMdt320q70pW3dlMRHm8cmWjNc/Fqgg 65fhHsSZ1OPP/B/6UFdOvqsbf+5j+S7HxrTlD9gLYbWzcG+ylBa/T56VGk/pD5SR/I9Y MpJDt2aMg17NFD9LqEruE86kPbITbDc8r27/YvK+4Mo5/VPQLMkrbvgBWBKvVwQgs58q 9D2bdjezphS0OSp4Q4f4Q7ZTdsMOmxXzfwb063RKCG7s7aUtEFySW55pOBmmqFjTcUrO v8PoO3ACRLck6mFDp3Kwq/j8eERaj5UnNTRhYX0JXeDAlT6ZFwMTXFK4ZUShd5y2i0nJ TCoA== X-Gm-Message-State: AOAM531z8PxIE3awym0KJSj9xKTi2QSBSYs3Za3apgc0jqF2YnL1qdoW OilcwLH2dZNMHVf6mim0Is9n+A== X-Google-Smtp-Source: ABdhPJww1Vm3PsMkuSpovagVeC2mVP4uUBapINI9Cic4b17XUrMi6CpdfrKiapaMIqwtkZb1Uogg6g== X-Received: by 2002:a63:1502:: with SMTP id v2mr65302pgl.22.1617742282279; Tue, 06 Apr 2021 13:51:22 -0700 (PDT) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id 14sm18044390pgz.48.2021.04.06.13.51.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Apr 2021 13:51:21 -0700 (PDT) Subject: Re: [PATCH v2 14/21] Hexagon (target/hexagon) add A5_ACS (vacsh) To: Taylor Simpson , qemu-devel@nongnu.org References: <1617249213-22667-1-git-send-email-tsimpson@quicinc.com> <1617249213-22667-15-git-send-email-tsimpson@quicinc.com> From: Richard Henderson Message-ID: Date: Tue, 6 Apr 2021 13:51:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1617249213-22667-15-git-send-email-tsimpson@quicinc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ale@rev.ng, bcain@quicinc.com, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/31/21 8:53 PM, Taylor Simpson wrote: > +#define fGEN_TCG_A5_ACS(SHORTCODE) \ > + do { \ > + gen_helper_vacsh_val(RxxV, cpu_env, RxxV, RssV, RttV); \ > + gen_helper_vacsh_pred(PeV, cpu_env, RxxV, RssV, RttV); \ > + } while (0) You've modified RxxV before its last use. I think just swapping the two lines is sufficient. r~