From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands
Date: Mon, 19 Oct 2020 20:04:30 +0200 [thread overview]
Message-ID: <f57b2080-50ac-ee44-be8d-2dd4d6431d57@redhat.com> (raw)
In-Reply-To: <87mu0i2mc7.fsf@dusky.pond.sub.org>
On 10/19/20 6:48 PM, Markus Armbruster wrote:
> Eduardo Habkost <ehabkost@redhat.com> writes:
>
>> On Mon, Oct 19, 2020 at 09:55:20AM +0200, Markus Armbruster wrote:
>>> Eduardo Habkost <ehabkost@redhat.com> writes:
>>>
>>>> On Mon, Oct 12, 2020 at 02:15:31PM +0200, Philippe Mathieu-Daudé wrote:
>>>>> Reduce the machine code pulled into qemu-storage-daemon.
>>>>>
>>>>> The series is fully Acked, but Markus wants it reviewed
>>>>> by the Machine core maintainers.
>>>>
>>>> I've confirmed that all patches move QAPI schema code without
>>>> introducing any additional changes.
>>>>
>>>> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>>>
>>> I take this as "I agree the things moved to machine.json belong there".
>>> Holler if I'm mistaken.
>>
>> I agree machine.json is better than misc.json for them, yes.
>>
>> I miss short descriptions of the purpose of each file, though.
>> It would help us decide what's appropriate in the future.
>
> The QAPI modules are commonly aligned with sub-systems defined in
> MAINTAINERS.
>
> Regardless, file comments would be nice.
I don't understand what you mean/expect by "file comments".
Example?
W.r.t. MAINTAINERS, I can move Xen code to qapi/migration-xen.json;
'query-kvm' is used when no KVM built it, so I'll let it in
machine.json; the others seem to belong in machine.json too,
with no particular justification.
next prev parent reply other threads:[~2020-10-19 18:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 12:15 [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands Philippe Mathieu-Daudé
2020-10-12 12:15 ` [PATCH v2 1/5] qapi: Restrict 'inject-nmi' command to machine code Philippe Mathieu-Daudé
2020-10-12 12:15 ` [PATCH v2 2/5] qapi: Restrict 'system wakeup/reset/powerdown' commands to machine.json Philippe Mathieu-Daudé
2020-10-12 12:15 ` [PATCH v2 3/5] qapi: Restrict '(p)memsave' command to machine code Philippe Mathieu-Daudé
2020-10-12 12:15 ` [PATCH v2 4/5] qapi: Restrict 'query-kvm' " Philippe Mathieu-Daudé
2020-10-12 12:15 ` [PATCH v2 5/5] qapi: Restrict Xen migration commands to migration.json Philippe Mathieu-Daudé
2020-10-15 18:28 ` [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands Eduardo Habkost
2020-10-19 7:55 ` Markus Armbruster
2020-10-19 12:30 ` Eduardo Habkost
2020-10-19 16:48 ` Markus Armbruster
2020-10-19 18:04 ` Philippe Mathieu-Daudé [this message]
2020-10-20 5:39 ` Markus Armbruster
2020-10-20 9:32 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f57b2080-50ac-ee44-be8d-2dd4d6431d57@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).