From: Paolo Bonzini <pbonzini@redhat.com>
To: Raphael Norwitz <raphael.norwitz@nutanix.com>,
Stefan Hajnoczi <stefanha@gmail.com>
Cc: fam@euphon.net, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs
Date: Thu, 22 Aug 2019 10:30:59 +0200 [thread overview]
Message-ID: <f58e4c47-dd80-9046-861e-309504394886@redhat.com> (raw)
In-Reply-To: <20190822040725.GA26234@raphael-norwitz.user.nutanix.com>
On 22/08/19 06:07, Raphael Norwitz wrote:
> On Fri, Jun 14, 2019 at 10:18:41AM +0100, Stefan Hajnoczi wrote:
>> On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote:
>>> Of the 3 virtqueues, seabios only sets cmd, leaving ctrl
>>> and event without a physical address. This can cause
>>> vhost_verify_ring_part_mapping to return ENOMEM, causing
>>> the following logs:
>>>
>>> qemu-system-x86_64: Unable to map available ring for ring 0
>>> qemu-system-x86_64: Verify ring failure on region 0
>>>
>>> The qemu commit e6cc11d64fc998c11a4dfcde8fda3fc33a74d844
>>> has already resolved the issue for vhost scsi devices but
>>> the fix was never applied to vhost-user scsi devices.
>>>
>>> Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
>>> ---
>>> hw/scsi/vhost-user-scsi.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Ping on this. Any reason it has not been merged?
I had missed it. I have now queued it (but I won't send another pull
request until approx. the middle of September).
Paolo
next prev parent reply other threads:[~2019-08-22 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 0:35 [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs Raphael Norwitz
2019-06-14 9:18 ` Stefan Hajnoczi
2019-08-22 4:07 ` Raphael Norwitz
2019-08-22 8:30 ` Paolo Bonzini [this message]
2019-08-22 15:52 ` Stefan Hajnoczi
2019-08-22 8:58 ` Philippe Mathieu-Daudé
2019-08-22 17:30 ` Raphael Norwitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f58e4c47-dd80-9046-861e-309504394886@redhat.com \
--to=pbonzini@redhat.com \
--cc=fam@euphon.net \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).