From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Joel Stanley <joel@jms.id.au>, Peter Maydell <peter.maydell@linaro.org>
Cc: "Andrew Jeffery" <andrew@aj.id.au>,
"QEMU Developers" <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>, "Cédric Le Goater" <clg@kaod.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for 4.1] aspeed/timer: Provide back-pressure information for short periods
Date: Tue, 16 Jul 2019 09:02:19 +0200 [thread overview]
Message-ID: <f5ed785c-027d-66fe-aba2-d03001b44162@redhat.com> (raw)
In-Reply-To: <CACPK8XfZq1FvMBXLgS-WHoJy4s_L9k19hLW-XgBNoiY-DhGhWA@mail.gmail.com>
On 7/16/19 9:00 AM, Joel Stanley wrote:
> On Tue, 16 Jul 2019 at 06:54, Joel Stanley <joel@jms.id.au> wrote:
>>
>> Hi Peter,
>>
>> On Thu, 4 Jul 2019 at 12:26, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>>
>>> On 04/07/19 12:13, Stefan Hajnoczi wrote:
>>>> On Thu, Jul 04, 2019 at 11:26:53AM +0200, Philippe Mathieu-Daudé wrote:
>>>>> CC'ing Stefan & Paolo for a non-ARM view on this...
>>>>
>>>> I'm not familiar with the various clock smoothing techniques implemented
>>>> in QEMU and KVM, but this looks okay given that Linux guests expect
>>>> this.
>>>
>>> Yeah, even KVM applies a minimum period of 200us to the x86 LAPIC timer.
>>
>> Can we please merge this so guests can boot on 4.1?
>
> Cédric pointed out this lacks my reviewed by. I had not provided it in
> the past as I wondered if we could come up with a better fix. However,
> I consider this a good fix for 4.1, and if sometime finds time to
> further rework the timer model in the future then we can do that work
> later.
Agreed.
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> Tested-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-07-16 7:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 5:51 [Qemu-devel] [PATCH for 4.1] aspeed/timer: Provide back-pressure information for short periods Cédric Le Goater
2019-07-04 6:27 ` no-reply
2019-07-04 9:26 ` Philippe Mathieu-Daudé
2019-07-04 10:13 ` Stefan Hajnoczi
2019-07-04 12:26 ` Paolo Bonzini
2019-07-16 6:54 ` Joel Stanley
2019-07-16 7:00 ` Joel Stanley
2019-07-16 7:02 ` Philippe Mathieu-Daudé [this message]
2019-08-21 3:16 ` Joel Stanley
2019-08-27 15:37 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5ed785c-027d-66fe-aba2-d03001b44162@redhat.com \
--to=philmd@redhat.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).