From: Brad Smith <brad@comstyle.com>
To: Richard Henderson <richard.henderson@linaro.org>,
Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] tcg/ppc: Fix building with Clang
Date: Sun, 2 May 2021 00:02:56 -0400 [thread overview]
Message-ID: <f64963a3-6c13-a8b8-9591-2080dfd9f7ed@comstyle.com> (raw)
In-Reply-To: <4b7a580a-d701-f545-a8c2-5d18ea25a187@linaro.org>
On 4/22/2021 11:39 AM, Richard Henderson wrote:
> On 4/22/21 2:20 AM, Peter Maydell wrote:
>> On Thu, 22 Apr 2021 at 06:18, Richard Henderson
>>> I'm thinking something like
>>>
>>> #if !defined(_CALL_SYSV) && \
>>> !defined(_CALL_DARWIN) && \
>>> !defined(_CALL_AIX) && \
>>> !defined(_CALL_ELF)
>>> # if defined(__APPLE__)
>>> # define _CALL_DARWIN
>>> # elif defined(__ELF__) && TCG_TARGET_REG_BITS == 32
>>> # define _CALL_SYSV
>>> # else
>>> # error "Unknown ABI"
>>> # endif
>>> #endif
>>
>> Doesn't this also need some case that handles "64bit ppc clang which
>> doesn't
>> define _CALL_anything" ?
>
> Clang does define _CALL_ELF for ppc64:
>
> // ABI options.
> if (ABI == "elfv1")
> Builder.defineMacro("_CALL_ELF", "1");
> if (ABI == "elfv2")
> Builder.defineMacro("_CALL_ELF", "2");
>
Able to spin up a patch that you think is appropriate?
next prev parent reply other threads:[~2021-05-02 4:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 1:14 [PATCH] tcg/ppc: Fix building with Clang Brad Smith
2021-04-21 9:03 ` Peter Maydell
2021-04-22 5:18 ` Richard Henderson
2021-04-22 9:20 ` Peter Maydell
2021-04-22 15:39 ` Richard Henderson
2021-05-02 4:02 ` Brad Smith [this message]
2021-05-27 20:32 ` Brad Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f64963a3-6c13-a8b8-9591-2080dfd9f7ed@comstyle.com \
--to=brad@comstyle.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).