From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD99AC433C1 for ; Wed, 24 Mar 2021 21:11:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1034B61A09 for ; Wed, 24 Mar 2021 21:11:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1034B61A09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPAnC-0006gt-T2 for qemu-devel@archiver.kernel.org; Wed, 24 Mar 2021 17:11:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPAlZ-00062a-NB for qemu-devel@nongnu.org; Wed, 24 Mar 2021 17:10:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:31547) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPAlT-0004sE-J0 for qemu-devel@nongnu.org; Wed, 24 Mar 2021 17:10:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616620205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jR7MSirqKXDnkkHpI/5FgeZvMDdeIWfZW9D8noi6I88=; b=N9krfZjoQSKQl1IqQgBP4q6v569ljavrypTGuRHMETngPA7hazJStJG2vIQJ+NMenrQJ31 et/nNouNm0d9GbmPYtmw5/Zc8w/A/kwEXdBrxpERXxyoOd980nOX/YbRDgfvaU1Bu4pq7m DUELpNVn43gsbiFraCL2FgvPB33yGFE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-76-ngczgMqIN4We7G0PWQF0Yw-1; Wed, 24 Mar 2021 17:10:03 -0400 X-MC-Unique: ngczgMqIN4We7G0PWQF0Yw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 95C1318754EC; Wed, 24 Mar 2021 21:09:16 +0000 (UTC) Received: from [10.10.117.181] (ovpn-117-181.rdu2.redhat.com [10.10.117.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9217819C93; Wed, 24 Mar 2021 21:09:14 +0000 (UTC) Subject: Re: [PATCH v3 04/16] qapi/expr.py: Add assertion for union type 'check_dict' To: Markus Armbruster References: <20210223003408.964543-1-jsnow@redhat.com> <20210223003408.964543-5-jsnow@redhat.com> <874ki169dg.fsf@dusky.pond.sub.org> From: John Snow Message-ID: Date: Wed, 24 Mar 2021 17:09:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <874ki169dg.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Cleber Rosa , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/24/21 5:35 AM, Markus Armbruster wrote: > John Snow writes: > >> mypy isn't fond of allowing you to check for bool membership in a >> collection of str elements. Guard this lookup for precisely when we were >> given a name. >> >> Signed-off-by: John Snow >> Reviewed-by: Eduardo Habkost >> Reviewed-by: Cleber Rosa >> --- >> scripts/qapi/expr.py | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py >> index 783282b53ce..138fab0711f 100644 >> --- a/scripts/qapi/expr.py >> +++ b/scripts/qapi/expr.py >> @@ -173,7 +173,9 @@ def check_type(value, info, source, >> raise QAPISemError(info, >> "%s should be an object or type name" % source) >> >> - permit_upper = allow_dict in info.pragma.name_case_whitelist >> + permit_upper = False >> + if isinstance(allow_dict, str): >> + permit_upper = allow_dict in info.pragma.name_case_whitelist >> >> # value is a dictionary, check that each member is okay >> for (key, arg) in value.items(): > > Busy-work like this can make me doubt typing is worth the notational > overhead. > > There must a less awkward way to plumb "upper case okay" through > check_type() to check_name_is_str(). But we're typing what we have. > Leaving this as-is for now. There's something I'd like to do about it, but it has to happen later. (I think all the pragma checks should happen in schema.py, and not in expr.py. They are by their essence not context-free, since they depend on the context of the pragma.)