From: Richard Henderson <richard.henderson@linaro.org>
To: Warner Losh <imp@bsdimp.com>, qemu-devel@nongnu.org
Cc: Kyle Evans <kevans@freebsd.org>, Stacey Son <sson@FreeBSD.org>,
f4bug@amsat.org
Subject: Re: [PATCH 10/14] bsd-user: Add stop_all_tasks
Date: Thu, 23 Sep 2021 11:04:05 -0700 [thread overview]
Message-ID: <f76526cf-18c8-47b1-3543-db05c0c0b695@linaro.org> (raw)
In-Reply-To: <20210922061438.27645-11-imp@bsdimp.com>
On 9/21/21 11:14 PM, Warner Losh wrote:
> +void stop_all_tasks(void)
> +{
> + /*
> + * We trust when using NPTL (pthreads) start_exclusive() handles thread
> + * stopping correctly.
> + */
> + start_exclusive();
> +}
Eh. It begs the question of why this is present, as opposed to calling start_exclusive
directly for the one (1) use. Looks to me like we should remove it.
r~
next prev parent reply other threads:[~2021-09-24 12:16 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 6:14 [PATCH 00/14] bsd-user: misc cleanup for aarch64 import Warner Losh
2021-09-22 6:14 ` [PATCH 01/14] bsd-user/target_os-user.h: Remove support for FreeBSD older than 12.0 Warner Losh
2021-09-22 6:14 ` [PATCH 02/14] bsd-user/strace.list: Remove support for FreeBSD versions " Warner Losh
2021-09-23 17:57 ` Richard Henderson
2021-09-22 6:14 ` [PATCH 03/14] bsd-user: TARGET_RESET define is unused, remove it Warner Losh
2021-09-23 17:57 ` Richard Henderson
2021-09-25 10:30 ` Philippe Mathieu-Daudé
2021-09-22 6:14 ` [PATCH 04/14] bsd-user: export get_errno and is_error from syscall.c Warner Losh
2021-09-23 17:58 ` Richard Henderson
2021-09-25 10:33 ` Philippe Mathieu-Daudé
2021-09-26 17:14 ` Warner Losh
2021-09-22 6:14 ` [PATCH 05/14] bsd-user/errno_defs.h: Add internal error numbers Warner Losh
2021-09-23 17:59 ` Richard Henderson
2021-09-22 6:14 ` [PATCH 06/14] bsd-user: move TARGET_MC_GET_CLEAR_RET to target_os_signal.h Warner Losh
2021-09-23 18:00 ` Richard Henderson
2021-09-25 10:35 ` Philippe Mathieu-Daudé
2021-09-26 17:16 ` Warner Losh
2021-09-22 6:14 ` [PATCH 07/14] bsd-user/target_os_elf.h: Remove fallback ELF_HWCAP and reorder Warner Losh
2021-09-23 18:01 ` Richard Henderson
2021-09-25 10:36 ` Philippe Mathieu-Daudé
2021-09-22 6:14 ` [PATCH 08/14] bsd-user/target_os_elf: If ELF_HWCAP2 is defined, publish it Warner Losh
2021-09-23 18:01 ` Richard Henderson
2021-09-25 10:37 ` Philippe Mathieu-Daudé
2021-09-22 6:14 ` [PATCH 09/14] bsd-user: Remove used from TaskState Warner Losh
2021-09-23 18:02 ` Richard Henderson
2021-09-25 10:38 ` Philippe Mathieu-Daudé
2021-09-22 6:14 ` [PATCH 10/14] bsd-user: Add stop_all_tasks Warner Losh
2021-09-23 18:04 ` Richard Henderson [this message]
2021-09-22 6:14 ` [PATCH 11/14] bsd-user/sysarch: Move to using do_freebsd_arch_sysarch interface Warner Losh
2021-09-23 18:07 ` Richard Henderson
2021-09-24 15:25 ` Warner Losh
2021-09-22 6:14 ` [PATCH 12/14] bsd-user/sysarch: Provide a per-arch framework for sysarch syscall Warner Losh
2021-09-23 18:08 ` Richard Henderson
2021-09-25 10:46 ` Philippe Mathieu-Daudé
2021-09-26 17:21 ` Warner Losh
2021-09-22 6:14 ` [PATCH 13/14] bsd-user: Rename sigqueue to qemu_sigqueue Warner Losh
2021-09-23 18:09 ` Richard Henderson
2021-09-25 10:46 ` Philippe Mathieu-Daudé
2021-09-22 6:14 ` [PATCH 14/14] bsd-user/signal: Create a dummy signal queueing function Warner Losh
2021-09-23 18:13 ` Richard Henderson
2021-09-24 20:11 ` Warner Losh
2021-09-24 20:30 ` Kyle Evans
2021-09-24 23:51 ` Richard Henderson
2021-09-26 18:14 ` Warner Losh
2021-09-26 18:34 ` Philippe Mathieu-Daudé
2021-09-26 19:00 ` Warner Losh
2021-09-26 19:13 ` Philippe Mathieu-Daudé
2021-09-25 10:50 ` Philippe Mathieu-Daudé
2021-09-25 14:53 ` Warner Losh
2021-09-26 3:06 ` Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f76526cf-18c8-47b1-3543-db05c0c0b695@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=qemu-devel@nongnu.org \
--cc=sson@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).