From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 065D8C433EF for ; Sun, 12 Sep 2021 16:47:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B16AF61051 for ; Sun, 12 Sep 2021 16:47:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B16AF61051 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ilande.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:35598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPSde-0007Kx-Ta for qemu-devel@archiver.kernel.org; Sun, 12 Sep 2021 12:47:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPScB-0006L3-Q0 for qemu-devel@nongnu.org; Sun, 12 Sep 2021 12:45:59 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:35432 helo=mail.default.ilande.bv.iomart.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPScA-0001kv-CE for qemu-devel@nongnu.org; Sun, 12 Sep 2021 12:45:59 -0400 Received: from host109-153-76-56.range109-153.btcentralplus.com ([109.153.76.56] helo=[192.168.50.176]) by mail.default.ilande.bv.iomart.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mPSc3-0006fO-6a; Sun, 12 Sep 2021 17:45:55 +0100 To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, laurent@vivier.eu References: <20210912074914.22048-1-mark.cave-ayland@ilande.co.uk> <20210912074914.22048-8-mark.cave-ayland@ilande.co.uk> <439e516b-baac-0334-ba61-87c21e666506@amsat.org> From: Mark Cave-Ayland Message-ID: Date: Sun, 12 Sep 2021 17:45:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <439e516b-baac-0334-ba61-87c21e666506@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 109.153.76.56 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH 07/20] nubus: add trace-events for unassigned slot accesses X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.bv.iomart.io) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.bv.iomart.io X-Spam_score_int: -54 X-Spam_score: -5.5 X-Spam_bar: ----- X-Spam_report: (-5.5 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-3.584, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/09/2021 16:18, Philippe Mathieu-Daudé wrote: > On 9/12/21 9:49 AM, Mark Cave-Ayland wrote: >> These allow tracing of the Nubus enumeration process by the guest OS. >> >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/nubus/nubus-bus.c | 10 +++++++--- >> hw/nubus/trace-events | 7 +++++++ >> hw/nubus/trace.h | 1 + >> meson.build | 1 + >> 4 files changed, 16 insertions(+), 3 deletions(-) >> create mode 100644 hw/nubus/trace-events >> create mode 100644 hw/nubus/trace.h > >> @@ -38,7 +40,7 @@ static const MemoryRegionOps nubus_slot_ops = { >> .endianness = DEVICE_BIG_ENDIAN, >> .valid = { >> .min_access_size = 1, >> - .max_access_size = 1, >> + .max_access_size = 4, >> }, >> }; > > This patch does a bit more that what is described. Ah oops - presumably one of the OSs I was testing was probing with 32-bit accesses instead of 8-bit accesses and I made the adjustment to ensure the bus enumeration for empty slots appeared in the trace events. I'll update the commit message accordingly. >> @@ -60,7 +64,7 @@ static const MemoryRegionOps nubus_super_slot_ops = { >> .endianness = DEVICE_BIG_ENDIAN, >> .valid = { >> .min_access_size = 1, >> - .max_access_size = 1, >> + .max_access_size = 4, >> }, >> }; ATB, Mark.