From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, qemu-stable@nongnu.org
Subject: Re: [PATCH] migration: do not restart VM after successful snapshot-load
Date: Tue, 4 May 2021 12:20:09 -0500 [thread overview]
Message-ID: <fab3a0d5-d5d5-33e8-88f7-5aaa61c61330@redhat.com> (raw)
In-Reply-To: <20210504165826.618801-1-pbonzini@redhat.com>
On 5/4/21 11:58 AM, Paolo Bonzini wrote:
> The HMP loadvm code is calling load_snapshot rather than
> qmp_snapshot_load, in order to bypass the job infrastructure. The code
> around it is almost the same, with one difference: hmp_loadvm is
> restarting the VM if load_snapshot fails, qmp_snapshot_load is doing so
> if load_snapshot succeeds.
>
> Fix the bug in QMP by moving the common code to load_snapshot.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> migration/savevm.c | 16 ++++++++--------
> monitor/hmp-cmds.c | 7 +------
> 2 files changed, 9 insertions(+), 14 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-05-04 17:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 16:58 [PATCH] migration: do not restart VM after successful snapshot-load Paolo Bonzini
2021-05-04 17:20 ` Eric Blake [this message]
2021-05-04 17:26 ` Daniel P. Berrangé
2021-05-04 19:17 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fab3a0d5-d5d5-33e8-88f7-5aaa61c61330@redhat.com \
--to=eblake@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).