From: John Snow <jsnow@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 00/11] Ide patches
Date: Mon, 18 Sep 2017 13:55:16 -0400 [thread overview]
Message-ID: <fb54f008-2913-3cd2-df95-41b1fcf3f2ee@redhat.com> (raw)
In-Reply-To: <CAFEAcA8un6eescSDzd+P+jqEGuGkuQXgfjm+1=CPOydg6WQSnQ@mail.gmail.com>
On 09/16/2017 10:34 AM, Peter Maydell wrote:
> On 16 September 2017 at 02:03, John Snow <jsnow@redhat.com> wrote:
>> The following changes since commit 5faf2d376af3cb4eb92da44c2580e08d39832caa:
>>
>> Merge remote-tracking branch 'remotes/huth/tags/check-20170915' into staging (2017-09-15 20:29:44 +0100)
>>
>> are available in the git repository at:
>>
>> https://github.com/jnsnow/qemu.git tags/ide-pull-request
>>
>> for you to fetch changes up to 2a94e34d3ecef91727f467cc012587c632099d40:
>>
>> AHCI: remove DPRINTF macro (2017-09-15 20:36:18 -0400)
>>
>> ----------------------------------------------------------------
>>
>> ----------------------------------------------------------------
>
> Hi; I'm afraid this doesn't build with clang:
>
> /home/petmay01/linaro/qemu-for-merges/hw/ide/core.c:70:15: error:
> comparison of unsigned enum expression >= 0 is always true
> [-Werror,-Wtautological-compare]
> if (enval >= 0 && enval < IDE_DMA__COUNT) {
> ~~~~~ ^ ~
> 1 error generated.
>
> (It's impdef whether an enum with all positive values is
> a signed type or unsigned type, so just deleting the
> comparison against 0 would also be wrong...)
>
> thanks
> -- PMM
>
Huh, impdef in the general case, but is it undefined for gnu99? I'm
wondering why Clang can be so certain about this comparison being
useless. Is this a Clang "bug"?
--js
next prev parent reply other threads:[~2017-09-18 17:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-16 1:03 [Qemu-devel] [PULL 00/11] Ide patches John Snow
2017-09-16 1:03 ` [Qemu-devel] [PULL 01/11] ide: ahci: unparent children buses before freeing their memory John Snow
2017-09-16 1:03 ` [Qemu-devel] [PULL 02/11] hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false John Snow
2017-09-16 1:03 ` [Qemu-devel] [PULL 03/11] IDE: replace DEBUG_IDE with tracing system John Snow
2017-09-16 1:03 ` [Qemu-devel] [PULL 04/11] IDE: Add register hints to tracing John Snow
2017-09-16 1:03 ` [Qemu-devel] [PULL 05/11] IDE: add tracing for data ports John Snow
2017-09-16 1:03 ` [Qemu-devel] [PULL 06/11] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events John Snow
2017-09-16 1:03 ` [Qemu-devel] [PULL 07/11] IDE: replace DEBUG_AIO with trace events John Snow
2017-09-16 1:03 ` [Qemu-devel] [PULL 08/11] AHCI: Replace DPRINTF with trace-events John Snow
2017-09-16 1:03 ` [Qemu-devel] [PULL 09/11] AHCI: Rework IRQ constants John Snow
2017-09-16 1:03 ` [Qemu-devel] [PULL 10/11] AHCI: pretty-print FIS to buffer instead of stderr John Snow
2017-09-16 1:03 ` [Qemu-devel] [PULL 11/11] AHCI: remove DPRINTF macro John Snow
2017-09-16 1:29 ` [Qemu-devel] [PULL 00/11] Ide patches no-reply
2017-09-16 14:34 ` Peter Maydell
2017-09-18 13:51 ` Eric Blake
2017-09-18 17:55 ` John Snow [this message]
2017-09-18 18:00 ` Peter Maydell
2017-09-18 18:14 ` Peter Maydell
2017-09-20 17:02 ` Mark Cave-Ayland
2017-09-20 17:55 ` John Snow
2017-09-20 19:01 ` Mark Cave-Ayland
-- strict thread matches above, loose matches on Subject: below --
2016-02-10 19:37 John Snow
2016-02-10 19:37 ` John Snow
2016-02-11 15:09 ` Peter Maydell
2016-01-09 0:51 John Snow
2016-01-11 11:18 ` Peter Maydell
2016-01-11 17:18 ` John Snow
2016-01-11 17:36 ` Peter Maydell
2015-09-18 15:04 John Snow
2015-09-18 17:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb54f008-2913-3cd2-df95-41b1fcf3f2ee@redhat.com \
--to=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).