qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] target/hexagon/gen_tcg_funcs: Fix a typo
@ 2021-02-25 18:15 Philippe Mathieu-Daudé
  2021-02-25 18:35 ` Taylor Simpson
  2021-03-09 20:31 ` Laurent Vivier
  0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-25 18:15 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, Taylor Simpson, Philippe Mathieu-Daudé

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/hexagon/gen_tcg_funcs.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/target/hexagon/gen_tcg_funcs.py b/target/hexagon/gen_tcg_funcs.py
index fe4d8e57303..db9f663a778 100755
--- a/target/hexagon/gen_tcg_funcs.py
+++ b/target/hexagon/gen_tcg_funcs.py
@@ -35,7 +35,7 @@ def gen_decl_ea_tcg(f, tag):
 def gen_free_ea_tcg(f):
     f.write("    tcg_temp_free(EA);\n")
 
-def genptr_decl_pair_writeble(f, tag, regtype, regid, regno):
+def genptr_decl_pair_writable(f, tag, regtype, regid, regno):
     regN="%s%sN" % (regtype,regid)
     f.write("    TCGv_i64 %s%sV = tcg_temp_local_new_i64();\n" % \
         (regtype, regid))
@@ -54,7 +54,7 @@ def genptr_decl_pair_writeble(f, tag, regtype, regid, regno):
                              (regN, regN))
         f.write("    }\n")
 
-def genptr_decl_writeble(f, tag, regtype, regid, regno):
+def genptr_decl_writable(f, tag, regtype, regid, regno):
     regN="%s%sN" % (regtype,regid)
     f.write("    TCGv %s%sV = tcg_temp_local_new();\n" % \
         (regtype, regid))
@@ -78,12 +78,12 @@ def genptr_decl(f, tag, regtype, regid, regno):
             f.write("    const int %s = insn->regno[%d];\n" % \
                 (regN, regno))
         elif (regid in {"dd", "ee", "xx", "yy"}):
-            genptr_decl_pair_writeble(f, tag, regtype, regid, regno)
+            genptr_decl_pair_writable(f, tag, regtype, regid, regno)
         elif (regid in {"s", "t", "u", "v"}):
             f.write("    TCGv %s%sV = hex_gpr[insn->regno[%d]];\n" % \
                 (regtype, regid, regno))
         elif (regid in {"d", "e", "x", "y"}):
-            genptr_decl_writeble(f, tag, regtype, regid, regno)
+            genptr_decl_writable(f, tag, regtype, regid, regno)
         else:
             print("Bad register parse: ", regtype, regid)
     elif (regtype == "P"):
@@ -91,7 +91,7 @@ def genptr_decl(f, tag, regtype, regid, regno):
             f.write("    TCGv %s%sV = hex_pred[insn->regno[%d]];\n" % \
                 (regtype, regid, regno))
         elif (regid in {"d", "e", "x"}):
-            genptr_decl_writeble(f, tag, regtype, regid, regno)
+            genptr_decl_writable(f, tag, regtype, regid, regno)
         else:
             print("Bad register parse: ", regtype, regid)
     elif (regtype == "C"):
@@ -101,14 +101,14 @@ def genptr_decl(f, tag, regtype, regid, regno):
             f.write("    const int %s = insn->regno[%d] + HEX_REG_SA0;\n" % \
                 (regN, regno))
         elif (regid == "dd"):
-            genptr_decl_pair_writeble(f, tag, regtype, regid, regno)
+            genptr_decl_pair_writable(f, tag, regtype, regid, regno)
         elif (regid == "s"):
             f.write("    TCGv %s%sV = tcg_temp_local_new();\n" % \
                 (regtype, regid))
             f.write("    const int %s%sN = insn->regno[%d] + HEX_REG_SA0;\n" % \
                 (regtype, regid, regno))
         elif (regid == "d"):
-            genptr_decl_writeble(f, tag, regtype, regid, regno)
+            genptr_decl_writable(f, tag, regtype, regid, regno)
         else:
             print("Bad register parse: ", regtype, regid)
     elif (regtype == "M"):
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] target/hexagon/gen_tcg_funcs: Fix a typo
  2021-02-25 18:15 [PATCH] target/hexagon/gen_tcg_funcs: Fix a typo Philippe Mathieu-Daudé
@ 2021-02-25 18:35 ` Taylor Simpson
  2021-03-09 20:31 ` Laurent Vivier
  1 sibling, 0 replies; 3+ messages in thread
From: Taylor Simpson @ 2021-02-25 18:35 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial



> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Thursday, February 25, 2021 12:15 PM
> To: qemu-devel@nongnu.org
> Cc: qemu-trivial@nongnu.org; Taylor Simpson <tsimpson@quicinc.com>;
> Philippe Mathieu-Daudé <f4bug@amsat.org>
> Subject: [PATCH] target/hexagon/gen_tcg_funcs: Fix a typo
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/hexagon/gen_tcg_funcs.py | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/target/hexagon/gen_tcg_funcs.py
> b/target/hexagon/gen_tcg_funcs.py
> index fe4d8e57303..db9f663a778 100755
> --- a/target/hexagon/gen_tcg_funcs.py
> +++ b/target/hexagon/gen_tcg_funcs.py
> @@ -35,7 +35,7 @@ def gen_decl_ea_tcg(f, tag):
>  def gen_free_ea_tcg(f):
>      f.write("    tcg_temp_free(EA);\n")
>
> -def genptr_decl_pair_writeble(f, tag, regtype, regid, regno):
> +def genptr_decl_pair_writable(f, tag, regtype, regid, regno):
>      regN="%s%sN" % (regtype,regid)
>      f.write("    TCGv_i64 %s%sV = tcg_temp_local_new_i64();\n" % \
>          (regtype, regid))
> @@ -54,7 +54,7 @@ def genptr_decl_pair_writeble(f, tag, regtype, regid,
> regno):
>                               (regN, regN))
>          f.write("    }\n")
>
> -def genptr_decl_writeble(f, tag, regtype, regid, regno):
> +def genptr_decl_writable(f, tag, regtype, regid, regno):
>      regN="%s%sN" % (regtype,regid)
>      f.write("    TCGv %s%sV = tcg_temp_local_new();\n" % \
>          (regtype, regid))
> @@ -78,12 +78,12 @@ def genptr_decl(f, tag, regtype, regid, regno):
>              f.write("    const int %s = insn->regno[%d];\n" % \
>                  (regN, regno))
>          elif (regid in {"dd", "ee", "xx", "yy"}):
> -            genptr_decl_pair_writeble(f, tag, regtype, regid, regno)
> +            genptr_decl_pair_writable(f, tag, regtype, regid, regno)
>          elif (regid in {"s", "t", "u", "v"}):
>              f.write("    TCGv %s%sV = hex_gpr[insn->regno[%d]];\n" % \
>                  (regtype, regid, regno))
>          elif (regid in {"d", "e", "x", "y"}):
> -            genptr_decl_writeble(f, tag, regtype, regid, regno)
> +            genptr_decl_writable(f, tag, regtype, regid, regno)
>          else:
>              print("Bad register parse: ", regtype, regid)
>      elif (regtype == "P"):
> @@ -91,7 +91,7 @@ def genptr_decl(f, tag, regtype, regid, regno):
>              f.write("    TCGv %s%sV = hex_pred[insn->regno[%d]];\n" % \
>                  (regtype, regid, regno))
>          elif (regid in {"d", "e", "x"}):
> -            genptr_decl_writeble(f, tag, regtype, regid, regno)
> +            genptr_decl_writable(f, tag, regtype, regid, regno)
>          else:
>              print("Bad register parse: ", regtype, regid)
>      elif (regtype == "C"):
> @@ -101,14 +101,14 @@ def genptr_decl(f, tag, regtype, regid, regno):
>              f.write("    const int %s = insn->regno[%d] + HEX_REG_SA0;\n" % \
>                  (regN, regno))
>          elif (regid == "dd"):
> -            genptr_decl_pair_writeble(f, tag, regtype, regid, regno)
> +            genptr_decl_pair_writable(f, tag, regtype, regid, regno)
>          elif (regid == "s"):
>              f.write("    TCGv %s%sV = tcg_temp_local_new();\n" % \
>                  (regtype, regid))
>              f.write("    const int %s%sN = insn->regno[%d] + HEX_REG_SA0;\n" % \
>                  (regtype, regid, regno))
>          elif (regid == "d"):
> -            genptr_decl_writeble(f, tag, regtype, regid, regno)
> +            genptr_decl_writable(f, tag, regtype, regid, regno)
>          else:
>              print("Bad register parse: ", regtype, regid)
>      elif (regtype == "M"):
> --
> 2.26.2

Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] target/hexagon/gen_tcg_funcs: Fix a typo
  2021-02-25 18:15 [PATCH] target/hexagon/gen_tcg_funcs: Fix a typo Philippe Mathieu-Daudé
  2021-02-25 18:35 ` Taylor Simpson
@ 2021-03-09 20:31 ` Laurent Vivier
  1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-03-09 20:31 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial, Taylor Simpson

Le 25/02/2021 à 19:15, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/hexagon/gen_tcg_funcs.py | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/target/hexagon/gen_tcg_funcs.py b/target/hexagon/gen_tcg_funcs.py
> index fe4d8e57303..db9f663a778 100755
> --- a/target/hexagon/gen_tcg_funcs.py
> +++ b/target/hexagon/gen_tcg_funcs.py
> @@ -35,7 +35,7 @@ def gen_decl_ea_tcg(f, tag):
>  def gen_free_ea_tcg(f):
>      f.write("    tcg_temp_free(EA);\n")
>  
> -def genptr_decl_pair_writeble(f, tag, regtype, regid, regno):
> +def genptr_decl_pair_writable(f, tag, regtype, regid, regno):
>      regN="%s%sN" % (regtype,regid)
>      f.write("    TCGv_i64 %s%sV = tcg_temp_local_new_i64();\n" % \
>          (regtype, regid))
> @@ -54,7 +54,7 @@ def genptr_decl_pair_writeble(f, tag, regtype, regid, regno):
>                               (regN, regN))
>          f.write("    }\n")
>  
> -def genptr_decl_writeble(f, tag, regtype, regid, regno):
> +def genptr_decl_writable(f, tag, regtype, regid, regno):
>      regN="%s%sN" % (regtype,regid)
>      f.write("    TCGv %s%sV = tcg_temp_local_new();\n" % \
>          (regtype, regid))
> @@ -78,12 +78,12 @@ def genptr_decl(f, tag, regtype, regid, regno):
>              f.write("    const int %s = insn->regno[%d];\n" % \
>                  (regN, regno))
>          elif (regid in {"dd", "ee", "xx", "yy"}):
> -            genptr_decl_pair_writeble(f, tag, regtype, regid, regno)
> +            genptr_decl_pair_writable(f, tag, regtype, regid, regno)
>          elif (regid in {"s", "t", "u", "v"}):
>              f.write("    TCGv %s%sV = hex_gpr[insn->regno[%d]];\n" % \
>                  (regtype, regid, regno))
>          elif (regid in {"d", "e", "x", "y"}):
> -            genptr_decl_writeble(f, tag, regtype, regid, regno)
> +            genptr_decl_writable(f, tag, regtype, regid, regno)
>          else:
>              print("Bad register parse: ", regtype, regid)
>      elif (regtype == "P"):
> @@ -91,7 +91,7 @@ def genptr_decl(f, tag, regtype, regid, regno):
>              f.write("    TCGv %s%sV = hex_pred[insn->regno[%d]];\n" % \
>                  (regtype, regid, regno))
>          elif (regid in {"d", "e", "x"}):
> -            genptr_decl_writeble(f, tag, regtype, regid, regno)
> +            genptr_decl_writable(f, tag, regtype, regid, regno)
>          else:
>              print("Bad register parse: ", regtype, regid)
>      elif (regtype == "C"):
> @@ -101,14 +101,14 @@ def genptr_decl(f, tag, regtype, regid, regno):
>              f.write("    const int %s = insn->regno[%d] + HEX_REG_SA0;\n" % \
>                  (regN, regno))
>          elif (regid == "dd"):
> -            genptr_decl_pair_writeble(f, tag, regtype, regid, regno)
> +            genptr_decl_pair_writable(f, tag, regtype, regid, regno)
>          elif (regid == "s"):
>              f.write("    TCGv %s%sV = tcg_temp_local_new();\n" % \
>                  (regtype, regid))
>              f.write("    const int %s%sN = insn->regno[%d] + HEX_REG_SA0;\n" % \
>                  (regtype, regid, regno))
>          elif (regid == "d"):
> -            genptr_decl_writeble(f, tag, regtype, regid, regno)
> +            genptr_decl_writable(f, tag, regtype, regid, regno)
>          else:
>              print("Bad register parse: ", regtype, regid)
>      elif (regtype == "M"):
> 

Applied to my trivial-patches branch.

Thanks,
Laurent



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-09 21:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 18:15 [PATCH] target/hexagon/gen_tcg_funcs: Fix a typo Philippe Mathieu-Daudé
2021-02-25 18:35 ` Taylor Simpson
2021-03-09 20:31 ` Laurent Vivier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).