From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50AB6C433F5 for ; Wed, 22 Sep 2021 19:38:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF20D61038 for ; Wed, 22 Sep 2021 19:38:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DF20D61038 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen0n.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:53622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT84k-0001DM-S7 for qemu-devel@archiver.kernel.org; Wed, 22 Sep 2021 15:38:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT7Vi-0006Hb-Uc for qemu-devel@nongnu.org; Wed, 22 Sep 2021 15:02:26 -0400 Received: from [115.28.160.31] (port=41074 helo=mailbox.box.xen0n.name) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT7Vg-0008L3-0M for qemu-devel@nongnu.org; Wed, 22 Sep 2021 15:02:26 -0400 Received: from [192.168.9.172] (unknown [101.88.29.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id AC7C763415; Thu, 23 Sep 2021 03:02:14 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=xen0n.name; s=mail; t=1632337334; bh=G18VwkLwJz0MJCkMD3Fd8QqdfRPpoVB5wGZucaHO4dc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YhTYtciMqatmI4MT+6fLb1NLIxY7o98sdHAhsCv34QXfwskrRSckhrMxhU75RciYc 7DVaeapQ+ub3yYKokvlyso7S7da/f5nYPoio+b3GGZ6aeuiToJla2UoCXyJwzgVs5J WzcF5xULsrJEkX6HcRKcWONufSLyw5nbxDZm9F64= Message-ID: Date: Thu, 23 Sep 2021 03:02:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0a1 Subject: Re: [PATCH v3 09/30] tcg/loongarch64: Implement tcg_out_mov and tcg_out_movi Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org References: <20210922180927.666273-1-git@xen0n.name> <20210922180927.666273-10-git@xen0n.name> <9e63bd14-8957-65a3-0eef-65a533a9e55d@linaro.org> From: WANG Xuerui In-Reply-To: <9e63bd14-8957-65a3-0eef-65a533a9e55d@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 115.28.160.31 (failed) Received-SPF: pass client-ip=115.28.160.31; envelope-from=i.qemu@xen0n.name; helo=mailbox.box.xen0n.name X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Richard, On 9/23/21 02:39, Richard Henderson wrote: > On 9/22/21 11:09 AM, WANG Xuerui wrote: >> +    if (pc_offset == (int32_t)pc_offset) { >> +        tcg_target_long lo = sextreg(pc_offset, 0, 12); >> +        tcg_target_long hi = pc_offset - lo; >> +        tcg_out_opc_pcaddu12i(s, rd, hi >> 12); >> +        tcg_out_opc_addi_d(s, rd, rd, lo); > > pc_offset = 0x7ffff800 will fail: > > lo = 0xfffffffffffff800 > hi = 0x0000000080000000 > > but hi will be interpreted as negative by pcaddu12i. > > This is the same problem I pointed out with tcg_out_call, but with > different constants. > Hmm, I think I'll have to look into this, but not now (it's again 3 am here)... I'll try to come up with something tomorrow. > > r~