From: Rebecca Cran <rebecca@nuviainc.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v2 1/3] target/arm: Remove PSTATE_SS from cpsr and move it into env->pstate.
Date: Fri, 22 Jan 2021 17:28:35 -0700 [thread overview]
Message-ID: <fcf91a71-f023-f4ce-adc4-d8925be3970f@nuviainc.com> (raw)
In-Reply-To: <d2a1c4ed-cac9-4bb9-9c13-e47132df3af9@linaro.org>
On 1/22/21 2:03 PM, Richard Henderson wrote:
> On 1/21/21 6:45 PM, Rebecca Cran wrote:
>> cpsr_write(env, spsr, mask, CPSRWriteRaw);
>> - if (!arm_singlestep_active(env)) {
>> - env->uncached_cpsr &= ~PSTATE_SS;
>> - }
>> + env->pstate &= ~PSTATE_SS;
>
> Why are you removing the singlestep check?
>> - env->uncached_cpsr &= ~PSTATE_SS;
>> - env->spsr = cpsr_read(env);
>> + env->pstate &= ~PSTATE_SS;
>> + env->spsr &= ~PSTATE_SS;
>
> This loses the saving of cpsr into spsr.
Oh, right. I've fixed both this and the above issue in the next revision
which I'll send out early next week (giving a chance for any extra
feedback).
Thanks.
--
Rebecca Cran
next prev parent reply other threads:[~2021-01-23 0:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 4:45 [PATCH v2 0/3] target/arm: Add support for FEAT_DIT, Data Independent Timing Rebecca Cran
2021-01-22 4:45 ` [PATCH v2 1/3] target/arm: Remove PSTATE_SS from cpsr and move it into env->pstate Rebecca Cran
2021-01-22 21:03 ` Richard Henderson
2021-01-23 0:28 ` Rebecca Cran [this message]
2021-01-22 4:45 ` [PATCH v2 2/3] target/arm: Add support for FEAT_DIT, Data Independent Timing Rebecca Cran
2021-01-22 21:07 ` Richard Henderson
2021-01-22 4:45 ` [PATCH v2 3/3] target/arm: Set ID_AA64PFR0.DIT and ID_PFR0.DIT to 1 for "max" AA64 CPU Rebecca Cran
2021-01-22 21:06 ` Richard Henderson
2021-01-23 0:27 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcf91a71-f023-f4ce-adc4-d8925be3970f@nuviainc.com \
--to=rebecca@nuviainc.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).