From: Eric Blake <eblake@redhat.com>
To: "Darrin M. Gorski" <darrin@gorski.net>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH v1 1/1] chardev: enable guest socket status/crontrol via DTR and DCD
Date: Wed, 23 Dec 2020 16:13:12 -0600 [thread overview]
Message-ID: <fd3a6a86-ead8-9ad2-c7e6-d67c8dc60afd@redhat.com> (raw)
In-Reply-To: <CACdcevLHrP_HZED=SHMUzpF5vfFawJ3gYOKdeH1X1PHRFpWLgg@mail.gmail.com>
On 12/16/20 4:06 PM, Darrin M. Gorski wrote:
> This patch adds a 'modemctl' option to "-chardev socket" to enable control
> of the socket via the guest serial port.
> The default state of the option is disabled.
>
> 1. disconnect a connected socket when DTR transitions to low, also reject
> new connections while DTR is low.
> 2. provide socket connection status through the carrier detect line (CD or
> DCD) on the guest serial port
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1213196
>
> Signed-off-by: Darrin M. Gorski <darrin@gorski.net>
>
>
> diff --git a/chardev/char-socket.c b/chardev/char-socket.c
Hmm - your workflow did not produce the usual --- marker and a diffstat
of which files were in the patch; this makes it easier for reviewers to
see at a glance what the rest of the email will contain. It's not
essential, but it does help.
> +++ b/qapi/char.json
> @@ -271,6 +271,9 @@
> # then attempt a reconnect after the given number of seconds.
> # Setting this to zero disables this function. (default: 0)
> # (Since: 2.2)
> +# @modemctl: allow guest to use modem control signals to control/monitor
> +# the socket state (CD follows is_connected, DTR influences
> +# connect/accept) (default: false) (Since: 5.2)
The next release will by 6.0, not 5.2.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-12-23 22:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 22:06 [PATCH v1 1/1] chardev: enable guest socket status/crontrol via DTR and DCD Darrin M. Gorski
2020-12-17 14:16 ` Marc-André Lureau
2020-12-17 17:54 ` Darrin M. Gorski
2020-12-18 11:57 ` Marc-André Lureau
2020-12-19 5:34 ` Darrin M. Gorski
2020-12-23 22:13 ` Eric Blake [this message]
2022-01-12 15:20 ` Aaro Koskinen
2022-01-12 18:50 ` Darrin M. Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd3a6a86-ead8-9ad2-c7e6-d67c8dc60afd@redhat.com \
--to=eblake@redhat.com \
--cc=darrin@gorski.net \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).