From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25758C433E0 for ; Mon, 1 Feb 2021 09:23:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5302564EA3 for ; Mon, 1 Feb 2021 09:23:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5302564EA3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6VQj-0008Kj-56 for qemu-devel@archiver.kernel.org; Mon, 01 Feb 2021 04:23:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6VPr-0007hb-FW for qemu-devel@nongnu.org; Mon, 01 Feb 2021 04:22:39 -0500 Received: from mx2.suse.de ([195.135.220.15]:47934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6VPp-0001wX-TD for qemu-devel@nongnu.org; Mon, 01 Feb 2021 04:22:39 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4F675AE76; Mon, 1 Feb 2021 09:22:36 +0000 (UTC) Subject: Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Richard Henderson References: <20210128092814.8676-1-cfontana@suse.de> <20210128092814.8676-19-cfontana@suse.de> <64d8385c-db22-b647-2402-3840b0e0e9b5@redhat.com> <9a51a203-f6a8-686f-7859-475537b3607a@suse.de> <878s8dujj5.fsf@linaro.org> <40ed971e-a4fe-77c5-94b9-28691874ee32@redhat.com> <0943e736-6847-4b6a-8433-f28f4692a299@linaro.org> <03ac58b2-619b-572f-85ae-0760c0c12bac@linaro.org> <87v9bcw3iu.fsf@linaro.org> From: Claudio Fontana Message-ID: Date: Mon, 1 Feb 2021 10:22:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <87v9bcw3iu.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.079, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Eduardo Habkost , Markus Armbruster , qemu-devel@nongnu.org, Roman Bolshakov , Alistair Francis , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/1/21 10:15 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 1/30/21 12:53 AM, Claudio Fontana wrote: >>> To summarize: >>> >>> 1) accel->cpu_realizefn extends the current cpu target-specific realize functions with accelerator-specific code, >>> which currently does not make use of errp at all (thus, the temptation to remove errp from the interface until it is actually needed by a target). >> >> No, arm does use errp in realizefn already. >> It's just that the void return value is hinky. > > Sounds like fixing the void return would be part of a larger qdev > clean-up rather than this particular series. If I recall there have been > various phases of clean-ups and refactoring of the error code paths in > the past. > >> >> >> r~ > > I think you are right. I added a patch in this series to at least not make the problem worse, by adding a return value to accel_cpu::cpu_realizefn, and cleaning up the only code path case that signals an error there for now in i386. (will add as the last patch in the series) Thanks, Claudio