From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D558C433ED for ; Wed, 12 May 2021 02:57:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF6D261278 for ; Wed, 12 May 2021 02:57:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF6D261278 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgf3f-0002rL-Ue for qemu-devel@archiver.kernel.org; Tue, 11 May 2021 22:57:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgf2i-00022n-3w for qemu-devel@nongnu.org; Tue, 11 May 2021 22:56:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29724) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgf2f-0004ux-5n for qemu-devel@nongnu.org; Tue, 11 May 2021 22:56:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620788168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0zQwEI8otUkqqKeq8bINhFvKtfFUVHOHOWw7x4EJDPQ=; b=Is55RbfYn4c0wVhesAfrdkdCSEKYwQTPfLUX9N6eWwqmYZV24+Bx5RKjVtGTsBUmhOZNtb i+8z1HXdrrlCGFLdtPzAP3UzHR/h2w0PuQlBLEKpgQHI6VG+WYmYiOe+1zB4UiyTLeFmOR 6uZty8zL7o2dkqEGSbRcXlMJ/F3GpVI= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-0RqguxkuPUa19xYP5v-jsw-1; Tue, 11 May 2021 22:56:06 -0400 X-MC-Unique: 0RqguxkuPUa19xYP5v-jsw-1 Received: by mail-pl1-f199.google.com with SMTP id o19-20020a170902e293b02900ef869214f9so10349plc.18 for ; Tue, 11 May 2021 19:56:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=0zQwEI8otUkqqKeq8bINhFvKtfFUVHOHOWw7x4EJDPQ=; b=rboFecPyejyzLLXdPiW06wJFKS1Oc15/1HmZI+T8xFN5xF/SLXubOnabmRpMpVbD0C 6pAM8PytZk1qIC5a1Ps/BD5hgC4G1joPngIbVDFU880gfECYHg6Xn2mkrIoZ5mC8HY9L iHqlw/fD9jvY/xhVRcBEB8ta/GBovz/z39l4yNlqsjpq5/kLJBCZGzuvcnbYMJxi/lma UMYrxJCIniODGGpucFPNXAWQpsAtTL7/kjddXhqYqzT3CKeGZcVEkvTh3qkb1a4Wff0n 6Py6I1FsX2oSujK2T6eyCdZBfQyvZccVKIzd8EkhRPGb+YCI8o7MgBz50jAQEl8kTrih acZA== X-Gm-Message-State: AOAM5301Z+Qz5c2Wr/6GMnf2vdpUBwMi2wZAmNajtDNck5inDsAy/9Ks BCImZu3jjJt+U9yxLdiouTjWsLo8+YDQXkV40RlCmSNJU9OOTMWpT0UjWZ+KWXITT8mvEWmN/21 zuk/zpvFD1CkehTc= X-Received: by 2002:a17:90a:aa14:: with SMTP id k20mr8794107pjq.88.1620788165847; Tue, 11 May 2021 19:56:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypIXyOx9ke9A0quNXF//7PNBPjWEo9rqsdrKKjTSnMQodBH/idYEpx96naaPhf0r9DxFtp8Q== X-Received: by 2002:a17:90a:aa14:: with SMTP id k20mr8794074pjq.88.1620788165532; Tue, 11 May 2021 19:56:05 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id j16sm15632697pgh.69.2021.05.11.19.56.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 May 2021 19:56:04 -0700 (PDT) Subject: Re: [PATCH 1/3] hw/virtio: Pass virtio_feature_get_config_size() a const argument To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210511104157.2880306-1-philmd@redhat.com> <20210511104157.2880306-2-philmd@redhat.com> From: Jason Wang Message-ID: Date: Wed, 12 May 2021 10:55:59 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210511104157.2880306-2-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Max Reitz , Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2021/5/11 下午6:41, Philippe Mathieu-Daudé 写道: > The VirtIOFeature structure isn't modified, mark it const. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Jason Wang > --- > include/hw/virtio/virtio.h | 2 +- > hw/virtio/virtio.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > index b7ece7a6a89..8bab9cfb750 100644 > --- a/include/hw/virtio/virtio.h > +++ b/include/hw/virtio/virtio.h > @@ -43,7 +43,7 @@ typedef struct VirtIOFeature { > size_t end; > } VirtIOFeature; > > -size_t virtio_feature_get_config_size(VirtIOFeature *features, > +size_t virtio_feature_get_config_size(const VirtIOFeature *features, > uint64_t host_features); > > typedef struct VirtQueue VirtQueue; > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 9e13cb9e3ad..e02544b2df7 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -2981,7 +2981,7 @@ int virtio_set_features(VirtIODevice *vdev, uint64_t val) > return ret; > } > > -size_t virtio_feature_get_config_size(VirtIOFeature *feature_sizes, > +size_t virtio_feature_get_config_size(const VirtIOFeature *feature_sizes, > uint64_t host_features) > { > size_t config_size = 0;