From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECEE9C5DF60 for ; Fri, 8 Nov 2019 10:16:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B82CC2178F for ; Fri, 8 Nov 2019 10:16:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B82CC2178F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siemens.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT1Jn-00059W-Ch for qemu-devel@archiver.kernel.org; Fri, 08 Nov 2019 05:16:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44564) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT1EO-00039u-Vn for qemu-devel@nongnu.org; Fri, 08 Nov 2019 05:11:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iT1EL-0000p1-Is for qemu-devel@nongnu.org; Fri, 08 Nov 2019 05:11:02 -0500 Received: from thoth.sbs.de ([192.35.17.2]:45327) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iT1EL-0000iC-8b for qemu-devel@nongnu.org; Fri, 08 Nov 2019 05:11:01 -0500 Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id xA898YNb003511 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Nov 2019 10:08:34 +0100 Received: from [167.87.14.235] ([167.87.14.235]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id xA898Vx0018440; Fri, 8 Nov 2019 10:08:32 +0100 Subject: Re: [PATCH v2] ivshmem-server: Terminate also on SIGINT From: Jan Kiszka To: Markus Armbruster References: <99c1a7bd-1876-66a2-4b8e-d5bc86116fe7@web.de> Message-ID: Date: Fri, 8 Nov 2019 10:08:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <99c1a7bd-1876-66a2-4b8e-d5bc86116fe7@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 192.35.17.2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel , Claudio Fontana Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 03.08.19 15:22, Jan Kiszka wrote: > From: Jan Kiszka > > Allows to shutdown a foreground session via ctrl-c. > > Signed-off-by: Jan Kiszka > --- > > Changes in v2: > - adjust error message > > contrib/ivshmem-server/main.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c > index 197c79c57e..e4cd35f74c 100644 > --- a/contrib/ivshmem-server/main.c > +++ b/contrib/ivshmem-server/main.c > @@ -223,8 +223,9 @@ main(int argc, char *argv[]) > sa_quit.sa_handler = ivshmem_server_quit_cb; > sa_quit.sa_flags = 0; > if (sigemptyset(&sa_quit.sa_mask) == -1 || > - sigaction(SIGTERM, &sa_quit, 0) == -1) { > - perror("failed to add SIGTERM handler; sigaction"); > + sigaction(SIGTERM, &sa_quit, 0) == -1 || > + sigaction(SIGINT, &sa_quit, 0) == -1) { > + perror("failed to add signal handler; sigaction"); > goto err; > } > > -- > 2.16.4 > > ...and this one for you as well, Markus? Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux