From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17159C433ED for ; Fri, 2 Apr 2021 17:42:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6391E6113E for ; Fri, 2 Apr 2021 17:42:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6391E6113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bernat.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSNoh-00043Z-3J for qemu-devel@archiver.kernel.org; Fri, 02 Apr 2021 13:42:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSNmJ-0003VZ-NM for qemu-devel@nongnu.org; Fri, 02 Apr 2021 13:40:16 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSNmF-0002Ph-FW for qemu-devel@nongnu.org; Fri, 02 Apr 2021 13:40:15 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 6B5345C00DA; Fri, 2 Apr 2021 13:40:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 02 Apr 2021 13:40:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bernat.ch; h= from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type:content-transfer-encoding; s=fm3; bh= /DHbe4/1klKzERjCXDRPCjmafpsIdyuj+9SeNOc6NVg=; b=DZa1kTVWR1hNewFx k4n0KZmLgXwcnqR8wHj3OEn7Sw+zNs53dgiL8sGZTR2aRVpHmmtHda1Uw54mo8VZ gV8zjHnNRO6ZiWP+pi9HGHepd3SJi6S/NTSIIKREv0CaexxxEpEeXS+05VnF+r1l SFCDOhZ6rjpaBIoYWost7lB/29i8HSYMOnCyhD2IgkYy8KJRtv5PHwl4c7qOO1MJ pacxt57RVeWOvTw9d0YNxb0JDcOTNJH6UzCc3imU+v8fElhSHSWfJeQzsmXvqgdW ehJaF6n1eIQkbax6hg8z1kunxz2vnmLDje2HivKNT+ZhDD9F4gSemPluP38M1+Kb ieBo2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=/DHbe4/1klKzERjCXDRPCjmafpsIdyuj+9SeNOc6N Vg=; b=ayi4wZHaBfNoaus/larBspdugu07qkT3+1kCQ38QUkZNDvMnZf+4+EjQk BLKk5uH5HtrKQNOaQlyBCRENMsYuJCxPIJjS6MGGWhHkGW9w3jvLupK+F3g3XRKH IqIetGE2oM3jk/k/oR//ETXmUG/lhsVmE0rU0jkaxGh5ezWEIe0k7BRm3CcUa208 tklanHJFny17G5O68xeaPuprd6tgzcSLyPvAvJnhYzJ6uYSeRXrg98Dx3ZWmd5/6 RBrKqkzl1VO4p3rlFrJoF10oSCCGdPjgYDb2TYw5s7UWxaCVZmky5XSXDxXQnZ7f nQzbs9RdBd8oitb1s8gNWt12COwyg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeiiedguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufhffjgfkfgggtgfgsehtkeertddtreejnecuhfhrohhmpeggihhn tggvnhhtuceuvghrnhgrthcuoehvihhntggvnhhtsegsvghrnhgrthdrtghhqeenucggtf frrghtthgvrhhnpeelgeefhfdukeehfeeigfehvdffieehvdelveethedvffeuleegteei ffduiefgteenucffohhmrghinhepmhgrihhlqdgrrhgthhhivhgvrdgtohhmnecukfhppe eltddrledtrdeltddrfeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepvhhinhgtvghnthessggvrhhnrghtrdgthh X-ME-Proxy: Received: from neo.luffy.cx (lfbn-idf1-1-1655-35.w90-90.abo.wanadoo.fr [90.90.90.35]) by mail.messagingengine.com (Postfix) with ESMTPA id C1AE524005C; Fri, 2 Apr 2021 13:40:05 -0400 (EDT) Received: by neo.luffy.cx (Postfix, from userid 500) id 8F7DEADB; Fri, 2 Apr 2021 19:40:03 +0200 (CEST) From: Vincent Bernat To: Igor Mammedov Subject: Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information) References: <20210401122658.37842-1-vincent@bernat.ch> <20210401225846.411ebd76@redhat.com> Date: Fri, 02 Apr 2021 19:40:03 +0200 In-Reply-To: (Vincent Bernat's message of "Thu, 01 Apr 2021 23:07:06 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=66.111.4.29; envelope-from=vincent@bernat.ch; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P . =?utf-8?Q?Berrang=C3=A9?=" , qemu-devel@nongnu.org, "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" ❦ 1 avril 2021 23:07 +02, Vincent Bernat: >>> This can be invoked with: >>> >>> $QEMU -netdev user,id=internet >>> -device virtio-net-pci,mac=50:54:00:00:00:42,netdev=internet,id=internet-dev \ >>> -smbios type=41,designation='Onboard LAN',instance=1,kind=ethernet,pcidev=internet-dev >> >> an ACPI alternative was merged recently (current master). >> assigning 'designation=' wasn't implemented there, but important part >> of giving users control over PCI devices 'eno' index is implemented. >> >> When I looked into the issue, smbios way was a bit over-kill for the task >> and didn't really work if hotplug were used. >> >> See, for example how to use new feature: >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg794164.html > > It seems simpler this way. I don't think my patch is needed then. Well, after thinking a bit, if the patch is good enough, maybe it can still be merged. It is fairly generic and it adds the ability to set the name of the card. It's not as convenient as using acpi-index, but I could add a note about acpi-index in the documentation to let people know they may prefer the simpler acpi-index? -- Avoid temporary variables. - The Elements of Programming Style (Kernighan & Plauger)