Re: [PATCH v5 0/2] RTC support for QEMU RISC-V virt machine

From: Palmer Dabbelt <palmer@dabbelt.com>
To: anup@brainfault.org, Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-riscv@nongnu.org, sagark@eecs.berkeley.edu,
	Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
	Anup Patel <Anup.Patel@wdc.com>,
	qemu-devel@nongnu.org, Atish Patra <Atish.Patra@wdc.com>,
	Alistair Francis <Alistair.Francis@wdc.com>,
	alistair23@gmail.com
Subject: Re: [PATCH v5 0/2] RTC support for QEMU RISC-V virt machine
Date: Fri, 01 Nov 2019 16:14:14 -0700 (PDT)	[thread overview]
Message-ID: <mhng-111ec6b3-0e63-4f94-a1ed-8ddcd354b943@palmer-si-x1c4> (raw)
In-Reply-To: <CAAhSdy3sUb_r77NBvEQEAQ0EQB99=4jgAbH3ADOqvJ_iX+o8pg@mail.gmail.com>

On Fri, 01 Nov 2019 08:40:24 PDT (-0700), anup@brainfault.org wrote:
> On Tue, Oct 29, 2019 at 6:55 PM Alistair Francis <alistair23@gmail.com> wrote:
>>
>> On Fri, Oct 25, 2019 at 6:28 AM Anup Patel <Anup.Patel@wdc.com> wrote:
>> >
>> > This series adds RTC device to QEMU RISC-V virt machine. We have
>> > selected Goldfish RTC device model for this. It's a pretty simple
>> > synthetic device with few MMIO registers and no dependency external
>> > clock. The driver for Goldfish RTC is already available in Linux so
>> > we just need to enable it in Kconfig for RISCV and also update Linux
>> > defconfigs.
>> >
>> > We have tested this series with Linux-5.4-rc4 plus defconfig changes
>> > available in 'goldfish_rtc_v2' branch of:
>> > https://github.com/avpatel/linux.git
>>
>> @Peter Maydell this has been reviewed, do you mind taking this in you
>> next PR? I don't see a maintainer for hw/rtc.
>
> It would be great if this series can be taken for QEMU-4.2

It doesn't look like there's anyone who maintains hw/rtc, so maybe that's why 
this has been going slowly?  I'd happy to PR it, but I don't really have the 
bandwidth to sign up to maintain more stuff right now.

>
> Regards,
> Anup
>
>>
>> Alistair
>>
>> >
>> > Changes since v4:
>> >  - Fixed typo in trace event usage
>> >  - Moved goldfish_rtc.h to correct location
>> >
>> > Changes since v3:
>> >  - Address all nit comments from Alistair
>> >
>> > Changes since v2:
>> >  - Rebased on RTC code refactoring
>> >
>> > Changes since v1:
>> >  - Implemented VMState save/restore callbacks
>> >
>> > Anup Patel (2):
>> >   hw: rtc: Add Goldfish RTC device
>> >   riscv: virt: Use Goldfish RTC device
>> >
>> >  hw/riscv/Kconfig              |   1 +
>> >  hw/riscv/virt.c               |  15 ++
>> >  hw/rtc/Kconfig                |   3 +
>> >  hw/rtc/Makefile.objs          |   1 +
>> >  hw/rtc/goldfish_rtc.c         | 288 ++++++++++++++++++++++++++++++++++
>> >  hw/rtc/trace-events           |   4 +
>> >  include/hw/riscv/virt.h       |   2 +
>> >  include/hw/rtc/goldfish_rtc.h |  46 ++++++
>> >  8 files changed, 360 insertions(+)
>> >  create mode 100644 hw/rtc/goldfish_rtc.c
>> >  create mode 100644 include/hw/rtc/goldfish_rtc.h
>> >
>> > --
>> > 2.17.1
>> >