From: Palmer Dabbelt <palmerdabbelt@google.com>
To: alistair23@gmail.com
Cc: pannengyuan@huawei.com,
Alistair Francis <Alistair.Francis@wdc.com>,
sagark@eecs.berkeley.edu,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
zhang.zhanghailiang@huawei.com
Subject: Re: [PATCH] riscv/sifive_u: fix a memory leak in soc_realize()
Date: Thu, 09 Jan 2020 15:42:28 -0800 (PST) [thread overview]
Message-ID: <mhng-8d4724ea-7312-45f2-8f14-fb3175ca9b6a@palmerdabbelt-glaptop> (raw)
In-Reply-To: <CAKmqyKNH0NdhksX35C7Cm1e51in-iRBrmH8TJWGYregCgLgO6w@mail.gmail.com>
On Tue, 10 Dec 2019 10:38:29 PST (-0800), alistair23@gmail.com wrote:
> On Mon, Dec 9, 2019 at 11:15 PM <pannengyuan@huawei.com> wrote:
>>
>> From: Pan Nengyuan <pannengyuan@huawei.com>
>>
>> Fix a minor memory leak in riscv_sifive_u_soc_realize()
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Thanks. This is in the queue, I'm hoping to submit a PR after the H patch set
is ready to go.
>
> Alistair
>
>> ---
>> hw/riscv/sifive_u.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c
>> index 0140e95..0e12b3c 100644
>> --- a/hw/riscv/sifive_u.c
>> +++ b/hw/riscv/sifive_u.c
>> @@ -542,6 +542,7 @@ static void riscv_sifive_u_soc_realize(DeviceState *dev, Error **errp)
>> SIFIVE_U_PLIC_CONTEXT_BASE,
>> SIFIVE_U_PLIC_CONTEXT_STRIDE,
>> memmap[SIFIVE_U_PLIC].size);
>> + g_free(plic_hart_config);
>> sifive_uart_create(system_memory, memmap[SIFIVE_U_UART0].base,
>> serial_hd(0), qdev_get_gpio_in(DEVICE(s->plic), SIFIVE_U_UART0_IRQ));
>> sifive_uart_create(system_memory, memmap[SIFIVE_U_UART1].base,
>> --
>> 2.7.2.windows.1
>>
>>
>>
prev parent reply other threads:[~2020-01-09 23:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 7:14 [PATCH] riscv/sifive_u: fix a memory leak in soc_realize() pannengyuan
2019-12-10 7:46 ` Philippe Mathieu-Daudé
2019-12-10 18:38 ` Alistair Francis
2020-01-09 23:42 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-8d4724ea-7312-45f2-8f14-fb3175ca9b6a@palmerdabbelt-glaptop \
--to=palmerdabbelt@google.com \
--cc=Alistair.Francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=pannengyuan@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).