From: Palmer Dabbelt <palmer@dabbelt.com>
To: Atish Patra <Atish.Patra@wdc.com>
Cc: qemu-riscv@nongnu.org, sagark@eecs.berkeley.edu,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Anup Patel <Anup.Patel@wdc.com>,
qemu-devel@nongnu.org, Atish Patra <Atish.Patra@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
bmeng.cn@gmail.com
Subject: Re: [PATCH] RISC-V: Place DTB at 3GB boundary instead of 4GB
Date: Thu, 17 Dec 2020 14:31:32 -0800 (PST) [thread overview]
Message-ID: <mhng-b0271174-4849-4bcd-a63d-b53fafb1ab89@palmerdabbelt-glaptop> (raw)
In-Reply-To: <20201217214826.2094617-1-atish.patra@wdc.com>
On Thu, 17 Dec 2020 13:48:26 PST (-0800), Atish Patra wrote:
> Currently, we place the DTB at 2MB from 4GB or end of DRAM which ever is
> lesser. However, Linux kernel can address only 1GB of memory for RV32.
> Thus, it can not map anything beyond 3GB (assuming 2GB is the starting address).
> As a result, it can not process DT and panic if opensbi dynamic firmware
> is used.
>
> Fix this by placing the DTB at 2MB from 3GB or end of DRAM whichever is lower.
>
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
> ---
> hw/riscv/boot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
> index d62f3dc7581e..9e77b22e4d56 100644
> --- a/hw/riscv/boot.c
> +++ b/hw/riscv/boot.c
> @@ -203,9 +203,9 @@ uint32_t riscv_load_fdt(hwaddr dram_base, uint64_t mem_size, void *fdt)
> * We should put fdt as far as possible to avoid kernel/initrd overwriting
> * its content. But it should be addressable by 32 bit system as well.
> * Thus, put it at an aligned address that less than fdt size from end of
> - * dram or 4GB whichever is lesser.
> + * dram or 3GB whichever is lesser.
> */
> - temp = MIN(dram_end, 4096 * MiB);
> + temp = MIN(dram_end, 3072 * MiB);
> fdt_addr = QEMU_ALIGN_DOWN(temp - fdtsize, 2 * MiB);
>
> fdt_pack(fdt);
Presumably this was the cause of that 32-bit boot issue?
next prev parent reply other threads:[~2020-12-17 22:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 21:48 [PATCH] RISC-V: Place DTB at 3GB boundary instead of 4GB Atish Patra
2020-12-17 22:31 ` Palmer Dabbelt [this message]
2020-12-17 22:35 ` Atish Patra
2020-12-17 22:39 ` Palmer Dabbelt
2020-12-18 7:21 ` Bin Meng
2020-12-18 7:27 ` Atish Patra
2020-12-18 7:33 ` Bin Meng
2020-12-18 8:00 ` Atish Patra
2020-12-18 8:42 ` Bin Meng
2020-12-18 19:46 ` Atish Patra
2020-12-22 5:35 ` Bin Meng
2020-12-22 19:59 ` Atish Patra
2020-12-23 1:20 ` Bin Meng
2020-12-29 4:49 ` Bin Meng
2021-01-04 20:24 ` Atish Patra
2021-01-05 3:06 ` Bin Meng
2021-01-05 3:11 ` Bin Meng
2021-01-05 21:02 ` Alistair Francis
2021-01-05 23:44 ` Atish Patra
2021-01-06 0:04 ` Bin Meng
2021-01-06 2:14 ` Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-b0271174-4849-4bcd-a63d-b53fafb1ab89@palmerdabbelt-glaptop \
--to=palmer@dabbelt.com \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=bmeng.cn@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).