From: Alberto Garcia <berto@igalia.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, armbru@redhat.com, mreitz@redhat.com
Subject: Re: [PATCH v12 2/3] qcow2: Allow writing compressed data of multiple clusters
Date: Fri, 10 Apr 2020 13:12:03 +0200 [thread overview]
Message-ID: <w51pncf61do.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <5bbb126f-37c0-f107-c3b3-667ed43670fa@virtuozzo.com>
On Thu 09 Apr 2020 08:39:12 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
>> Because of this a test cannot expect that running the same commands on
>> an empty image produces always the same results.
>>
>> Is this something that we should be concerned about?
>
> Parallel writing compressed clusters is significant improvement, as it
> allow compressing in really parallel threads.
I see, I just wasn't sure if you were aware of this side effect.
> So, I don't think we should make specific workaround for
> testing... What exactly is the case?
I noticed this while writing some tests for the subcluster allocation
feature, but this is not a problem for me. Many of our iotests make
assumptions about the location of L2 and refcount tables so changing
those would break a lot of them. This thing only changes the offset of
the compressed data clusters (and their L2 entries), but as far as I'm
aware no one relies on them being predictable. I just need to make sure
that I don't do it either.
Berto
next prev parent reply other threads:[~2020-04-10 11:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 12:15 [PATCH v12 0/3] qcow2: advanced compression options Andrey Shinkevich
2019-12-02 12:15 ` [PATCH v12 1/3] block: introduce compress filter driver Andrey Shinkevich
2019-12-20 14:52 ` Max Reitz
2019-12-20 15:11 ` Andrey Shinkevich
2019-12-02 12:15 ` [PATCH v12 2/3] qcow2: Allow writing compressed data of multiple clusters Andrey Shinkevich
2020-04-09 16:50 ` Alberto Garcia
2020-04-09 18:39 ` Vladimir Sementsov-Ogievskiy
2020-04-10 0:12 ` Andrey Shinkevich
2020-04-10 5:10 ` Vladimir Sementsov-Ogievskiy
2020-04-10 11:12 ` Alberto Garcia [this message]
2020-04-10 11:44 ` Vladimir Sementsov-Ogievskiy
2019-12-02 12:15 ` [PATCH v12 3/3] tests/qemu-iotests: add case to write " Andrey Shinkevich
2019-12-18 11:46 ` [PATCH v12 0/3] qcow2: advanced compression options Andrey Shinkevich
2019-12-20 15:45 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51pncf61do.fsf@maestria.local.igalia.com \
--to=berto@igalia.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).